Firebase In-app messaging callbacks (#2354)

* FIRInAppMessagingDisplayMessage and FIRInAppMessagingDisplayDelegate refactor + downstream changes

* More downstream changes from FIRInAppMessagingDisplayDelegate, calling through to app-side delegate from default display executor

* Add delegate property on FIRInAppMessaging

* Display SDK changes to pass through in app message with callbacks

* Headless SDK unit test refactoring

* Display test app downstream changes

* Pull in headless SDK in display app, no need to have this come in as a framework anymore

* Run scripts/style.sh

* Remove WIP test

* Refactor FIRIAMDIsplayExecutor to take an InAppMessaging object for testing

* Depend on FirebaseAnalyticsInterop in UI test app

* File imports for FIRInAppMessaging files

* Remove FirebaseInAppMessaging imports
This commit is contained in:
christibbs authored and GitHub committed 2019-02-08 14:20:27 -08:00
1 parent 26f021a838
commit c8899e294d
20 files changed
+547 -187

No files matched your search

@@ -16,22 +16,27 @@
import Foundation
import FirebaseInAppMessaging
class CommonMessageTestVC: UIViewController, InAppMessagingDisplayDelegate {
var messageClosedWithClick = false
var messageClosedDismiss = false
// start of InAppMessagingDisplayDelegate functions
func messageClicked() {
func messageClicked(_ inAppMessage: InAppMessagingDisplayMessage) {
print("message clicked to follow action url")
messageClosedWithClick = true
}
func impressionDetected() { print("valid impression detected") }
func displayErrorEncountered(_ error: Error) { print("error encountered \(error)") }
func messageDismissed(dismissType: FIRInAppMessagingDismissType) {
func impressionDetected(for inAppMessage: InAppMessagingDisplayMessage) {
print("valid impression detected")
}
func displayError(for inAppMessage: InAppMessagingDisplayMessage, error: Error) {
print("error encountered \(error)")
}
func messageDismissed(_ inAppMessage: InAppMessagingDisplayMessage,
dismissType: FIRInAppMessagingDismissType) {
print("message dimissed with type \(dismissType)")
messageClosedDismiss = true
}