Firebase In-app messaging callbacks (#2354)

* FIRInAppMessagingDisplayMessage and FIRInAppMessagingDisplayDelegate refactor + downstream changes

* More downstream changes from FIRInAppMessagingDisplayDelegate, calling through to app-side delegate from default display executor

* Add delegate property on FIRInAppMessaging

* Display SDK changes to pass through in app message with callbacks

* Headless SDK unit test refactoring

* Display test app downstream changes

* Pull in headless SDK in display app, no need to have this come in as a framework anymore

* Run scripts/style.sh

* Remove WIP test

* Refactor FIRIAMDIsplayExecutor to take an InAppMessaging object for testing

* Depend on FirebaseAnalyticsInterop in UI test app

* File imports for FIRInAppMessaging files

* Remove FirebaseInAppMessaging imports
This commit is contained in:
christibbs authored and GitHub committed 2019-02-08 14:20:27 -08:00
1 parent 26f021a838
commit c8899e294d
20 files changed
+547 -187

No files matched your search

@@ -14,20 +14,20 @@
* limitations under the License.
*/
import UIKit
import FirebaseInAppMessaging
class ImageOnlyMessageViewController: CommonMessageTestVC {
let displayImpl = InAppMessagingDefaultDisplayImpl()
@IBOutlet var verifyLabel: UILabel!
override func messageClicked() {
super.messageClicked()
override func messageClicked(_ inAppMessage: InAppMessagingDisplayMessage) {
super.messageClicked(inAppMessage)
verifyLabel.text = "message clicked!"
}
override func messageDismissed(dismissType dimissType: FIRInAppMessagingDismissType) {
super.messageClicked()
override func messageDismissed(_ inAppMessage: InAppMessagingDisplayMessage,
dismissType: FIRInAppMessagingDismissType) {
super.messageClicked(inAppMessage)
verifyLabel.text = "message dismissed!"
}
@@ -37,9 +37,11 @@ class ImageOnlyMessageViewController: CommonMessageTestVC {
let fiamImageData = InAppMessagingImageData(imageURL: "url not important", imageData: imageRawData!)
let modalMessage = InAppMessagingImageOnlyDisplay(messageID: "messageId",
campaignName: "testCampaign",
renderAsTestMessage: false,
imageData: fiamImageData)
triggerType: .onAnalyticsEvent,
imageData: fiamImageData,
actionURL: URL(string: "http://firebase.com"))
displayImpl.displayMessage(modalMessage, displayDelegate: self)
}
@@ -49,9 +51,11 @@ class ImageOnlyMessageViewController: CommonMessageTestVC {
let fiamImageData = InAppMessagingImageData(imageURL: "url not important", imageData: imageRawData!)
let modalMessage = InAppMessagingImageOnlyDisplay(messageID: "messageId",
campaignName: "testCampaign",
renderAsTestMessage: false,
imageData: fiamImageData)
triggerType: .onAnalyticsEvent,
imageData: fiamImageData,
actionURL: URL(string: "http://firebase.com"))
displayImpl.displayMessage(modalMessage, displayDelegate: self)
}
@@ -61,9 +65,11 @@ class ImageOnlyMessageViewController: CommonMessageTestVC {
let fiamImageData = InAppMessagingImageData(imageURL: "url not important", imageData: imageRawData!)
let modalMessage = InAppMessagingImageOnlyDisplay(messageID: "messageId",
campaignName: "testCampaign",
renderAsTestMessage: false,
imageData: fiamImageData)
triggerType: .onAnalyticsEvent,
imageData: fiamImageData,
actionURL: URL(string: "http://firebase.com"))
displayImpl.displayMessage(modalMessage, displayDelegate: self)
}
@@ -73,9 +79,11 @@ class ImageOnlyMessageViewController: CommonMessageTestVC {
let fiamImageData = InAppMessagingImageData(imageURL: "url not important", imageData: imageRawData!)
let modalMessage = InAppMessagingImageOnlyDisplay(messageID: "messageId",
campaignName: "testCampaign",
renderAsTestMessage: false,
imageData: fiamImageData)
triggerType: .onAnalyticsEvent,
imageData: fiamImageData,
actionURL: URL(string: "http://firebase.com"))
displayImpl.displayMessage(modalMessage, displayDelegate: self)
}
@@ -84,9 +92,11 @@ class ImageOnlyMessageViewController: CommonMessageTestVC {
let fiamImageData = InAppMessagingImageData(imageURL: "url not important", imageData: imageRawData!)
let modalMessage = InAppMessagingImageOnlyDisplay(messageID: "messageId",
campaignName: "testCampaign",
renderAsTestMessage: false,
imageData: fiamImageData)
triggerType: .onAnalyticsEvent,
imageData: fiamImageData,
actionURL: URL(string: "http://firebase.com"))
displayImpl.displayMessage(modalMessage, displayDelegate: self)
}
}