* Fix container instantiation timing, IID startup.
The container instantiation could happen at the wrong time, before all
components have been added to the container. This fixes it, and also
moves IID to use the proper instantiation timing instead of relying on
the `configureWithApp:` call. This is part continuation of #3147, where
I'll be fixing the rest of the SDKs in follow up PRs.
* Typo
* Further work on instantiation timing.
This moves the instantiation of components to after the FirebaseApp is
completely configured and assigned, as it should be. This also exposed
a recursive issue with IID calling the Messaging singleton, which in
turn called IID and instantiated multiple instances.
A change was made to break the cycle: the Messaging `isAutoInitEnabled`
call was changed to a static method vs an instance method, allowing IID
to call it during initialization without instantiating the Messaging
instance (since it doesn't have a direct dependency on it).
* Revert unintentional formatting of entire FIRMessaging file.
* Fix tests.
* Format InstanceID.m
* Remove unused import.
* Fix ComponentContainer test.
* Minor PR feedback.
* Update versions for Release 6.10.0
* Cherrypick #3983 and include Database in release. (#3986)
* Remove log argument that causes SocketRocket crash (#3983)
* Add FirebaseDatabase to release.
* Update CHANGELOG with version.
* Cherrypick for #3984 along with CHANGELOG update. (#3988)
* Fix race condition in FIRComponentContainer instance creation (#3984)
* Fix race condition in FIRComponentContainer instance creation
Reported in #3967. Users sometimes seeing a crash when multiple threads
concurrently try to create Firestore instances. By inspection I found
that there's a race here where two threads can check for presence in the
cache, see nothing, proceed to creation, both store a value in the cache,
and both return their copies. This would lead to two Firestores being
created for a single App.
This replaces `dispatch_sync` on a serial queue with good old
`@synchronized` blocks. `dispatch_sync` will self-deadlock if called
from a thread already on the queue while `@synchronized` allows
recursion.
No new tests are added because several tests like
`testDependencyDoesntBlock` already cover this case.
* format
* Update Core CHANGELOG
* Update Core CHANGELOG again
* Fix merge from CHANGELOG
* Fix race condition in FIRComponentContainer instance creation
Reported in #3967. Users sometimes seeing a crash when multiple threads
concurrently try to create Firestore instances. By inspection I found
that there's a race here where two threads can check for presence in the
cache, see nothing, proceed to creation, both store a value in the cache,
and both return their copies. This would lead to two Firestores being
created for a single App.
This replaces `dispatch_sync` on a serial queue with good old
`@synchronized` blocks. `dispatch_sync` will self-deadlock if called
from a thread already on the queue while `@synchronized` allows
recursion.
No new tests are added because several tests like
`testDependencyDoesntBlock` already cover this case.
* format
* Update versions for Release 6.9.0
* Fix unbalanced background task creation in GDTCCTUploader (#3838) (#3839)
* Add Manifest
* dependency version update
* Cherry picks for 6.9.0 (#3871)
* fixed "expiclitlySet" typo. (#3853)
* Mark unused variables (#3854)
* Mute FCM deprecated warnings with Xcode 11 and min iOS >= 10 (#3857)
* Add a third slash to make sure generated docs include these comments.b/13812238 (#3846)
* Gate access to cached instances.
This is causing an issue in #3728. Hopefully this will fix it, but no
repro is available yet to test. There's still an underlying race
condition where a `creationBlock` could be called twice for a component
that is supposed to cache the instance returned, but that should be
addressed in a follow up PR.
* Review feedback.
* Add sed scripts that find the versions of podspecs
... without fully loading those via Pod::Spec, which is slow.
* Avoid compiling with different visibility settings
... in different translation units. This removes warnings about linking
googletest causing weak symbols becoming strong.
* Add CMake objc_framework
* Define FirebaseCore via objc_framework
* Define FIRCoreDiagnosticsInterop via objc_framework
* Define GoogleUtilities with objc_framework
* Define FirebaseCoreDiagnosticsInterop via objc_framework
* Define FirebaseAuthInterop via objc_framework
* Don't duplicate Core's dependency information everywhere
* Remove podspec_framework
* Fix compilation error with -Wstrict-prototyes
* FIRApp: send CoreDiagnostics data on appDidBecomeActive.
* ./scripts/style.sh
* Renaming.
* FIRAppTest: stub FIRCoreDiagnosticsConnector to avoid invoking FIRCoreDiagnostics methods in the tests.
* Run ./scripts/style.sh
* Rename to `logCoreTelemetry`
* Implement CoreDiagnostics interop
For use by FirebaseCore.
Please pay special attention to the changes in FIRApp, I've replaced passing FIRApp in the notification with a data object that will eventually replace the same information that FIRDiagnostics extracted.
* Add CoreDiagnosticsInterop to the Example Podfile
* Style and xcodeproj updates
* Update Podfiles that dep on FirebaseCore
So that they also have a dep on FirebaseCoreDiagnosticsInterop
* ran pod deintegrate to remove unintended xcodeproj changes
* Fix Podfile paths
* Add FCD to if_changed and travis.yml
* Fix building with Firestore
* Style
* Whitespace
* Fix a changed internal API
* Make pod paths consistent
* Restore connectivity_monitor_noop.cc style
* Remove logging prior to [FIRApp configure]
Also remove sendLogsWithServiceName:version:
* style
* Remove nil checks from diagnostics data
* Put back some deleted symbols
* Restore the sendLogsWithServiceName:version: method, but as a no-op
* Restore the original version of sendLogs...
* Allow an unused parameter
* Remove obsolete nsnotificationcenter related stuff
* Whoops, missed the header change.
* Final changes to support FIRCoreDiagnostics
These changes are necessary because FIRCore has a hard dep on FIRCoreDiagnostics (FIRCD) and FIRCoreDiagnosticsInterop.
Components can't be used because FIRCD would need to have a hard dep on FIRCore to get access to FIRLibrary, FIRComponent, FIRComponentContainer, and FIRComponentCreationBlock and this would create a dep cycle. So, an extern has been put into the interop lib and the variable is implemented in the connector class inside of FIRCore, but it's unset. FIRCD actually sets that variable in +load, allowing use of FIRCD.
FIRCD can also be removed as a dependency with no ill effect by end users setting the environment variable DISABLE_FIREBASE_DIAGNOSTICS=1
* Add nanopb and project generation infrastructure
* Convert FIRCoreDiagnostics to canonical nanopb, and move to OSS.
* Remove custom build steps for CoreDiagnostics
* Addressing review comments
* Update versions, tags, and port the relevant unit tests for FIRCD
* Version and platform fixes
* Fix podspec expected tags
* A hack to solve a chicken-and-egg problem with pod lib linting.
* Heartbeat implementation
* FIRDiagnosticsDateFileStorageTests
* Fix tests for non-iOS platforms
* Heartbeat tests
* Fix initialization.
* Cleanup Installation ID.
* Fix testProtoPopulation.
* Merge conflict fix
* Typo fix.
* Remove FIRCore dep from FIRCD unit tests and move symbols to interop
* Run ./scripts/style.sh
* Typo
* #ifdef comment
* File license header.
* Import FIRDiagnosticsDateFileStorage.h using relative path.
* FIRDiagnostics -> FIRCoreDiagnostics
* Docs syntax
* Docs
* Docs typo
* Add shared variables to the interop lib
I know this goes against the convention, but it's actually the only way to resolve this very unique problem.
* Fix comment
* Style
* Removed lib version passing.
* Remove env checking for conditional deps
* Style
* Address whitespace issues
* Add copyright notice
* Add new deps to Podfiles
* Fix trailing space
* Some changes to fix working in an extension.
* Fix type in Podfile
* GDT: begin/end background task only for iOS and TVOS applications.
* Fix typo
* Style
* Stop sharing kFIRService strings across pods
* Travis test
* Change all TARGET_OS_TVOS macros to TARGET_OS_TV
TARGET_OS_TVOS doesn't exist.
Also macro out a UIApplication reference.
* style
* Update all Podfiles with deps on FIRCore
* Fix trailing whitespace
* Update Firestore cmake
* Fix FIAM build break (#3254)
* Additional cmake changes
* Fix linker issue with deprecated CoreDiagnostics (#3257)
* Adding more deps to cmake
* Fix linker error (#3266)
* Rerun only IAM tests
* whitespace
* No xcpretty or frameworks run
* Fix typo
* Revert "No xcpretty or frameworks run"
This reverts commit afc1abba37.
* Revert "whitespace"
This reverts commit fd06955a56.
* Revert "Rerun only IAM tests"
This reverts commit 98ce07600f.
* Run travis on this branch
* Add support for expanding PODS_TARGET_SRCROOT in CMake (#3267)
* Fix a few things that should have been splatted but weren't
* Define PODS_TARGET_SRCROOT in CMake for compatibility with CocoaPods
* Compile pods we depend upon with looser settings
* Rename the nanopb dependency to match what CMake actually has
* Make #include <nanopb/pb.h> work
Remove the old way of #include <pb.h> once we change the Firestore
nanopb generator to match.
* Fix warnings that fail the build
* Remove typed enum and fix a comment.
* Fix an import
* Change a line so it's not altered by Copybara
* More changes to stop copybara from altering the wrong sources
* Remove trailing whitespace
* Fix copybara modifying python.
* Add additional field in firebasecore.proto (#3273)
* Remove the dependency on interop to populate a shared variable.
* style
* Create travis jobs for FirebaseCoreDiagnostics (#3245)
* Create travis jobs for FirebaseCoreDiagnostics
And update the pod lib lints for GDT.
Remove the mph-master branch before merging to master.
* Add support for FIRCD to if_changed.sh
* Adjust tests
* Unavailable init methods should not be nullable (#3276)
* Allow firestore api to work with Codable objects + ExplicitNull + Integration tests (#3261)
* Convinience api for codables
* Integration Tests
* ExplicitNull implementation
* Update to CocoaPods 1.7.3 (#3280)
* Import GULLoggerLevel.h via public framework header (#3277)
* Put the need to include Firestore/Source/Public in the podspec (#3288)
This removes the need to munge the pods project after the fact and makes
it so that customers can click through to our headers too.
* Ensure Storage initializer doesn't get called (#3294)
* FIROptions.appGroupID introduced (#3293)
* Use a consistent set of dependencies on all platforms (#3289)
* Use a consistent set of dependencies on all platforms
* pod install for uniform dependencies
* Store the coerced base value in the BaseMutation (#3292)
* In card message: set the text color on the body text view (#3286)
* In card message: set the text color on the body text view
* Fix bug where card messages in test app were showing up with two of the same buttons
* Revert change to text color
* [docs] add missing semicolon (#3305)
Add missing semicolon to code example
* Add explicit Foundation import. (#3309)
This is causing issues when building an XCFramework.
* Pass the correct compiler flag for CoreDiagnostics. (#3312)
* Pass the correct compiler flag for CoreDiagnostics.
When CoreDiagnostics is open sourced, we'll need to ensure that the
right compiler flag is passed. This doesn't add support for Carthage yet
but allows the frameworkbuilder to pass the flag for carthage as well.
An update to the zipbuilder to allow for carthage will follow shortly.
* Remove accidental change.
* Fix and rewrite sync_project.rb (#3296)
* Fix and rewrite sync_project.rb
Ever since we added multiple platforms, removing a file has been broken.
This fixes that issue.
Also, rewrite target synchronization to make more sense. Essentially now
there's one diff between the filesystem and the groups and then an
explicit diff is done between project files and target contents.
* Run sync_project.rb on post-install
* pod lib linting should output something every minute while running
* DEBUG: This commit should be reverted
* DEBUG: This commit should be reverted
* DEBUG: This commit should be reverted
* Remove mph-master from travis
* Fix constant name conflic between old and new diagnostics (#3329)
* Rename kFIRDiagnosticsHeartbeatDateFileName -> kFIRCoreDiagnosticsHeartbeatDateFileName to avoid conflicts with FIRDiagnostics.
* Travis: temporary add `mph-master` to run tests.
* Rempve mph-master again
* Fix imports in FIRCDConnector
* Fix another import
* Fix yet another import
* Attempt to read crashing test logs from disk
* Implement printing of failed/crashed test logs.
* Print only crashed tests, rmdir between runs
* Revert reading crashing log changes
* Write CHANGELOG for all new FIRCD associated libraries
* Change all GUL deps to >= 6.2
* Revert ZipBuilder changes and do some last bits of cleanup
* Remove an assertion and populate an error instead
* Remove FIRAnalyticsConfiguration from Public header.
We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.
* Fixed incomplete comment.
* Remove self importing header.
* Moving FIRAnalyticsConfiguration calls to Analytics.
These APIS are specific to the Analytics SDK and have been moved there.
The instance methods have become static methods on the `FIRAnalytics`
class.
* Ignore more clang warnings.
* Added more context in the changelog.
* Updated CHANGELOG.
* Step 1: Duplicate ASL Logger
This copies over the ASL logging system to a standalone Objective-C class.
* Step 2: Replace Logger with ObjC Implementation
This also moved the `forcedDebug` information to a property.
* Step 3: Remove unnecessary test methods
It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary.
* Style Fixes
* Test cleanup
* Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now.
* Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`.
* Use dot-notation for the defaultLogger class property.
* Removed unused debug only test methods.
* Rename FIRLoggerInitializeASL
* Style fixes
* ASL Logger cleanup and leaking
* Move ivar synthesis to the top of the implementation.
* Add dealloc logic to avoid leaking asl_obj memory.
* Add forced logic at the message level.
* GULLogger Testing
* Moved over old tests to correct ASLLogger location.
* Added new GULLogger tests
* Changed version `char *` to `NSString *`
* Tidied up some documentation
* Re-introduce ASL in the functions names
* os_log GULLogger Implementation
* Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods.
* Added `os_log` implementation of `GULLoggerSystem`
* Added `os_log` level information to `GULLoggerLevel`
* Removed unused test variable
TODO: Tests
* Remove iOS version check from ASLLogger
* Style Fixes
* Refer to ivar directly in property setter
* Refer to ivar directly in property setter
* Being os_log tests
* Setup dependency injection for os_log tests
* Rename C functions according to style and correctly test macOS version compatibility
* Further refinement of os_log testing
* Add Some OSLogger tests and update some ASLLogger ones
* Re-add getter for logLevel
* Fix up some warnings
* Remove private headers from local testing podspec
* More OSLogger tests & bug fixes
* Style Fixes
* Fix Travis build
* Update GULOSLoggerTest.m
* Do nt override method argument
* Fix test on tvOS
* Test Fixes
* Copybara test fixes
* PR Feedback
* Update versions for Release 5.17.0
* Fix the tag in the FIAM podspec.
* Update dependencies for FIAM.
* Updated the FirebaseCore version.
* Fix FIROptions version.
* Temporarily remove FIAM version deps for pod linting.
* Create umbrella header for FIAM (#2392)
This causes an issue when building the zip file - similar to #1857
* Remove FIAM from 5.17.0 release.
Ryan Wilson