Commit Graph
32 Commits
Author SHA1 Message Date
Paul Beusterien 2815f14985 Restore kFIRLoggerCrash for internal clients (#2809) 2019-04-11 10:47:43 -07:00
Paul Beusterien fd6f93d89d Begin migrating FIRLoggerService declarations to clients (#2720) 2019-04-08 08:54:21 -07:00
Paul Beusterien 1a32a1f7d3 Delete references to deprecated Crash and Invites (#2668) 2019-04-01 19:06:05 -07:00
Paul Beusterien 9502e8dda1 Restore GoogleUtilities 5.3.7 - revert os_log changes (#2556) 2019-03-14 13:01:41 -07:00
Paul Beusterien d100e02496 Restore GULLogger APIs, unit tests, and contents (#2504) 2019-03-11 08:59:12 -07:00
Benoit St-Pierre 6b026aac76 os_log Implementation of GULLogger (#2374)
* Step 1: Duplicate ASL Logger

This copies over the ASL logging system to a standalone Objective-C class.

* Step 2: Replace Logger with ObjC Implementation

This also moved the `forcedDebug` information to a property.

* Step 3: Remove unnecessary test methods

It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary.

* Style Fixes

* Test cleanup

* Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now.
* Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`.
* Use dot-notation for the defaultLogger class property.
* Removed unused debug only test methods.

* Rename FIRLoggerInitializeASL

* Style fixes

* ASL Logger cleanup and leaking

* Move ivar synthesis to the top of the implementation.
* Add dealloc logic to avoid leaking asl_obj memory.
* Add forced logic at the message level.

* GULLogger Testing

* Moved over old tests to correct ASLLogger location.
* Added new GULLogger tests
* Changed version `char *` to `NSString *`
* Tidied up some documentation

* Re-introduce ASL in the functions names

* os_log GULLogger Implementation

* Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods.
* Added `os_log` implementation of `GULLoggerSystem`
* Added `os_log` level information to `GULLoggerLevel`
* Removed unused test variable

TODO: Tests

* Remove iOS version check from ASLLogger

* Style Fixes

* Refer to ivar directly in property setter

* Refer to ivar directly in property setter

* Being os_log tests

* Setup dependency injection for os_log tests

* Rename C functions according to style and correctly test macOS version compatibility

* Further refinement of os_log testing

* Add Some OSLogger tests and update some ASLLogger ones

* Re-add getter for logLevel

* Fix up some warnings

* Remove private headers from local testing podspec

* More OSLogger tests & bug fixes

* Style Fixes

* Fix Travis build

* Update GULOSLoggerTest.m

* Do nt override method argument

* Fix test on tvOS

* Test Fixes

* Copybara test fixes

* PR Feedback
2019-02-22 16:32:57 -05:00
Paul Beusterien 9a2aa9fbcc Fix FIRLogger initialization after GULLogger (#1592)
* Migrate of kFIRPersistedDebugModeKey
2018-07-26 09:45:44 -07:00
Paul Beusterien 98b6eef71e Split GoogleUtilities from FirebaseCore (#1370) 2018-07-06 09:37:23 -07:00
Ryan Wilson 8d399c78bd Better mocking for Core Unit Tests (#1467)
* Better mocking for Core Unit Tests

This includes NSNotificationCenter and NSUserDefaults to prevent
flaky tests and unit tests interfering with each other.

* Share variable for intervals being set.
2018-06-27 06:42:09 -07:00
Ryan Wilson 5de20858e4 Remove unused static logging variable. (#1405)
* Remove unused static variable.

This was previously used in an iOS 7 comparison that was removed in
Firebase version 5.0.0.

* Remove unused test variable.
2018-06-13 07:56:28 -07:00
Paul Beusterien f7c053e004 Disable sanitizer race condition error (#1390) 2018-06-08 13:50:50 -07:00
Ryan Wilson af4bf66cfe Add MLKit to FIRLogger constants. (#1263) 2018-05-11 11:28:30 -07:00
Paul Beusterien a9909ebc90 Eliminate duplicate symbol in CocoaPods -all_load build (#1223) 2018-05-03 16:35:33 -07:00
Ryan Wilson 421cd3c248 Remove logging count for this release. (#1201) 2018-05-01 06:42:57 -07:00
Ryan Wilson ab208ba50f Remove iOS 7 Simulator check from FIRLogger. (#1196)
This isn't needed anymore due to the minimum required version being bumped to iOS 8.
2018-04-30 14:24:49 -04:00
Ryan Wilson 260557691f Add counter for errors and warnings logged. (#1168)
* Moved writes outside of dispatch_async block.
2018-04-25 06:45:36 -07:00
Paul Beusterien 7ae48c7d2e Disable asl deprecation warnings (#1100) 2018-04-15 17:16:33 -07:00
Paul Beusterien 54fe9ba7fc Add Logger Service for Swizzler (#1002) 2018-03-29 16:44:46 -07:00
Paul Beusterien ed671eee8c Update Core style (#641) 2018-01-10 14:44:32 -08:00
Paul Beusterien c4dcfaa49e Add Private path to FIRVersion.h import (#607) 2018-01-02 15:15:16 -08:00
Greg Soltis 412e759a19 Expose library version, move it out of options (#588)
* slight cleanup

* Use -D defines for versions

* Undo FIROptionsTest change

* Drop failed macro attempt

* Add correct version to podspec

* Add newline

* Shuffle files around

* Bring back log change

* Fix change

* Fix space
2018-01-01 17:43:54 -08:00
Gil f851af5323 Run FIRSetLoggerLevel and FIRIsLoggableLevel on the same thread (#592)
This fixes a race condition where a caller calls FIRSetLoggerLevel and
then checks FIRIsLoggableLevel immediately after.
2017-12-22 15:09:20 -08:00
Ryan Wilson 2ea4225ed5 Add argument for forcing STDERR output in FIRLogger. (#430) 2017-11-08 10:25:23 -05:00
Gil bde743ed25 Release 4.3.0 (#327)
Initial release of Firestore at 0.8.0
Bump FirebaseCommunity to 0.1.3
2017-10-03 08:55:22 -07:00
Sebastian Schmidt dc36b0a5d7 Clang-formatting FIRLogger (#312) 2017-09-25 15:09:16 -07:00
Ryan Wilson b79950072d Remove duplicate logging issue. (#279)
Some combinations of iOS version, simulator/device, and Xcode version
result in duplicate logs. This should remove duplicate logs while
ensuring that all Firebase related logs are still shown.
2017-09-15 16:59:56 -07:00
Paul Beusterien 187c762137 Enable FIRLogger to be weakly linked (#244) 2017-09-10 11:47:23 -07:00
Marek Gilbert 360f7bed25 Result of clang-format with AllowShortFunctionsOnASingleLine: None 2017-08-02 11:07:57 -07:00
Paul Beusterien 0abd344434 Add clang-format options and script; apply to FirebaseCore (#151) 2017-07-27 11:02:39 -07:00
davidair f7fc2bb573 Moving sMessageCodeRegex initialization into #ifdef DEBUG to remove the init cost, adding [FIRApp configure] to the Core example (#150) 2017-07-25 11:28:17 -04:00
Paul Beusterien f5cabf4feb Move FIRAppEnvironmentUtil.m to third_party directory (#89) 2017-06-20 13:32:03 -07:00
Paul Beusterien 98ba64449a Initial 2017-05-15 12:27:07 -07:00