Commit Graph
13 Commits
Author SHA1 Message Date
Paul Beusterien eb413b3ba4 Delete unused commented asl tests (#3981) 2019-10-03 08:38:32 -07:00
Maksym Malyhin b2cd981f23 Revert "GULLogger - count errors and warnigns" (#2714)
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0bfb.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6161.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55afd.
2019-04-03 15:05:07 -04:00
Maksym Malyhin 961e9b0bfb GULLogger: logged issue counting concurrency issue fix (#2627) 2019-03-26 14:54:43 -04:00
Maksym Malyhin c6da7d6161 GULLogger - issue count synchronous getters (#2610) 2019-03-22 14:50:15 -04:00
Maksym Malyhin 1e08a55afd GULLogger - count errors and warnigns (#2601) 2019-03-21 13:33:14 -04:00
Paul Beusterien 9502e8dda1 Restore GoogleUtilities 5.3.7 - revert os_log changes (#2556) 2019-03-14 13:01:41 -07:00
Paul Beusterien 8c16157508 Remove unused loggerWithLevel parameter (#2524) 2019-03-12 11:33:49 -07:00
Paul Beusterien d100e02496 Restore GULLogger APIs, unit tests, and contents (#2504) 2019-03-11 08:59:12 -07:00
Benoit St-Pierre 6364b34d7f Resolve issue with char * casting in format string invocation (#2454)
* Use `-[NSString initWithFormat:arguments:]` instead of trying to trick the preprocessor macros of all the platforms.
* A couple drive-by warning fixes that `-Weverything` surfaced.
2019-02-27 16:09:41 -05:00
Paul Beusterien 7140078e50 Fix GULLogger file structure (#2437) 2019-02-25 07:05:57 -08:00
Benoit St-Pierre 6b026aac76 os_log Implementation of GULLogger (#2374)
* Step 1: Duplicate ASL Logger

This copies over the ASL logging system to a standalone Objective-C class.

* Step 2: Replace Logger with ObjC Implementation

This also moved the `forcedDebug` information to a property.

* Step 3: Remove unnecessary test methods

It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary.

* Style Fixes

* Test cleanup

* Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now.
* Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`.
* Use dot-notation for the defaultLogger class property.
* Removed unused debug only test methods.

* Rename FIRLoggerInitializeASL

* Style fixes

* ASL Logger cleanup and leaking

* Move ivar synthesis to the top of the implementation.
* Add dealloc logic to avoid leaking asl_obj memory.
* Add forced logic at the message level.

* GULLogger Testing

* Moved over old tests to correct ASLLogger location.
* Added new GULLogger tests
* Changed version `char *` to `NSString *`
* Tidied up some documentation

* Re-introduce ASL in the functions names

* os_log GULLogger Implementation

* Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods.
* Added `os_log` implementation of `GULLoggerSystem`
* Added `os_log` level information to `GULLoggerLevel`
* Removed unused test variable

TODO: Tests

* Remove iOS version check from ASLLogger

* Style Fixes

* Refer to ivar directly in property setter

* Refer to ivar directly in property setter

* Being os_log tests

* Setup dependency injection for os_log tests

* Rename C functions according to style and correctly test macOS version compatibility

* Further refinement of os_log testing

* Add Some OSLogger tests and update some ASLLogger ones

* Re-add getter for logLevel

* Fix up some warnings

* Remove private headers from local testing podspec

* More OSLogger tests & bug fixes

* Style Fixes

* Fix Travis build

* Update GULOSLoggerTest.m

* Do nt override method argument

* Fix test on tvOS

* Test Fixes

* Copybara test fixes

* PR Feedback
2019-02-22 16:32:57 -05:00
Paul Beusterien 9a2aa9fbcc Fix FIRLogger initialization after GULLogger (#1592)
* Migrate of kFIRPersistedDebugModeKey
2018-07-26 09:45:44 -07:00
Paul Beusterien c586dc8747 Separate Xcode project and tests for GoogleUtilities (#1521) 2018-07-12 12:03:50 -07:00