Commit Graph
23 Commits
Author SHA1 Message Date
Paul Beusterien fd6f93d89d Begin migrating FIRLoggerService declarations to clients (#2720) 2019-04-08 08:54:21 -07:00
Paul Beusterien 1a32a1f7d3 Delete references to deprecated Crash and Invites (#2668) 2019-04-01 19:06:05 -07:00
Paul Beusterien 9502e8dda1 Restore GoogleUtilities 5.3.7 - revert os_log changes (#2556) 2019-03-14 13:01:41 -07:00
Benoit St-Pierre 6b026aac76 os_log Implementation of GULLogger (#2374)
* Step 1: Duplicate ASL Logger

This copies over the ASL logging system to a standalone Objective-C class.

* Step 2: Replace Logger with ObjC Implementation

This also moved the `forcedDebug` information to a property.

* Step 3: Remove unnecessary test methods

It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary.

* Style Fixes

* Test cleanup

* Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now.
* Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`.
* Use dot-notation for the defaultLogger class property.
* Removed unused debug only test methods.

* Rename FIRLoggerInitializeASL

* Style fixes

* ASL Logger cleanup and leaking

* Move ivar synthesis to the top of the implementation.
* Add dealloc logic to avoid leaking asl_obj memory.
* Add forced logic at the message level.

* GULLogger Testing

* Moved over old tests to correct ASLLogger location.
* Added new GULLogger tests
* Changed version `char *` to `NSString *`
* Tidied up some documentation

* Re-introduce ASL in the functions names

* os_log GULLogger Implementation

* Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods.
* Added `os_log` implementation of `GULLoggerSystem`
* Added `os_log` level information to `GULLoggerLevel`
* Removed unused test variable

TODO: Tests

* Remove iOS version check from ASLLogger

* Style Fixes

* Refer to ivar directly in property setter

* Refer to ivar directly in property setter

* Being os_log tests

* Setup dependency injection for os_log tests

* Rename C functions according to style and correctly test macOS version compatibility

* Further refinement of os_log testing

* Add Some OSLogger tests and update some ASLLogger ones

* Re-add getter for logLevel

* Fix up some warnings

* Remove private headers from local testing podspec

* More OSLogger tests & bug fixes

* Style Fixes

* Fix Travis build

* Update GULOSLoggerTest.m

* Do nt override method argument

* Fix test on tvOS

* Test Fixes

* Copybara test fixes

* PR Feedback
2019-02-22 16:32:57 -05:00
Paul Beusterien 9a2aa9fbcc Fix FIRLogger initialization after GULLogger (#1592)
* Migrate of kFIRPersistedDebugModeKey
2018-07-26 09:45:44 -07:00
Paul Beusterien 98b6eef71e Split GoogleUtilities from FirebaseCore (#1370) 2018-07-06 09:37:23 -07:00
Ryan Wilson 8d399c78bd Better mocking for Core Unit Tests (#1467)
* Better mocking for Core Unit Tests

This includes NSNotificationCenter and NSUserDefaults to prevent
flaky tests and unit tests interfering with each other.

* Share variable for intervals being set.
2018-06-27 06:42:09 -07:00
Ryan Wilson 5de20858e4 Remove unused static logging variable. (#1405)
* Remove unused static variable.

This was previously used in an iOS 7 comparison that was removed in
Firebase version 5.0.0.

* Remove unused test variable.
2018-06-13 07:56:28 -07:00
Ryan Wilson af4bf66cfe Add MLKit to FIRLogger constants. (#1263) 2018-05-11 11:28:30 -07:00
Ryan Wilson 421cd3c248 Remove logging count for this release. (#1201) 2018-05-01 06:42:57 -07:00
Ryan Wilson 260557691f Add counter for errors and warnings logged. (#1168)
* Moved writes outside of dispatch_async block.
2018-04-25 06:45:36 -07:00
Paul Beusterien 10105d83c9 Enable Core Unit Tests to run in a Release config (#1064) 2018-04-10 09:00:38 -07:00
Paul Beusterien 6a6e14822f Fix build warnings by making void parameter explicit (#681) 2018-01-19 07:45:31 -08:00
Sebastian Schmidt 03ab86499f Running scripts/style.sh 2017-12-10 22:58:23 -08:00
Paul Beusterien 3418244cd5 Disable FirebaseCore Test deprecation warnings (#545) 2017-12-08 07:31:31 -08:00
Paul Beusterien 73869c741f Fix warnings in FirebaseCore Unit Tests (#544) 2017-12-07 14:30:46 -08:00
Paul Beusterien da9308408d Use brackets for module imports (#487) 2017-11-22 09:19:10 -08:00
Paul Beusterien 3e592526ec Buildable and interoperable source pods (#444) 2017-11-21 17:02:22 -08:00
Paul Beusterien 0abd344434 Add clang-format options and script; apply to FirebaseCore (#151) 2017-07-27 11:02:39 -07:00
Paul Beusterien 053b2f11ea Use modulemap to fix exposure of FirebaseCore's internal headers (#121) 2017-07-10 14:57:03 -07:00
davidair bf5ef4be6d Removing a backspace character (#132) 2017-07-10 15:09:09 -04:00
Paul Beusterien 9792bec7e3 Disable failing FIRLogger test until Issue 128 is fixed (#129) 2017-07-10 08:51:26 -07:00
Paul Beusterien 98ba64449a Initial 2017-05-15 12:27:07 -07:00