Commit Graph
30 Commits
Author SHA1 Message Date
Paul Beusterien f2bcd5d82b Make all GoogleUtilities APIs public (#6588) 2020-09-29 07:26:10 -07:00
Paul Beusterien febada4e02 Reset debug mode on GGULResetLogger (#6195) 2020-08-03 14:51:15 -07:00
Paul Beusterien 3f556ddb9e Update GoogleUtilities' clients with repo-relative imports (#5824) 2020-06-16 09:05:29 -07:00
Paul Beusterien 4c418e7fc3 GoogleUtilities repo-relative imports (#5810) 2020-06-16 06:19:00 -07:00
Paul Beusterien 0dd8dda165 GoogleUtilities - Standardize imports and add LICENSE (#4655) 2020-01-10 14:14:41 -08:00
Ryan Wilson 563854e81e Copy component container to GoogleUtilitiesComponents (#4113)
* Move component container to GoogleUtilities.

This will allow non-Firebase SDKs to take advantage of the component
system. Note: Firebase Core will eventually move over to use this, but
more investigation is needed about how this can be done with the least
amount of churn for other SDKs.

* Fix dependency on Logger.

* Add CHANGELOG entry.

* Fix selector name.

* Move ComponentContainer subspec to new pod.

* Rename to GoogleUtilitiesComponents.

* Style, make public headers.

* Update travis with new name.

* Add project to if_changed.sh

* Review comments.

* Enabled static framework, changed homepage.

* Fix missing quote.
2019-10-25 14:05:29 -04:00
Ryan Wilson 09f3f6c6a3 Fix unit testing crash with localization on (#3933) 2019-10-01 11:28:42 -07:00
Ryan Wilson 080397209e Add explicit Foundation import. (#3309)
This is causing issues when building an XCFramework.
2019-07-05 15:56:42 -04:00
Sebastian Roth c296efb9ec Import GULLoggerLevel.h via public framework header (#3277) 2019-07-01 07:03:22 -07:00
Paul Beusterien e8e91c619b Fix Xcode 11 build warning (#3133) 2019-06-03 15:28:44 -07:00
Maksym Malyhin b2cd981f23 Revert "GULLogger - count errors and warnigns" (#2714)
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0bfb.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6161.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55afd.
2019-04-03 15:05:07 -04:00
Maksym Malyhin 961e9b0bfb GULLogger: logged issue counting concurrency issue fix (#2627) 2019-03-26 14:54:43 -04:00
Maksym Malyhin c6da7d6161 GULLogger - issue count synchronous getters (#2610) 2019-03-22 14:50:15 -04:00
Maksym Malyhin 1e08a55afd GULLogger - count errors and warnigns (#2601) 2019-03-21 13:33:14 -04:00
Paul Beusterien 9502e8dda1 Restore GoogleUtilities 5.3.7 - revert os_log changes (#2556) 2019-03-14 13:01:41 -07:00
Paul Beusterien e524a8dc99 Fix GULResetLogger API breakage (#2552)
* Fix GULResetLogger API breakage

* podspec and CHANGELOG

* typo
2019-03-14 07:47:40 -04:00
Paul Beusterien 8c16157508 Remove unused loggerWithLevel parameter (#2524) 2019-03-12 11:33:49 -07:00
Ryan Wilson dc31021a98 Only assign message validation regex once (#2523)
* Only assign regex helper once.

This fixes an internal error (b/128359839) that causes tests to crash.

* Re-add unused param.
2019-03-12 10:54:12 -04:00
Paul Beusterien d100e02496 Restore GULLogger APIs, unit tests, and contents (#2504) 2019-03-11 08:59:12 -07:00
Benoit St-Pierre 6364b34d7f Resolve issue with char * casting in format string invocation (#2454)
* Use `-[NSString initWithFormat:arguments:]` instead of trying to trick the preprocessor macros of all the platforms.
* A couple drive-by warning fixes that `-Weverything` surfaced.
2019-02-27 16:09:41 -05:00
Ryan Wilson 71605264e4 Fix logger warning on iOS 7. (#2453) 2019-02-27 11:24:50 -05:00
Paul Beusterien 7140078e50 Fix GULLogger file structure (#2437) 2019-02-25 07:05:57 -08:00
Paul Beusterien f76ae211e9 Fix GoogleUtilities regression for Firestore builds 2 (#2433)
* Run Firestore builds/tests on GoogleUtilities changes
* Silence macOS 10.10 warnings
* Add cast to fix Firestore macOS builds
2019-02-22 20:07:47 -08:00
Paul Beusterien 9c41c874cc Fix GoogleUtilities regression for Firestore builds (#2431) 2019-02-22 15:57:26 -08:00
Benoit St-Pierre 6b026aac76 os_log Implementation of GULLogger (#2374)
* Step 1: Duplicate ASL Logger

This copies over the ASL logging system to a standalone Objective-C class.

* Step 2: Replace Logger with ObjC Implementation

This also moved the `forcedDebug` information to a property.

* Step 3: Remove unnecessary test methods

It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary.

* Style Fixes

* Test cleanup

* Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now.
* Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`.
* Use dot-notation for the defaultLogger class property.
* Removed unused debug only test methods.

* Rename FIRLoggerInitializeASL

* Style fixes

* ASL Logger cleanup and leaking

* Move ivar synthesis to the top of the implementation.
* Add dealloc logic to avoid leaking asl_obj memory.
* Add forced logic at the message level.

* GULLogger Testing

* Moved over old tests to correct ASLLogger location.
* Added new GULLogger tests
* Changed version `char *` to `NSString *`
* Tidied up some documentation

* Re-introduce ASL in the functions names

* os_log GULLogger Implementation

* Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods.
* Added `os_log` implementation of `GULLoggerSystem`
* Added `os_log` level information to `GULLoggerLevel`
* Removed unused test variable

TODO: Tests

* Remove iOS version check from ASLLogger

* Style Fixes

* Refer to ivar directly in property setter

* Refer to ivar directly in property setter

* Being os_log tests

* Setup dependency injection for os_log tests

* Rename C functions according to style and correctly test macOS version compatibility

* Further refinement of os_log testing

* Add Some OSLogger tests and update some ASLLogger ones

* Re-add getter for logLevel

* Fix up some warnings

* Remove private headers from local testing podspec

* More OSLogger tests & bug fixes

* Style Fixes

* Fix Travis build

* Update GULOSLoggerTest.m

* Do nt override method argument

* Fix test on tvOS

* Test Fixes

* Copybara test fixes

* PR Feedback
2019-02-22 16:32:57 -05:00
Paul Beusterien 7c53489e03 Travis to Xcode 10.1 and clang-format to 8.0.0 (tags/google/stable/2018-08-24) (#2222)
* Travis to Xcode 10.1
* Update to clang-format 8
* Update clang-format homebrew link
* Work around space in filename style.sh issue
2019-01-02 09:27:31 -08:00
Konstantin Varlamov 1eed3ee483 GULLogger: ignore a data race (#1959)
Thread sanitizer spots a data race in `GULSetLoggerLevel`. Following #1390, annotate the function so that TSan will ignore it.
2018-10-17 12:51:27 -04:00
Corrob 54471e8081 Fix GULLoggerEnableSTDERR by using STDERR_FILENO (#1595) 2018-07-26 17:45:40 -07:00
Paul Beusterien 9a2aa9fbcc Fix FIRLogger initialization after GULLogger (#1592)
* Migrate of kFIRPersistedDebugModeKey
2018-07-26 09:45:44 -07:00
Paul Beusterien c6b4b03fff Move GoogleUtilities out of Firebase directory (#1516) 2018-07-11 08:28:35 -07:00