Commit Graph
118 Commits
Author SHA1 Message Date
Zsika Phillip 60fa69332e Internal code clean up (#584)
Fixes indentation and removes unused imports.
2017-12-19 15:25:15 -08:00
Kyle Ju c7f8d7f8da Merge pull request #576 from firebase/release-4.8.0
Release 4.8.0
2017-12-19 11:08:58 -05:00
Zsika Phillip 683985168e Add nil check for completion handlers (#568)
* Add nullability check for completion handler

* Addresses comments

* added line break
2017-12-14 16:20:35 -08:00
Kyle Ju e16c38688b Update component versions for Firebase 4.8.0 (#561) 2017-12-12 17:24:19 -05:00
Sebastian Schmidt 03ab86499f Running scripts/style.sh 2017-12-10 22:58:23 -08:00
Paul Beusterien 31917f566c Double auth unit test timeout to address travis flakiness (#548) 2017-12-08 11:27:49 -08:00
Paul Beusterien 3418244cd5 Disable FirebaseCore Test deprecation warnings (#545) 2017-12-08 07:31:31 -08:00
Paul Beusterien 73869c741f Fix warnings in FirebaseCore Unit Tests (#544) 2017-12-07 14:30:46 -08:00
Zsika Phillip f502f42e26 Fixes stating host (#528) 2017-12-04 17:28:35 -08:00
Paul Beusterien ed3e4982f9 Standardize cross module imports with angle bracket syntax (#526)
Qualify all cross-pod imports of FirebaseCore headers
2017-12-04 08:52:11 -08:00
Paul Beusterien 9c08142051 Add post_install workaround to enable internal component access to Analytics (#525) 2017-12-02 07:02:54 -08:00
Paul Beusterien 03b45533db Add Analytics test target and build tests for deprecated headers (#520) 2017-12-01 15:08:29 -08:00
Paul Beusterien 4ecc8ad0c1 Core is now 4.7.0 2017-12-01 08:05:11 -08:00
Zsika Phillip 771b0f7a65 Adds Auth Result to Sign In with Custom token (#489)
* Adds Auth Result to Sign In with Custom token

* Addresses comomments
2017-11-27 14:17:05 -08:00
Paul Beusterien da9308408d Use brackets for module imports (#487) 2017-11-22 09:19:10 -08:00
Zsika Phillip bc2d78439a Adds AuthDataResult to signInWithEmailPassword Method (#484)
* Adds AuthDataResult to signInWithEmail:Password

* Addresses comments

* Addresses comments

* addresses more comments

* Fixes broken tests
2017-11-22 08:57:07 -08:00
Paul Beusterien 3e592526ec Buildable and interoperable source pods (#444) 2017-11-21 17:02:22 -08:00
Zsika Phillip 54aef651d8 Add Auth Result to createUserWithEmail (#477) 2017-11-20 15:56:03 -08:00
Zsika Phillip 5fbe71052d Adds AuthDataResult to anonymous sign in (#470)
* Adds AuthDataResult to anonymous sign in

* Fixes typo

* Addresses comments

* addresses comment on PR
2017-11-17 15:55:56 -08:00
Zsika Phillip 88b7e74e31 removes unused label from sample app (#468) 2017-11-16 15:27:02 -08:00
Sebastian Schmidt b757a21418 Adding the md5 hash to FIRStorageMetadata 2017-11-09 17:51:31 -08:00
Sebastian Schmidt 110f0edf9d Clang-formatting Storage 2017-11-09 17:51:21 -08:00
Zsika Phillip d0c65d8fc4 Fixes code style (#428) 2017-11-06 10:30:05 -08:00
Paul Beusterien cfd8118355 Update messaging test for upcoming InstanceID changes (#425) 2017-11-03 12:28:03 -07:00
Zsika Phillip 390d600b53 Improve swift sample app (#409)
* Updates the sign-in methods on Swift Sample

Updates the sign-in, reauth and link with credential methods on Swift Sample to use the recommended Auth result paradigm.

* adds missing space after {

* addresses comments
2017-10-25 16:49:59 -07:00
Ivan 13d59e3067 handles unstructured errors on redirect URLs 2017-10-23 13:46:46 -07:00
Ivan 4cf46e4123 Merge branch 'master' of https://github.com/firebase/firebase-ios-sdk into fix-reason-parameter 2017-10-23 11:39:10 -07:00
Ivan 9f6f969334 handles unstructured errors on redirect URLs 2017-10-23 11:38:29 -07:00
Paul Beusterien a9dc2f4c42 Add images and icons to silence Xcode 9 warnings (#396) 2017-10-20 16:42:25 -07:00
Xiangtian Dai a9585971c3 Silences unguarded availability warnings in Auth. (#389)
Also fixes a crash in the Auth sample app in an error case.

This addresses *Auth* part of #385 .
2017-10-19 08:58:36 -07:00
Ivan bb681a0c8e Merge pull request #376 from firebase/automate-phonenumber-signin
Adds automated test for manual phone sign-in.
2017-10-16 17:15:40 -07:00
Ivan cd112a82cd Adds automated test for manual phone sign-in 2017-10-16 17:10:08 -07:00
Ivan ed4b9d4387 Adds automated test for manual phone sign-in 2017-10-16 16:58:53 -07:00
Ivan d8bcaf0f96 Adds automated test for manual phone sign-in 2017-10-16 15:07:13 -07:00
Ivan 26435988ce Adds automated test for manual phone sign-in 2017-10-13 15:16:25 -07:00
Riz 2b40693be4 Add simpler delegate method for FCM tokens (#375)
This new delegate method will be called generally once per app start, to always provide a current token. This token may change over time. This simpler method makes integration much simpler, as:

* Developers no longer have to check for a current token using the `.fcmToken` property, and also check for token changes using the `-messaging:didRefreshRegistrationToken:` delegate method.
* There is a single code path for when a token is available, making operations that depend on a token being available easier to implement. For example, this is the right method to always upload your FCM token to your application server, or to subscribe to topics, etc.
2017-10-12 16:09:07 -07:00
Ivan 41cc6ed1a5 new user popup toggle 2017-10-10 11:24:40 -07:00
Ivan 236a8e0424 new user popup toggle 2017-10-10 10:32:15 -07:00
Xiangtian Dai 532f538ee6 Prepare to release FirebaseAuth 4.3.0 (#345)
* Update Auth version to 4.3.0

* Revert "Removes user meta from public API (#308)"

This reverts commit 1602391bf8.

* Revert "Removes metadata from swift sample (#318)"

This reverts commit 804ff523a2.
2017-10-09 16:20:17 -07:00
Ivan 13b88a84f2 Add new user popup to sample app 2017-10-06 14:10:04 -07:00
Ivan e2df1923d2 Add new user popup to sample app 2017-10-06 11:59:53 -07:00
Ivan 71ecdf98c7 Adds new user popup to sample app. 2017-10-06 09:58:25 -07:00
Riz 5496eff88f Don't swizzle missing and optional delegate methods
FCM's swizzling of the user notification center currently swizzles only one of the two optional delegate methods (userNotificationCenter:willPresentNotification:withCompletionHandler:), but not the other (userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:).

The didReceiveNotificationResponse, if implemented by the delegate, is the sole receiver of all user action on a notification, including simply tapping on the notification itself. Prior to this change, if the developer had implemented didReceiveNotificationResponse, then FCM would not be able to collect this event for analytics.

Additionally, I changed the logic in FIRMessagingRemoteNotificationsProxy to check whether these methods are actually implemented before swizzling them. It was always swizzling, which meant it was adding an implementation if the method didn't exist. This would confuse iOS into thinking the developer did implement these methods and NOT fall back to delivering the notifications to the application delegate.

With this change, if the developer did not implement these methods, then FCM will not swizzle those methods. That keeps the behavior true to what the developer intended.
2017-10-04 18:39:30 -07:00
Xiangtian Dai 4b1b3d62d8 Simplifies logic to post auth state change notifications, which is also applied more consistently now. (#325) 2017-10-03 09:58:47 -07:00
Xiangtian Dai bf550507ff Automatically signs user out if the token is no longer valid. (#323) 2017-10-02 14:15:05 -07:00
Zsika Phillip 7fa0b0de42 Disambiguates known errors from web context (#322)
* Disambiguates known errors from web context
 - Disambiguates known errors possibly returned by verifyPhoneNumber:UIDelegate:completion:
2017-10-02 11:21:55 -07:00
Zsika Phillip aebb293f3d Add operation phone auth (#309)
* Adds operation to verify PhoneNumber requests

* Improvements and unit tests

* Fixes typo

* Addresses comments

- Removes the FIRAuthOperation class.
- Defines the FIRAuthOperationType as an enum in a class of the same name.
- Passes the FIRAuthOperationType value down to the verifyPhoneNumber RPC where it is translated to a string.

* Fixes unit tests

* Actually fixes the unit tests.
2017-09-27 00:16:33 -07:00
Zsika Phillip 804ff523a2 Removes metadata from swift sample (#318)
Removes metadata from swift sample until it is made public again.
2017-09-26 18:44:20 -07:00
Paul Beusterien 05108693ee Remove Stubs.swift from Auth_Example build target (#317) 2017-09-26 14:54:54 -07:00
Xiangtian Dai 06fbbd8ee0 - Saves user metadata in keychain. (#305)
- Adds Swift stubs for the new API.
- Shows the `isNewUser` bit in the sample app.
2017-09-26 13:17:41 -07:00