Commit Graph
70 Commits
Author SHA1 Message Date
Zsika Phillip 60fa69332e Internal code clean up (#584)
Fixes indentation and removes unused imports.
2017-12-19 15:25:15 -08:00
Zsika Phillip 683985168e Add nil check for completion handlers (#568)
* Add nullability check for completion handler

* Addresses comments

* added line break
2017-12-14 16:20:35 -08:00
Paul Beusterien 31917f566c Double auth unit test timeout to address travis flakiness (#548) 2017-12-08 11:27:49 -08:00
Zsika Phillip f502f42e26 Fixes stating host (#528) 2017-12-04 17:28:35 -08:00
Paul Beusterien ed3e4982f9 Standardize cross module imports with angle bracket syntax (#526)
Qualify all cross-pod imports of FirebaseCore headers
2017-12-04 08:52:11 -08:00
Zsika Phillip 771b0f7a65 Adds Auth Result to Sign In with Custom token (#489)
* Adds Auth Result to Sign In with Custom token

* Addresses comomments
2017-11-27 14:17:05 -08:00
Paul Beusterien da9308408d Use brackets for module imports (#487) 2017-11-22 09:19:10 -08:00
Zsika Phillip bc2d78439a Adds AuthDataResult to signInWithEmailPassword Method (#484)
* Adds AuthDataResult to signInWithEmail:Password

* Addresses comments

* Addresses comments

* addresses more comments

* Fixes broken tests
2017-11-22 08:57:07 -08:00
Paul Beusterien 3e592526ec Buildable and interoperable source pods (#444) 2017-11-21 17:02:22 -08:00
Zsika Phillip 54aef651d8 Add Auth Result to createUserWithEmail (#477) 2017-11-20 15:56:03 -08:00
Zsika Phillip 5fbe71052d Adds AuthDataResult to anonymous sign in (#470)
* Adds AuthDataResult to anonymous sign in

* Fixes typo

* Addresses comments

* addresses comment on PR
2017-11-17 15:55:56 -08:00
Zsika Phillip 88b7e74e31 removes unused label from sample app (#468) 2017-11-16 15:27:02 -08:00
Zsika Phillip d0c65d8fc4 Fixes code style (#428) 2017-11-06 10:30:05 -08:00
Zsika Phillip 390d600b53 Improve swift sample app (#409)
* Updates the sign-in methods on Swift Sample

Updates the sign-in, reauth and link with credential methods on Swift Sample to use the recommended Auth result paradigm.

* adds missing space after {

* addresses comments
2017-10-25 16:49:59 -07:00
Ivan 13d59e3067 handles unstructured errors on redirect URLs 2017-10-23 13:46:46 -07:00
Ivan 4cf46e4123 Merge branch 'master' of https://github.com/firebase/firebase-ios-sdk into fix-reason-parameter 2017-10-23 11:39:10 -07:00
Ivan 9f6f969334 handles unstructured errors on redirect URLs 2017-10-23 11:38:29 -07:00
Paul Beusterien a9dc2f4c42 Add images and icons to silence Xcode 9 warnings (#396) 2017-10-20 16:42:25 -07:00
Xiangtian Dai a9585971c3 Silences unguarded availability warnings in Auth. (#389)
Also fixes a crash in the Auth sample app in an error case.

This addresses *Auth* part of #385 .
2017-10-19 08:58:36 -07:00
Ivan cd112a82cd Adds automated test for manual phone sign-in 2017-10-16 17:10:08 -07:00
Ivan ed4b9d4387 Adds automated test for manual phone sign-in 2017-10-16 16:58:53 -07:00
Ivan d8bcaf0f96 Adds automated test for manual phone sign-in 2017-10-16 15:07:13 -07:00
Ivan 26435988ce Adds automated test for manual phone sign-in 2017-10-13 15:16:25 -07:00
Ivan 41cc6ed1a5 new user popup toggle 2017-10-10 11:24:40 -07:00
Ivan 236a8e0424 new user popup toggle 2017-10-10 10:32:15 -07:00
Xiangtian Dai 532f538ee6 Prepare to release FirebaseAuth 4.3.0 (#345)
* Update Auth version to 4.3.0

* Revert "Removes user meta from public API (#308)"

This reverts commit 1602391bf8.

* Revert "Removes metadata from swift sample (#318)"

This reverts commit 804ff523a2.
2017-10-09 16:20:17 -07:00
Ivan 13b88a84f2 Add new user popup to sample app 2017-10-06 14:10:04 -07:00
Ivan e2df1923d2 Add new user popup to sample app 2017-10-06 11:59:53 -07:00
Ivan 71ecdf98c7 Adds new user popup to sample app. 2017-10-06 09:58:25 -07:00
Xiangtian Dai 4b1b3d62d8 Simplifies logic to post auth state change notifications, which is also applied more consistently now. (#325) 2017-10-03 09:58:47 -07:00
Xiangtian Dai bf550507ff Automatically signs user out if the token is no longer valid. (#323) 2017-10-02 14:15:05 -07:00
Zsika Phillip 7fa0b0de42 Disambiguates known errors from web context (#322)
* Disambiguates known errors from web context
 - Disambiguates known errors possibly returned by verifyPhoneNumber:UIDelegate:completion:
2017-10-02 11:21:55 -07:00
Zsika Phillip aebb293f3d Add operation phone auth (#309)
* Adds operation to verify PhoneNumber requests

* Improvements and unit tests

* Fixes typo

* Addresses comments

- Removes the FIRAuthOperation class.
- Defines the FIRAuthOperationType as an enum in a class of the same name.
- Passes the FIRAuthOperationType value down to the verifyPhoneNumber RPC where it is translated to a string.

* Fixes unit tests

* Actually fixes the unit tests.
2017-09-27 00:16:33 -07:00
Zsika Phillip 804ff523a2 Removes metadata from swift sample (#318)
Removes metadata from swift sample until it is made public again.
2017-09-26 18:44:20 -07:00
Xiangtian Dai 06fbbd8ee0 - Saves user metadata in keychain. (#305)
- Adds Swift stubs for the new API.
- Shows the `isNewUser` bit in the sample app.
2017-09-26 13:17:41 -07:00
Zsika Phillip 1602391bf8 Removes user meta from public API (#308)
* Removes user meta from public API

* remove unused import

removes unused import

* Removes Swift Name
2017-09-22 11:03:08 -07:00
Zsika Phillip f333bd5c18 User meta data (#292)
* Add user metadata

* Small improvements

* Addresses comments

* Fixes broken tests

Adds FIRUserMetadata to unbrella file.
2017-09-21 16:35:27 -07:00
Xiangtian Dai 64462179c3 Fixes a threading issue when calling back with an error for phone number auth. (#298)
Also changes the sample app to be able to test this case.
2017-09-21 11:25:32 -07:00
Xiangtian Dai f42d6d11e4 FIxes Swift name for the new protocol. (#289) 2017-09-19 14:01:06 -07:00
Paul Beusterien 9447e72cab Consolidate AuthSamples into main Firebase Xcode project (#288) 2017-09-19 11:18:04 -07:00
Zsika Phillip a34d091971 Removes unused Fir_authPhoneNumber (#277)
Removes references of unused Fir_authPhoneNumber and accompanying class.
2017-09-17 22:12:53 -07:00
Zsika Phillip f1c81936dd Modifies unit tests to accommodate event ID check (#270)
* Modifies unit tests to accommodate event ID check

* Extracts event ID from outgoing URL

* Addresses comments

Checks that the URL is rejected by the callback matcher without the event ID.
2017-09-14 13:30:58 -07:00
Xiangtian Dai 58ad5d177c Adds a check for custom scheme in plist for phone number auth reCAPTCHA. (#256)
Also rewrites phone number auth reCAPTCHA tests.
2017-09-13 15:09:00 -07:00
Xiangtian Dai c8ea66eecf Implements web view for presenting Auth web content on iOS 7 and 8. (#253)
Also (hopefully) fixes thread safety issues in presenting Auth web content.
2017-09-12 13:49:05 -07:00
Zsika Phillip af23702b56 ReCAPTCHA verification error handling (#241)
* reCAPTCHA error handling

* Improvements

* Addresses comments
2017-09-10 10:05:08 -07:00
Xiangtian Dai 96685dfbb9 Deprecates the old phone number auth method. (#236) 2017-09-06 11:36:26 -07:00
Xiangtian Dai 55d2d2d8be Fixes Auth URL presenter: (#239)
- kinda works on iOS 8-;
- calls back with cancellation error correctly on 'Done' button;
- cleans up upon completion.
2017-09-06 09:24:28 -07:00
Zsika Phillip 954484c4c4 Removes canHandleURL from FIRAuthInternal (#235)
* Removes canHandleURL from FIRAuthInternal

Removes canHandleURL from FIRAuth_Internal and makes small modification to FIRPhoneAuthProvider unit test.

* Addresses comment
2017-09-05 23:16:28 -07:00
Zsika Phillip 85e8137180 Adds app verification alternative (#228)
* Adds app verification alternative
2017-09-04 17:37:46 -07:00
Xiangtian Dai 1e9d652610 Swizzles APNs token error app delegate method for faster turnaround. (#226)
Also removes the server request in case the token is missing.
2017-09-01 14:38:45 -07:00