See #4035: a certain combination of pods can lead to a broken build. The underlying issue is that CocoaPods generate a header map that includes headers from _all_ the pods in a project. A header map maps short file names to full paths and is unable to handle collisions; thus, in a CocoaPods-based build, if one pod contains a header with a common name, and the other pod tries to import a header with the same short name by relying on header maps (without specifying a longer path), the header from one pod may end up getting erroneously picked up by the other pod.
In that particular case, `SVGKit` is relying on header maps and trying to import `Document.h`, which, for reasons described above, happens to pick up `document.h` from Firestore. However, since header maps cannot handle collisions in general, this could manifest with other pods as well.
The workaround is to avoid adding Firestore header files (except the public ones) to sources.
See https://github.com/facebook/react-native/issues/14326, which describes the same problem.
Fixes#4035.
* Update versions for Release 6.10.0
* Cherrypick #3983 and include Database in release. (#3986)
* Remove log argument that causes SocketRocket crash (#3983)
* Add FirebaseDatabase to release.
* Update CHANGELOG with version.
* Cherrypick for #3984 along with CHANGELOG update. (#3988)
* Fix race condition in FIRComponentContainer instance creation (#3984)
* Fix race condition in FIRComponentContainer instance creation
Reported in #3967. Users sometimes seeing a crash when multiple threads
concurrently try to create Firestore instances. By inspection I found
that there's a race here where two threads can check for presence in the
cache, see nothing, proceed to creation, both store a value in the cache,
and both return their copies. This would lead to two Firestores being
created for a single App.
This replaces `dispatch_sync` on a serial queue with good old
`@synchronized` blocks. `dispatch_sync` will self-deadlock if called
from a thread already on the queue while `@synchronized` allows
recursion.
No new tests are added because several tests like
`testDependencyDoesntBlock` already cover this case.
* format
* Update Core CHANGELOG
* Update Core CHANGELOG again
* Fix merge from CHANGELOG
* Update versions for Release 6.9.0
* Fix unbalanced background task creation in GDTCCTUploader (#3838) (#3839)
* Add Manifest
* dependency version update
* Cherry picks for 6.9.0 (#3871)
* fixed "expiclitlySet" typo. (#3853)
* Mark unused variables (#3854)
* Mute FCM deprecated warnings with Xcode 11 and min iOS >= 10 (#3857)
* Add a third slash to make sure generated docs include these comments.b/13812238 (#3846)
* Update versions for Release 6.8.0
* RemoteConfig fix pod spec lint (#3715) (#3716)
* ABTesting: add protos to private headers.
* RemoteConfig: #import <FirebaseABTesting/ExperimentPayload.pbobjc.h>
* ./scripts/style.sh
* Remote Config `pod spec lint` fixes (#3717) (#3718)
* Fix ExperimentPayload.pbobjc.h imports
* RemoteConfig tests: add missing headers to spec.
* Revert ExperimentPayload.pbobjc.h import for ABTesting sources.
* Add FDL to M55 (#3724)
* Remove references to UIWebView from DynamicLinks to comply with Apple "ITMS-90809: Deprecated API Usage" (#3723)
* Add FDL to M55
* Fix accessing a destroyed object (#3721) (#3725)
This was caused by running under Asan with XCode 11. Apparently, previous versions of XCode cannot catch it (which is why Travis is passing, apparently).
Also:
* enable "Detect use of stack after return" option for Asan. AFAIU, it can only be enabled in the scheme. It's already enabled for unit tests, this PR additionally enables it for integration tests;
* make Asan failures fail Travis build. They were originally not considered blocking due to some sporadic failures. I haven't seen those for some time, and worst case scenario, we can revert this change.
* Cherry pick GDT changes for 6.8.0 and increment versions (#3770)
* Release 6.8.0: cherry pick of #3764 and #3766 (#3772)
* Gate access to cached instances. (#3766)
* Gate access to cached instances.
This is causing an issue in #3728. Hopefully this will fix it, but no
repro is available yet to test. There's still an underlying race
condition where a `creationBlock` could be called twice for a component
that is supposed to cache the instance returned, but that should be
addressed in a follow up PR.
* Review feedback.
* Iterate from array copy in `latestExperimentStartTimestampBetweenTimestamp:` (#3764)
* Release 6.8.0 cherry pick: conflicting Dynamic Links changelog changes. (#3790)
* Update FDL CHANGELOG (#3781)
* Issue number, not PR number (#3785)
* Update versions for Release 6.3.0
* Revert "Raise exception when log into Facebook using OAuth. (#3138)" (#3208) (#3209)
This reverts commit 393d060710.
* Migrate FSTServerTimetsampValue to FSTDelegateValue
* Make ServerTimestamp use FSTFieldValue for previous value
This makes it possible integrate the FSTServerTimestampValue changes
earlier.
* Bump to gRPC-C++ 0.0.9
This release includes https://github.com/grpc/grpc/pull/19082 which
changes the certificate bundle name to make it possible to have voth
gRPC-C++ and gRPC in the same project.
* Defer loading bundles until needed.
* Handle certificante bundle rename in gRPC-C++ 0.0.9
* Update versions for Release 6.1.0
* Release 6.1.0 - cherry pick of #3007 (#3011)
* 6.1.0 manifest updated. FirebaseInAppMessaging bumped to 0.14.1
* Early return from sending analytics events in instance ID is nil (#3007)
* Update versions for Release 6.0.0
* Update FirebaseSDKs.textproto with new fields. (#2818) (#2834)
* Update FirebaseSDKs.textproto with new fields.
* Update message about strip_32bits flag.
* GULAppDelegateSwizzler - proxy APNS methods separately (#2835) (#2858)
* Cherry-picks for M47 RC5 (#2882)
* fix race condition checkin is deleted before writing during app start (#2860)
* GoogleUtilities min ios version from 6 to 8 (#2876)
* Put secret and oauth credentials into the private headers for now. (#2916) (#2919)
* Add missing Messaging weak_framework dep (#2921) (#2930)
* Update versions for Release 5.17.0
* Fix the tag in the FIAM podspec.
* Update dependencies for FIAM.
* Updated the FirebaseCore version.
* Fix FIROptions version.
* Temporarily remove FIAM version deps for pod linting.
* Create umbrella header for FIAM (#2392)
This causes an issue when building the zip file - similar to #1857
* Remove FIAM from 5.17.0 release.
Besides adding a new macOS example to the project, this:
* Adds a search for roots.pem in root of main bundle
* Accepts swiftformat 0.37 in `style.sh`
* Extends the travis_wait from the default 20 mins to 45 to allow for building iOS and macOS.
Now, we use the re-worked nanopb deserializer (that mallocs). This also
had the advantage of moving the C++ serialization code closer to the
other platforms.
Still TODO:
- Reorder the methods within the files to resemble the other platforms.
* Update versions for Release 5.15.0
* Create 5.15.0.json
* Update CHANGELOG for Firestore v0.16.1 (#2164)
* Update the name of certificates bundle (#2171)
To accommodate for release 5.14.0.
* Fix format string in FSTRemoteStore error logging (#2172)
* Update CHANGELOG.md
* Update 5.15.0.json
gRPC-C++ versions up to and including 0.0.3, and also 0.0.5, don't bundle `roots.pem` in the podspec. gRPC-C++ 0.0.4 and, presumably, the currently not-yet-released 0.0.6 do. Firestore currently also bundles this file under the same bundle name, which leads to build errors when both Firestore and gRPC-C++ try to add the file into the build (only shows during archiving).
For transition, this PR:
* renames the Firestore bundle to avoid naming clash;
* changes the loading code so that it first tries to load certificates bundled with gRPC-C++ (versions 0.0.4 and 0.0.6+), but falls back to those bundled with Firestore if necessary.
At a later point, Firestore should be changed to not bundle the certificates altogether.
* Update versions for Release 5.13.0
* Revert premature api changes (#2097)
* Revert "Add warning for deprecated API to indicate that the passed in domain name's scheme will deduced as https (#2078)"
This reverts commit ceb839293e.
* Revert "Allow setting the domainURIPrefix for custom domain names/paths when creating dynamic links (#2071)"
This reverts commit d917bac047.
* Revert "Minor edits: change domain names in test app plist, fix warnings."
This reverts commit 15f5d46807.
* Revert "Fix style. Run ./scripts/style.sh"
This reverts commit 0e16e6c863.
* Revert "Allow for custom domains in the FDL iOS SDK"
This reverts commit 5e33153f70.
* Version is still 3.2.0
* Revert "Revert "gRPC: replace Objective-C implementation with the new C++ implementation (#1968)" (#2030)"
This reverts commit ea567dca47.
* gRPC: fix bugs found during testing (#2039)
All in `GrpcStream`:
* make sure there are no pending completions when "finish" operation is enqueued;
* always finish gRPC calls;
* when connectivity changes, reset not just the calls, but the underlying channel as well.
* Revert "Partially revert "Update CHANGELOG for Firestore v0.14.0 (#2025)" (#2031)"
This reverts commit b2437b80f6.
* Update changelog for v0.15.0.
* gRPC: add gRPC wrapper classes to CMake build (#2015)
* add a C++ equivalent of `FIRFirestoreVersionString`. This eliminates the only Objective-C dependency of `grpc_connection.mm` and allows making it a pure C++ file;
* open-source `binary_to_array.py` script and use it in the build to embed `roots.pem` certificate file from gRPC into the Firestore binary. The embedded char array is then used to load certificate at runtime.
* Revert local change -- do not enable sanitizers by default
* Update abseil-cpp to a new upstream
Update to 7990fd459e9339467814ddb95000c87cb1e4d945 master@{2018-11-06}
* Re-apply -Wcomma fix
* Update add_subdirectory for Abseil
* Remove references to Firestore/Port (which longer exists)
* Fix ABSL_HAVE_THREAD_LOCAL when targeting iOS 8 in Xcode 10
* Clean up abseil warnings
* Clean up a Firestore format string warning.
* Exclude third_party/abseil-cpp from whitespace checks
* Update versions for Release 5.12.0
* Add missing nanopb flag
* Isolate Firestore nanopb messages in C++ namespaces (#2046)
* Add C++ namespaces and use C++ linkage for nanopb-generated sources.
* Regenerate nanopb sources as C++
* Add generated C++ nanopb sources to the podspec
* Add C++ namespaces and use C++ linkage for nanopb-generated sources.
* Regenerate nanopb sources as C++
* Add generated C++ nanopb sources to the podspec
* add support for SSL disabled to `GrpcConnection` (unfortunately, there
currently is no way to verify this change actually works);
* make gRPC calls using the C++ implementation:
* make `FSTRemoteStore` create C++ streams instead of their Objective-C
counterparts;
* port https://github.com/firebase/firebase-js-sdk/pull/1041: streams
are now never recreated, only restarted;
* make `FSTDatastore` delegate server calls to the C++ implementation;
* port `MockWatchStream` and `MockWriteStream` to C++ (`FSTMockDatastore` is
still in place, because `Datastore` is not fully ported yet);
* no longer generate Objective-C gRPC service definitions from protos;
* remove all references to Objective-C gRPC client;
* check in gRPC root certificates file and load it at runtime (the check-in part
is temporary until gRPC-C++.podspec provides the certificate). This makes SSL
work.
Paul Beusterien