Commit Graph
59 Commits
Author SHA1 Message Date
Riz 66f3aeda16 Log direct-channel state changes to console (#287) 2017-09-19 12:58:58 -07:00
Paul Beusterien 9447e72cab Consolidate AuthSamples into main Firebase Xcode project (#288) 2017-09-19 11:18:04 -07:00
Zsika Phillip a34d091971 Removes unused Fir_authPhoneNumber (#277)
Removes references of unused Fir_authPhoneNumber and accompanying class.
2017-09-17 22:12:53 -07:00
Sebastian Schmidt c6bde890ce Adding Multi-Resource support to the Firebase iOS SDK (#278)
* Adding Multi-Resource support to the Firebase iOS SDK.

This CL also makes RepoInfo hashable and simplifies RepoManager based on this.
2017-09-15 16:45:46 -07:00
Zsika Phillip f1c81936dd Modifies unit tests to accommodate event ID check (#270)
* Modifies unit tests to accommodate event ID check

* Extracts event ID from outgoing URL

* Addresses comments

Checks that the URL is rejected by the callback matcher without the event ID.
2017-09-14 13:30:58 -07:00
Riz 446c5c0267 Remove FIRMessaging_FAIL macro, log result code (#265)
This removes the `FIRMessaging_FAIL` macro which was using `__builtin_trap()`, and replaced with `NSAssert` calls. These `NSAssert` calls may not get called in release builds, and so we also log them with FIRLogger error messages.

The RMQ database open error result code is now parsed and included in the error message to help us identify causes for #199 .
2017-09-13 17:43:17 -07:00
Paul Beusterien 1c97e8266a Move mugs derived code to third_party with proper LICENSE (#247) 2017-09-13 15:35:01 -07:00
Xiangtian Dai 58ad5d177c Adds a check for custom scheme in plist for phone number auth reCAPTCHA. (#256)
Also rewrites phone number auth reCAPTCHA tests.
2017-09-13 15:09:00 -07:00
Xiangtian Dai c8ea66eecf Implements web view for presenting Auth web content on iOS 7 and 8. (#253)
Also (hopefully) fixes thread safety issues in presenting Auth web content.
2017-09-12 13:49:05 -07:00
Zsika Phillip af23702b56 ReCAPTCHA verification error handling (#241)
* reCAPTCHA error handling

* Improvements

* Addresses comments
2017-09-10 10:05:08 -07:00
Sebastian Schmidt e8e0916c2a Firebase Storage: Allowing metadata to be cleared (#197)
* Allowing metadata to be cleared
2017-09-06 14:37:04 -07:00
Xiangtian Dai 96685dfbb9 Deprecates the old phone number auth method. (#236) 2017-09-06 11:36:26 -07:00
Xiangtian Dai 55d2d2d8be Fixes Auth URL presenter: (#239)
- kinda works on iOS 8-;
- calls back with cancellation error correctly on 'Done' button;
- cleans up upon completion.
2017-09-06 09:24:28 -07:00
Zsika Phillip 954484c4c4 Removes canHandleURL from FIRAuthInternal (#235)
* Removes canHandleURL from FIRAuthInternal

Removes canHandleURL from FIRAuth_Internal and makes small modification to FIRPhoneAuthProvider unit test.

* Addresses comment
2017-09-05 23:16:28 -07:00
Zsika Phillip 85e8137180 Adds app verification alternative (#228)
* Adds app verification alternative
2017-09-04 17:37:46 -07:00
Xiangtian Dai 1e9d652610 Swizzles APNs token error app delegate method for faster turnaround. (#226)
Also removes the server request in case the token is missing.
2017-09-01 14:38:45 -07:00
Zsika Phillip 36c20d92b7 Add FirAuthUrlPresenter (#222)
* Adds FIRAuthURLPResenter and FIRAuthUIDelegate
2017-09-01 13:38:12 -07:00
Xiangtian Dai 0ce42970fc Adds missing unit tests to the Example project and fixes one test case. (#224) 2017-08-30 19:19:39 -07:00
Xiangtian Dai 5d984b0611 Silences compiler warnings in the Auth test file from #207 . (#219) 2017-08-28 14:38:58 -07:00
Zsika Phillip 2a22a88141 fixes request URL (#218) 2017-08-25 14:37:36 -07:00
Zsika Phillip fb1b4ba587 Add get Auth domain RPC (#214)
* Add get Auth domain RPC

* Fixes indentation

* Addresses comments

* ran tests on Example/Firebase.xcodeproj
2017-08-24 13:58:50 -07:00
Zsika Phillip 768c4058f3 Adds reCAPTCHA Token (#211)
* Adds reCAPTCHA Token to the "send verification code" request.
2017-08-23 09:02:50 -07:00
Xiangtian Dai 6e12c501f8 Forwards app delegate's openURL invocations to FIRAuth. (#207) 2017-08-21 21:14:20 -07:00
Ryan Wilson f3d2588b94 Fix failing Database integration tests. (#206)
Deleting the defaultApp causes issues between the other tests. Remove
the portion of the test deleting the defaultApp will alleviate the
issue.
2017-08-18 22:22:02 -04:00
Ryan Wilson 566665e3bb Delete app from Database when deleted in Core. (#194)
* Delete an app from Database when deleted in Core.

When a FIRApp is deleted in Core, it should also be deleted from
the instances array in Database.

See #160 for more details.

* Add tests for deleting databases.

* Add call to clean up deleted FIRDatabase instance.
2017-08-17 11:15:25 -04:00
Paul Beusterien d7778595c1 Update Firebase.xcodeproj with CocoaPods 1.3.1 perf improvements (#189)
* Remove "OSX" cruft (should be macOS)
* Update travis to use CocoaPods 1.3.1
* Update AuthSamples project as well
2017-08-11 17:40:36 -07:00
Xiangtian Dai 8c3ef6b780 Handles MISSING_EMAIL error from server. (#187) 2017-08-11 17:12:11 -07:00
Xiangtian Dai 4ec1d8a30b Fixes an incorrect assumption of Auth server error message. (#179)
Also allows the Auth sample app to test all combination of `handleCodeInApp` and continue URL.
2017-08-04 18:15:47 -07:00
Marek Gilbert 360f7bed25 Result of clang-format with AllowShortFunctionsOnASingleLine: None 2017-08-02 11:07:57 -07:00
Marek Gilbert e4af03818c Formatting updates based on the latest clang-format
clang-format version 5.0.0 (tags/google/stable/2017-06-22)
2017-08-02 09:52:48 -07:00
Xiangtian Dai e5524db414 APNs token handling improvements. (#157)
* APNs token handling improvements.

- Calls VerifyClient without token anyway if the APNs token cannot be retrieved.
  This allows server to use discretion if needed in future. The developer will
  receive the same error as before.
- Moves token formatting code to the token class itself to make the main logic
  in the provider class more clear. This also eliminates duplicated code in the
  sample app.

* Adds a comment about a string constant used in test.
2017-07-28 17:44:46 -07:00
Xiangtian Dai 925a1cc0a2 Merge from private/auth-master (#159)
* Adds passing state and continue URL in OOBCodes actions. (#82)

* Adds actionCodeSettings class (#83)

* Adds FIRActionCodeSettings class

* Removes iOSAppStoreId to reflect update spec.

* Adds “reset password in app” to sample app (#84)

* Adds “reset password in app” to sample app

* Addresses comments

* Addresses comments

* Adds @param documentation for actionCodeSettings (#85)

Adds @param documentation for actionCodeSettings in FIRGetOOBConfirmationCodeRequest.

* Adds request configuration class

Adds a class that will comprise of all configurations needed to make a request to the Firebase Auth backend; including APIKey and Language code in the future.

* Addresses comments.

* Adds Setting Language

Add Setting Language Feature to Firebase Auth.

- Only adds support for two languages (English and Spanish) in this change. (Also supports two languages in test), more to come after this change is accepted.

- For now sample app tests language setting only when using “reset password in app” option, the email sent will be in the current app language.  Additional tests to come after change is accepted.

* Amends code for unit tests

Will add more comprehensive testing when code accepted.

* Ecodes strings files in UTF-8

* Addresses comments

* Addresses comments

* Remove comments in .strings

* Adds remaining TC languages to Firebase Auth.

* Add line break to .strings files

* remove language code english fallback

Remove the fallback that sends “en” as the language code to the backend if no language code is specified.

* addresses comment

* Fixes FIRSecureToken Crash

Integrates FIRSecureTokenService and FIRSecureTokenRequest with FIRAuthRequestConfiguration.

* Addresses comment

* Add auth language input

Adds Auth language input to the Sample App in preparation for manual testing.

* removes unnecessary comment

* address comments

* Add app language option

Allow user to set the current app language code as the auth language code.  This is in preparation for manual testing before release.

* Addresses Comment

* Adds missing continue URI

Adds missing continue URL to Firebear error handling.

* Remove unused line

Removes unused line from FIRPhoneAuthProvider.m

* Moves the new public header to the right place.

* Fixes broken macOS build.

* Removes trailing spaces.

* Addresses review comments.
2017-07-28 17:43:33 -07:00
Paul Beusterien 0abd344434 Add clang-format options and script; apply to FirebaseCore (#151) 2017-07-27 11:02:39 -07:00
Paul Beusterien dec86df553 Disable another test that depended on broken pre-iOS 11 small doubles (#152) 2017-07-26 14:32:28 -07:00
Sebastian Schmidt 4a22dc2a18 Purge persistence cache if we can't load from it (#153)
* Purge persistence cache if we can't load from it

* Adding unit test

* Review comments
2017-07-26 13:50:34 -07:00
davidair f7fc2bb573 Moving sMessageCodeRegex initialization into #ifdef DEBUG to remove the init cost, adding [FIRApp configure] to the Core example (#150) 2017-07-25 11:28:17 -04:00
Sebastian Schmidt f1fbbf3adb Disabling NSJSON edge case test on iOS 11 (#148)
* Disabling NSJSON edge case test on iOS 11

* Adding check for iOS

* Fix formatting

* Using TARGET_OS_IOS instead of TARGET_OS_IPHONE
2017-07-20 14:20:07 -07:00
Ryan Wilson 11d004105e Add method to check if defaultApp is configured. (#139)
This lets other SDKs check if the default `FIRApp` is set up without
accessing it, which causes unnecessary log messages to appear.
2017-07-17 14:31:01 -04:00
Paul Beusterien 053b2f11ea Use modulemap to fix exposure of FirebaseCore's internal headers (#121) 2017-07-10 14:57:03 -07:00
davidair bf5ef4be6d Removing a backspace character (#132) 2017-07-10 15:09:09 -04:00
Paul Beusterien 9792bec7e3 Disable failing FIRLogger test until Issue 128 is fixed (#129) 2017-07-10 08:51:26 -07:00
Sebastian Schmidt 3db59eabbc Adding size to Storage's NSDictionary representation (#120)
* Adding size to Storage's NSDictionary representation

* Review comments

* Remove trailing whitespace
2017-07-04 22:19:50 -07:00
Paul Beusterien ddbfd4cc66 Add travis trailing whitespace check (#116)
* Add travis trailing whitespace check

* Remove trailing white space
2017-06-30 13:47:37 -04:00
Paul Beusterien 6761901507 Remove Auth/Source/Private - restoring headers to original location (#113) 2017-06-29 15:12:13 -07:00
Paul Beusterien c33bdff405 Group public headers into Public directories (#112) 2017-06-29 12:03:45 -07:00
Sebastian Schmidt c67a8bdc58 Fixing parsing for double numbers (#107)
NSJSONSerialization parses long values as doubles and returns NSNumber that are backed by doubles to the users. For NSNumbers that can be stored as longs, we can overwrite this behavior by re-running the initialization step.
2017-06-27 10:04:47 -07:00
Paul Beusterien 0297375121 Rename FirebaseDev to FirebaseCommunity (#98) 2017-06-22 13:08:35 -07:00
Zsika Phillip 58959a676a Adds NSSecureCoding unit tests for FIRUser (#74)
* Adds unit tests for NSSecureCoding for FIRUser
2017-06-07 14:32:02 -07:00
Paul Beusterien aac64a63ae Add Foundation import so TARGET_OS_IOS or other TARGET_OS_* gets defined (#71) 2017-06-06 17:00:20 -07:00
Riz 23e3cf6e2f Restore bundle id and dev team for Messaging iOS (#60)
This got lost in the transfer to new Xcode targets. The reasons why Messaging iOS has a specific bundle id is that this bundle is whitelisted for internal Google development, making it easier for folks that work on FCM to test with this app.
2017-06-02 12:20:33 -07:00