Commit Graph
7 Commits
Author SHA1 Message Date
Riz 446c5c0267 Remove FIRMessaging_FAIL macro, log result code (#265)
This removes the `FIRMessaging_FAIL` macro which was using `__builtin_trap()`, and replaced with `NSAssert` calls. These `NSAssert` calls may not get called in release builds, and so we also log them with FIRLogger error messages.

The RMQ database open error result code is now parsed and included in the error message to help us identify causes for #199 .
2017-09-13 17:43:17 -07:00
Riz e00eaa8f0e Encode the topic name when subscribing (#220)
This should address the issue filed at: https://github.com/firebase/quickstart-ios/issues/242, where a topic name containing a `%` character was failing. It turns out that the topic name was never being url-encoded.
2017-08-30 15:38:43 -07:00
Riz 1a857fe48f Don't save library version to NSUserDefaults (#212)
This seems to be a holdover from some old code, and it's not being used anywhere in the component. Plus it's better not to be saving anything in `[NSUserDefaults standardUserDefaults]` as that is the developer/app's domain.

Also renamed the messaging code while I was in there to be something meaningful ("000" → "PrintLibraryVersion").
2017-08-23 13:52:42 -07:00
Ryan Wilson 94dd3c50ad Configure Messaging for default FIRApp only. (#154)
Currently Messaging will use the most recent FIRApp configured which
isn't obvious. This will limit it to only the defualt FIRApp.
2017-07-26 22:17:48 -04:00
Paul Beusterien e58f734562 Add missing Foundation import (#46) 2017-05-31 17:34:57 -07:00
Riz f67c074ed1 Log an error if for some reason we can't add a method to a class (#24)
Maybe it was already swizzled, or some other issue. Either way, it would be good to log this error, as it might help us / developers diagnose an issue.
2017-05-23 15:16:02 -07:00
Paul Beusterien 98ba64449a Initial 2017-05-15 12:27:07 -07:00