Commit Graph
312 Commits
Author SHA1 Message Date
Benoit St-Pierre 67ece3fe35 Revert "Add Firebase Source to Header Search Path" (#2123)
* Revert "Custom fdl domain (#2121)"

This reverts commit ebea1eff17.

* Revert "enable disabled passed integration test (#2120)"

This reverts commit 48e5f7a33b.

* Revert "Wire together LRU GC (#1905)"

This reverts commit 305f87215e.

* Revert "Fix build under linux/gcc (#2116)"

This reverts commit b0a4b6c827.

* Revert "Implement PatchMutation::ApplyToLocalView (#1973)"

This reverts commit f66b5b5b2a.

* Revert "Add Firebase Source to Header Search Path (#2114)"

This reverts commit 0540361852.
2018-11-27 07:53:50 -05:00
Chuan Ren ebea1eff17 Custom fdl domain (#2121) 2018-11-26 22:19:29 -08:00
Benoit St-Pierre 0540361852 Add Firebase Source to Header Search Path (#2114)
This resolves the annoying Xcode errors that claim `FIRAppInternal.h` can't be found.

It also makes it *much* easier to "Jump to definition" now.
2018-11-22 17:32:13 -05:00
Benoit St-Pierre 54659e8d99 Database Interop Rollforward (#2095)
* Register Database with Interop

+ Add AuthInterop dependency
+ Have Database register with Interop component container
+ Add weak dependency on Auth
~ Cleaned up imports

* Use Interop for Auth token fetching

+ Use macro to get auth component
~ Change `getTokenForcingRefresh:withCallback:` call to use Interop component version of Auth
~ Clean up imports

* Implement necessary protocols

+ Added FIRComponentRegistrant and FIRDatabaseNilProtocol to FIRDatabase

* Squash of my previous local commits for Database Interop

Register Database with Interop:

  + Add AuthInterop dependency
  + Have Database register with Interop component container
  + Add weak dependency on Auth
  ~ Cleaned up imports

Use Interop for Auth token fetching:

  + Use macro to get auth component
  ~ Change `getTokenForcingRefresh:withCallback:` call to use Interop component version of Auth
  ~ Clean up imports

Implement necessary protocols:

  + Added FIRComponentRegistrant and FIRDatabaseNilProtocol to FIRDatabase

Clean up Database tests:

  - Removed all unnecessary header files
  ~ Ran style.sh across all the tests

Cleaned Up project file:

  Some header removals were missed in the last commit.

Sorted some test files

Fix Database Fake App Tests:

  + Added container property
  + Added an Auth fake in the container
  + Added the Shared utils files to the necessary targets
  + Added a missing XCTest reference in a test that didn't compile for me

* Revert "Squash of my previous local commits for Database Interop"

This reverts commit c0d0421237.

* Cleaned Up project file

Some header removals were missed in the last commit.

* Sorted some test files

* Fix Database Fake App Tests

+ Added container property
+ Added an Auth fake in the container
+ Added the Shared utils files to the necessary targets
+ Added a missing XCTest reference in a test that didn't compile for me

* PR Feedback Changes

+ Created new FIRDatabaseComponent class to encapsulate instance creation
+ Updated FAuthTokenProvider to only use an auth instance rather than an app.

* PR Feedback Follow-Up

- Removed FIRDatabase registration code

* pod deintegrate

* Move instance management

Somes tests may still be out of date.

* Fix Auth integration test

* pod deintegrate -- again

* PR Feedback

* PR Feedback

Added the FIRComponentLifecycleMaintainer protocol to FIRDatabaseComponent

* Update Firebase/Database/Api/FIRDatabaseComponent.m

Missed some small changes

* Get integration tests compiling

* Fix some tests

* Fixed more tests

Component needs to be cacheable in order to get the appWIllBeDeleted callback.

* Update target memberships

* Revert project file changes

* Add FIRAuthInteropFake for broken targets

* PR feedback

* Spacing and Style

* Moved `instances` to ivar

* Simplify FIRDatabaseDictionary

It's now keyed on the URL with the app being implied since each app will get its own `FIRDatabaseComponent`

* Fix Database Integration Tests

Have the FakeApp cache DB instances
Use the Full host/URL path to cache DB instances
Simplified shared scheme

```
Test Suite 'Database_IntegrationTests_iOS.xctest' passed at 2018-11-20 07:09:30.520.
	 Executed 326 tests, with 0 failures (0 unexpected) in 66.251 (66.528) seconds
Test Suite 'All tests' passed at 2018-11-20 07:09:30.522.
	 Executed 326 tests, with 0 failures (0 unexpected) in 66.251 (66.530) seconds
```

* Clarify defaultApp use
2018-11-22 06:44:42 -05:00
davidair 20a0bda002 Release 5.13.0 (#2101)
* Update versions for Release 5.13.0

* Revert premature api changes (#2097)

* Revert "Add warning for deprecated API to indicate that the passed in domain name's scheme will deduced as https (#2078)"

This reverts commit ceb839293e.

* Revert "Allow setting the domainURIPrefix for custom domain names/paths when creating dynamic links (#2071)"

This reverts commit d917bac047.

* Revert "Minor edits: change domain names in test app plist, fix warnings."

This reverts commit 15f5d46807.

* Revert "Fix style. Run ./scripts/style.sh"

This reverts commit 0e16e6c863.

* Revert "Allow for custom domains in the FDL iOS SDK"

This reverts commit 5e33153f70.

* Version is still 3.2.0
2018-11-20 17:23:55 -05:00
Chuan Ren a1966bb639 Add test for verify iOS client (#2096) 2018-11-19 15:34:18 -08:00
Paul Beusterien 46cb564067 Revert premature api changes (#2097)
* Revert "Add warning for deprecated API to indicate that the passed in domain name's scheme will deduced as https (#2078)"

This reverts commit ceb839293e.

* Revert "Allow setting the domainURIPrefix for custom domain names/paths when creating dynamic links (#2071)"

This reverts commit d917bac047.

* Revert "Minor edits: change domain names in test app plist, fix warnings."

This reverts commit 15f5d46807.

* Revert "Fix style. Run ./scripts/style.sh"

This reverts commit 0e16e6c863.

* Revert "Allow for custom domains in the FDL iOS SDK"

This reverts commit 5e33153f70.

* Version is still 3.2.0
2018-11-19 13:13:47 -08:00
Benoit St-Pierre 50d27eb6ac Revert "Database Interop (#1865)" (#2093)
This reverts commit 4090195f15.
2018-11-19 09:52:42 -05:00
Benoit St-Pierre 4090195f15 Database Interop (#1865)
* Register Database with Interop

+ Add AuthInterop dependency
+ Have Database register with Interop component container
+ Add weak dependency on Auth
~ Cleaned up imports

* Use Interop for Auth token fetching

+ Use macro to get auth component
~ Change `getTokenForcingRefresh:withCallback:` call to use Interop component version of Auth
~ Clean up imports

* Implement necessary protocols

+ Added FIRComponentRegistrant and FIRDatabaseNilProtocol to FIRDatabase

* Squash of my previous local commits for Database Interop

Register Database with Interop:

  + Add AuthInterop dependency
  + Have Database register with Interop component container
  + Add weak dependency on Auth
  ~ Cleaned up imports

Use Interop for Auth token fetching:

  + Use macro to get auth component
  ~ Change `getTokenForcingRefresh:withCallback:` call to use Interop component version of Auth
  ~ Clean up imports

Implement necessary protocols:

  + Added FIRComponentRegistrant and FIRDatabaseNilProtocol to FIRDatabase

Clean up Database tests:

  - Removed all unnecessary header files
  ~ Ran style.sh across all the tests

Cleaned Up project file:

  Some header removals were missed in the last commit.

Sorted some test files

Fix Database Fake App Tests:

  + Added container property
  + Added an Auth fake in the container
  + Added the Shared utils files to the necessary targets
  + Added a missing XCTest reference in a test that didn't compile for me

* Revert "Squash of my previous local commits for Database Interop"

This reverts commit c0d0421237.

* Cleaned Up project file

Some header removals were missed in the last commit.

* Sorted some test files

* Fix Database Fake App Tests

+ Added container property
+ Added an Auth fake in the container
+ Added the Shared utils files to the necessary targets
+ Added a missing XCTest reference in a test that didn't compile for me

* PR Feedback Changes

+ Created new FIRDatabaseComponent class to encapsulate instance creation
+ Updated FAuthTokenProvider to only use an auth instance rather than an app.

* PR Feedback Follow-Up

- Removed FIRDatabase registration code

* pod deintegrate

* Move instance management

Somes tests may still be out of date.

* Fix Auth integration test

* pod deintegrate -- again

* PR Feedback

* PR Feedback

Added the FIRComponentLifecycleMaintainer protocol to FIRDatabaseComponent

* Update Firebase/Database/Api/FIRDatabaseComponent.m

Missed some small changes

* Get integration tests compiling

* Fix some tests

* Fixed more tests

Component needs to be cacheable in order to get the appWIllBeDeleted callback.

* Update target memberships

* Revert project file changes

* Add FIRAuthInteropFake for broken targets

* PR feedback

* Spacing and Style

* Moved `instances` to ivar

* Simplify FIRDatabaseDictionary

It's now keyed on the URL with the app being implied since each app will get its own `FIRDatabaseComponent`
2018-11-19 07:36:05 -05:00
dmandar d917bac047 Allow setting the domainURIPrefix for custom domain names/paths when creating dynamic links (#2071)
* Add support for creating DL with custom domain names/paths. The new domainURIPrefix parameter requires either a. a valid FDL domain name created in the Firebase console or b. a custom domain name or c. a custom domain name with path registered for DL. All domainURIPrefixes need to start with a valid (https) scheme.

* Fix style.

* style

* Fix typo in DEPRECATED_MSG_ATTRIBUTE, other nits.

* Fix styling.

* Check incoming domainURIPrefix for validity using NSURL and check for an https scheme.
2018-11-13 22:38:54 -08:00
Morgan Chen 3dbcead555 Merge pull request #2061 from morganchen12/gulchangelist
Invalidate non-background url sessions
2018-11-12 12:59:55 -08:00
Mandar 3303750469 Fix style. 2018-11-11 15:43:29 -08:00
Mandar 5d8431cc6c Merge branch 'master' into md-fdl 2018-11-09 16:46:26 -08:00
Mandar e85b0c7af7 Fix warning. 2018-11-09 16:19:49 -08:00
Mandar 15f5d46807 Minor edits: change domain names in test app plist, fix warnings. 2018-11-09 15:54:51 -08:00
Morgan Chen fb9639a0b3 Run style 2018-11-08 15:55:58 -08:00
Mandar bb954291c7 FIRApp is already configured. Remove duplicate configure call. This Fixes unit test failure. 2018-11-08 12:35:20 -08:00
Paul Beusterien 407f5d6584 Update Auth samples to sync with internal changes (#2056) 2018-11-07 14:23:14 -08:00
Paul Beusterien e77ba8c776 Release 5.12.0 (#2051)
* Update versions for Release 5.12.0
* Add missing nanopb flag
* Isolate Firestore nanopb messages in C++ namespaces (#2046)
* Add C++ namespaces and use C++ linkage for nanopb-generated sources.
* Regenerate nanopb sources as C++
* Add generated C++ nanopb sources to the podspec
2018-11-06 13:26:50 -08:00
Paul Beusterien c27db6d477 Fix analyze errors (#2047) 2018-11-05 13:07:22 -08:00
Chuan Ren 3e2d70506d Fix auth multi app support (#2043) 2018-11-02 17:01:54 -07:00
Paul Beusterien 57ba70503b Delete deprecated files (#2038) 2018-11-01 15:39:10 -07:00
Paul Beusterien ea076e38a6 Don't rely on test always being in foreground (#2021) 2018-10-29 13:15:20 -07:00
Paul Beusterien 5e37beb481 Attempt to fix frequent Auth Unit Test flake on OSX (#2017) 2018-10-29 07:00:58 -07:00
davidair b032cccdf1 Changing the internal testing repo (#2003) 2018-10-25 15:02:23 -04:00
Sebastian Schmidt 77f1bee060 Adding AppCode Diff (#1996) 2018-10-24 13:47:36 -07:00
Ryan Wilson ec748a5265 Merge branch 'master' into release-5.11.0 2018-10-24 14:26:35 -04:00
Ryan Wilson 4c50de65d4 Reduce singleton usage in FIRApp tests. (#1995)
* Reduce singleton usage in FIRApp tests.

There have been some issues while creating new tests of conflicts with
mocks of classes and instances, this should alleviate some of those
conflicts in the future.

* Remove bad style changes.

* Use default app name flag instead of local variable.
2018-10-24 11:03:54 -04:00
Ryan Wilson ef5949d6a8 Remove unnecessary notification flag (#1993)
* Remove unnecessary notification flag.

This was added when the Google pod could configure Firebase but the
Google pod is deprecated and can only work with Firebase 3.X. These
flags and conditional checks can be safely removed.

* Resolve issues from commit split.

* Style fixes.
2018-10-24 07:17:12 -04:00
Sebastian Schmidt 69b17eb4f5 Allow semicolon in file name (#1991) 2018-10-23 16:53:13 -07:00
Paul Beusterien 76a51a5a9e Increase timeout for testDispatchAfterDelay (#1988) 2018-10-23 12:28:18 -07:00
Sebastian Schmidt b192fd7c77 Queue Storage Tasks on separate queue (#1981) 2018-10-23 12:15:11 -07:00
Ryan Wilson 8de5cb2834 Wrap diagnostics notification in collection flag check. (#1979)
* Wrap diagnostics notification in collection flag check.

Some of the diagnostics notifications were missed and not covered by
the data collection flag.

* Remove redundant notification call, move Core diagnostics API call.

* Removed configure with no options test.
2018-10-23 13:29:13 -04:00
Paul Beusterien 8680441341 Remove cruft from project file (#1975) 2018-10-21 15:14:45 -07:00
Paul Beusterien dceda76446 Remove unnecessary OCMock Podfile dependencies (#1969) 2018-10-19 10:06:20 -07:00
Ryan Wilson 9fe54ed34b Update versions for Release 5.11.0 2018-10-17 11:25:40 -04:00
Mandar 0e16e6c863 Fix style. Run ./scripts/style.sh 2018-10-16 16:24:01 -07:00
Mandar 86561307cb Merge remote-tracking branch 'firebaseprivate/dl-custom-domains' into md-fdl 2018-10-16 15:31:26 -07:00
Raman Yankouski 86be7764c9 Always use 24-hours locale (#1947)
* Always use 24-hours locale
* use en_US_POSIX instead of en_GB
* Update NSDateFormatter locale for messaging tests
2018-10-16 12:14:24 -07:00
Mandar 5e33153f70 Allow for custom domains in the FDL iOS SDK
Allow for custo domains to be whitelisted by the info.plist file.
2018-10-15 00:56:27 -07:00
Paul Beusterien 81fb6a03ef Remove need for [FIRApp configure] in Messaging unit tests (#1927)
* Remove need for [FIRApp configure] in Messaging unit tests
* Add missing file to test target
2018-10-10 15:24:04 -07:00
Paul Beusterien 467354a58f Do Messaging's Analytics logging via Interop (#1902) 2018-10-09 16:34:06 -07:00
David Airapetyan ec18195e9e Update versions for Release 5.10.0 2018-10-03 14:22:54 -04:00
Chen Liang 845a25e65b Fix the issue that when topic is invalid, the callback was not triggered. (#1880) 2018-09-28 10:27:05 -07:00
Chuan Ren e4e9335de2 UnlinkFromFacebook and UnlinkFromEmailPassword both accidentally call to unlink from Google (#1883) 2018-09-26 20:49:04 -07:00
Chen Liang 4736e056ef Add a boolean value on whether to use direct channel callback for all ios versions (#1875) 2018-09-26 13:16:07 -07:00
Paul Beusterien 199d41dc1b Merge pull request #1876 from firebase/release-5.9.0
Release 5.9.0
2018-09-25 14:01:55 -07:00
Chuan Ren 14683d03e7 Auth sample app update (#1860) 2018-09-20 20:57:10 -07:00
Paul Beusterien b98c5ab5cd Update versions for Release 5.9.0 2018-09-19 15:40:40 -07:00
Paul Beusterien e2cae239bc Remove testing workaround (#1848)
* Turn off -all_load to workaround Analytics duplicate symbol bug b/116139404
2018-09-19 15:25:24 -07:00