Commit Graph
52 Commits
Author SHA1 Message Date
Ryan Wilson 4c50de65d4 Reduce singleton usage in FIRApp tests. (#1995)
* Reduce singleton usage in FIRApp tests.

There have been some issues while creating new tests of conflicts with
mocks of classes and instances, this should alleviate some of those
conflicts in the future.

* Remove bad style changes.

* Use default app name flag instead of local variable.
2018-10-24 11:03:54 -04:00
Ryan Wilson ef5949d6a8 Remove unnecessary notification flag (#1993)
* Remove unnecessary notification flag.

This was added when the Google pod could configure Firebase but the
Google pod is deprecated and can only work with Firebase 3.X. These
flags and conditional checks can be safely removed.

* Resolve issues from commit split.

* Style fixes.
2018-10-24 07:17:12 -04:00
Ryan Wilson 8de5cb2834 Wrap diagnostics notification in collection flag check. (#1979)
* Wrap diagnostics notification in collection flag check.

Some of the diagnostics notifications were missed and not covered by
the data collection flag.

* Remove redundant notification call, move Core diagnostics API call.

* Removed configure with no options test.
2018-10-23 13:29:13 -04:00
Michael Lehenbauer b88f95c44f Reformat using 'clang-format version 7.0.0 (tags/google/stable/2018-04-24)' (#1681)
This is the version of clang-format that travis is currently using.
2018-08-13 14:18:02 -07:00
Paul Beusterien 9a2aa9fbcc Fix FIRLogger initialization after GULLogger (#1592)
* Migrate of kFIRPersistedDebugModeKey
2018-07-26 09:45:44 -07:00
Ryan Wilson 1d484d33a7 Rename global data collection switch. (#1560) 2018-07-23 10:34:16 -07:00
Paul Beusterien c586dc8747 Separate Xcode project and tests for GoogleUtilities (#1521) 2018-07-12 12:03:50 -07:00
Ryan Wilson 79f663d5ea Add Auth interoperability library. (#1501)
* Add Auth interoperability library.

This allows other SDKs to retrieve the user ID and fetch a new
Auth token in a type-safe way through the Core container.

* Remove unnecessary import.

* Add missing copyright.

* Resolve comments.

- Remove unnecessary umbrella header.
- Move to version 1.0.
- Add tvOS support for app lifecycle changes.

* Move public interop headers to private.

* Add public_header_files too.

* Moved headers back into public.

* Shorten Interoperability and Interoperable to Interop.

* Add AuthInterop to travis linting.

* Fixed tag format in AuthInterop.podspec.

* Add AuthInterop path to Firestore Podfile.
2018-07-11 17:40:25 -04:00
Paul Beusterien 98b6eef71e Split GoogleUtilities from FirebaseCore (#1370) 2018-07-06 09:37:23 -07:00
Ryan Wilson 2f6bf8d669 Add FirebaseCore component interoperability. (#1437)
* Add FirebaseCore component interoperability.

This puts in place the system that will allow SDKs to register with
Core and retrieve functionalities provided by other SDKs.

* Updated documentation.

* Add copywrite, fix log messages.

* Explicitly import headers from Private dir
2018-06-28 13:48:13 -04:00
Ryan Wilson 8d399c78bd Better mocking for Core Unit Tests (#1467)
* Better mocking for Core Unit Tests

This includes NSNotificationCenter and NSUserDefaults to prevent
flaky tests and unit tests interfering with each other.

* Share variable for intervals being set.
2018-06-27 06:42:09 -07:00
Ryan Wilson 5de20858e4 Remove unused static logging variable. (#1405)
* Remove unused static variable.

This was previously used in an iOS 7 comparison that was removed in
Firebase version 5.0.0.

* Remove unused test variable.
2018-06-13 07:56:28 -07:00
Ryan Wilson fe31c8a039 Add public FIRAnalyticsConfiguration tests. (#1361) 2018-05-30 22:25:57 -04:00
Ryan Wilson 503d2debdd Add conformance to data collection switch for Analytics. (#1296)
* Add conformance to data collection switch for Analytics.

* Fix method documentation per PR comments.
2018-05-21 21:49:57 -04:00
Paul Beusterien 959dd259c1 Test Core's build version matches FIROption version (#1279) 2018-05-15 06:39:48 -07:00
Ryan Wilson 08f447cd3f Add global data collection switch. (#1219)
* Addition of global data collection switch.
* Added Messaging conformance to data switch.
  Also formatted code.
* Move data collection flag internal until all SDKs conform to it.
* Formatting in response to code review.
2018-05-14 10:02:25 -07:00
Ryan Wilson af4bf66cfe Add MLKit to FIRLogger constants. (#1263) 2018-05-11 11:28:30 -07:00
Ryan Wilson 421cd3c248 Remove logging count for this release. (#1201) 2018-05-01 06:42:57 -07:00
Ryan Wilson 260557691f Add counter for errors and warnings logged. (#1168)
* Moved writes outside of dispatch_async block.
2018-04-25 06:45:36 -07:00
Benoit St-Pierre 9eea8d4fc4 Add unit tests for FirebaseCore (#751)
* Add unit tests for FIRMutableDictionary

Basic unit tests to increase overall code coverage.

* Add unit tests for FIRReachabilityChecker

Basic unit tests to increase overall test coverage.

* Add unit tests for FIRNetwork

Basic unit tests to increase overall test coverage.

This also includes a mock HTTP server to serve mock network responses
through the network stack.

* Remove +internal from imports

This was unnecessary.

* Move Example/Tests/Core/Utils files to Example/Tests/Core

This simplifies build files to include the correct dependencies

I had also missed some tvOS test fixes.

* PR Feedback

Fixed some style issues and updated GTMHTTPServer comments.

* Moved GTMHTTPServer.h into third_party directory

* Revert Firebase Xcode project for merging.

* Add tests to project file.
2018-04-19 15:56:11 -04:00
Ryan Wilson 7f0b04afa2 Fix version number reporting for minor versions. (#1124)
* Fix version number reporting for minor versions.

* run clang-format

* Updated the comment in systemVersion.
2018-04-17 11:08:30 -04:00
Ryan Wilson ad321bb279 Match previous systemVersion functionality (#1120)
* Match previous systemVersion functionality

* style.sh

* Add new test file to test targets
2018-04-16 19:29:53 -04:00
Ryan Wilson 23742e8159 Merge pull request #1050 from firebase/core-breaking-changes
Core Breaking API Changes
2018-04-10 13:34:13 -04:00
Paul Beusterien 10105d83c9 Enable Core Unit Tests to run in a Release config (#1064) 2018-04-10 09:00:38 -07:00
Ryan Wilson 7f8a5ef1e5 Actually fixed the tests this time. (#796) 2018-04-09 12:16:57 -04:00
Ryan Wilson 5bf3a6abdb Fixed Core test's missing constant. (#795) 2018-04-09 12:16:57 -04:00
Ryan Wilson b8fdf48833 Remove old FIROptions constructor. (#615) 2018-04-09 12:16:57 -04:00
Benoit St-Pierre e281a2135b Deflake tests 2018-02-26 14:40:00 -05:00
Benoit St-Pierre 6f5eebb77f PR feedback 2018-02-26 13:58:28 -05:00
Benoit St-Pierre 34dd1dbfd9 Add tests for useragent
Tests a variety of simple use cases.
2018-02-26 13:25:26 -05:00
Benoit St-Pierre ac33d9b3f1 Revert "Move -messageWasLogged to FIRTestCase"
This reverts commit dfda142503.
2018-02-26 13:21:08 -05:00
Benoit St-Pierre dfda142503 Move -messageWasLogged to FIRTestCase
This makes it accessible to other test classes.
2018-02-26 11:22:38 -05:00
Ryan Wilson e4be2548b5 Fixed capitalization of init in test function. (#797) 2018-02-14 12:46:50 -05:00
Paul Beusterien 6a6e14822f Fix build warnings by making void parameter explicit (#681) 2018-01-19 07:45:31 -08:00
Ryan Wilson 2c0cacd3ee Inject infoDictionary to fix flakey tests. (#664)
* Inject infoDictionary to fix flakey tests.

* Remove outdated comment, update format.
2018-01-15 08:46:22 -05:00
davidair a84704f65b Removing an obsolete setting from plist files (#617)
* Removing an obsolete setting from plist files

* Fixing Unit Tests

* Fixing nullability
2018-01-08 10:41:25 -05:00
Paul Beusterien f08b5044d6 Add Community Supported tvOS (#590)
Add Community Supported tvOS for Core, Auth, Database and Storage.
Add tvOS unit tests
Add tvOS sample app
Update README.md
Add tvOS to travis testing
2018-01-03 12:12:22 -08:00
Sebastian Schmidt 03ab86499f Running scripts/style.sh 2017-12-10 22:58:23 -08:00
Paul Beusterien 3418244cd5 Disable FirebaseCore Test deprecation warnings (#545) 2017-12-08 07:31:31 -08:00
Paul Beusterien 73869c741f Fix warnings in FirebaseCore Unit Tests (#544) 2017-12-07 14:30:46 -08:00
Paul Beusterien da9308408d Use brackets for module imports (#487) 2017-11-22 09:19:10 -08:00
Paul Beusterien 3e592526ec Buildable and interoperable source pods (#444) 2017-11-21 17:02:22 -08:00
Marek Gilbert 360f7bed25 Result of clang-format with AllowShortFunctionsOnASingleLine: None 2017-08-02 11:07:57 -07:00
Marek Gilbert e4af03818c Formatting updates based on the latest clang-format
clang-format version 5.0.0 (tags/google/stable/2017-06-22)
2017-08-02 09:52:48 -07:00
Paul Beusterien 0abd344434 Add clang-format options and script; apply to FirebaseCore (#151) 2017-07-27 11:02:39 -07:00
davidair f7fc2bb573 Moving sMessageCodeRegex initialization into #ifdef DEBUG to remove the init cost, adding [FIRApp configure] to the Core example (#150) 2017-07-25 11:28:17 -04:00
Ryan Wilson 11d004105e Add method to check if defaultApp is configured. (#139)
This lets other SDKs check if the default `FIRApp` is set up without
accessing it, which causes unnecessary log messages to appear.
2017-07-17 14:31:01 -04:00
Paul Beusterien 053b2f11ea Use modulemap to fix exposure of FirebaseCore's internal headers (#121) 2017-07-10 14:57:03 -07:00
davidair bf5ef4be6d Removing a backspace character (#132) 2017-07-10 15:09:09 -04:00
Paul Beusterien 9792bec7e3 Disable failing FIRLogger test until Issue 128 is fixed (#129) 2017-07-10 08:51:26 -07:00