Commit Graph
63 Commits
Author SHA1 Message Date
Seyed Mojtaba Hosseini Zeidabadi 48fce71b15 Fix all typos found in the FirebaseDynamicLinks/Sources directory (#13350) 2024-07-23 06:59:55 -07:00
Paul Beusterien 79866caa23 Fix typos (#13312) 2024-07-18 15:05:15 -07:00
Paul Beusterien f5309bf45b [v11] Remove unused FIRDependency class (#13053) 2024-06-04 06:56:50 -07:00
Yakov Manshin 7434377e3b Removed Unused Availability Checks (#13023) 2024-05-28 09:20:31 -07:00
Paul Beusterien cd4ed3f52f Deprecation warning for FDL (#12999) 2024-05-20 15:23:13 -07:00
Takumi Muraishi ffedaed448 Fix typos (#12783) 2024-04-13 13:34:36 -07:00
Paul BeusterienandNick Cooke 3539c2b691 Privacy Manifests for named Firebase SDKs (#12407)
Co-authored-by: Nick Cooke <nickcooke@google.com>
2024-02-23 15:08:29 -08:00
Eldhose M Babu 171f0209b5 Refactoring method names. (#11680) 2023-08-18 10:33:58 -07:00
Nick Cooke 7453895034 [Dynamic Links] Address Xcode 14.3 Analyzer issues (#11243) 2023-05-08 11:44:48 -04:00
Cristian E. AvalosandCristian Avalos 84e862e5f9 Fdl/removes nsnull values (#10498)
* removes NSNull

* fixes clang-format errors

* updates on CHANGELOG

* fixes lint

Co-authored-by: Cristian Avalos <ceavalos@google.com>
2022-11-17 13:50:15 -08:00
Cristian E. AvalosandCristian Avalos 6dfadd235a Fdl/fixes issues parsing utm parameters from universal links (#10413)
* updates changelog

* updates code to fix missing utm parameters

* fixes missing utm_term and utm_content

* fixes unit tests

* fixes changelog

* fixes clang-format issues

* updates changelog

Co-authored-by: Cristian Avalos <ceavalos@google.com>
2022-11-01 20:08:35 -07:00
Cristian E. AvalosandCristian Avalos 952df9b3e6 removes confusing comment (#10300)
Co-authored-by: Cristian Avalos <ceavalos@google.com>
2022-10-04 16:39:36 -07:00
Eldhose M Babu a97a5be287 App google domain support (#10249)
Adding new 1p domain "app.google" support in FDL SDK.
2022-09-22 14:05:21 -07:00
Andrew Heard 5d7d52c3b4 FDL: Mark FIRDynamicLink's init as NS_UNAVAILABLE (#10236)
DynamicLink's bare initializer was not intended to be publicly available. Marking it as NS_UNAVAILABLE hides it from both ObjC and Swift callers; resolves #10000.
2022-09-20 18:20:21 -04:00
Paul Beusterien a7ab2ca184 the the typos (#9726) 2022-04-28 10:06:21 -07:00
Paul Beusterien 3ef42c1ac4 Address v9, resolved, and obsolete TODO's (#9659) 2022-04-15 08:14:44 -07:00
Eldhose M Babu c251012fdb Fdl async await crash fix (#9637)
* Crash Fix: Async/await violation for Dynamic Links (#9612)
2022-04-12 12:11:27 -07:00
Paul Beusterien 7b946765ec Remove slashes from log messages (#9391) 2022-04-06 14:19:47 -07:00
Paul Beusterien 99275370a2 Merge remote-tracking branch 'origin/master' into v9b 2022-04-06 09:56:33 -07:00
Eldhose M Babu c1a33a099d Fdl unit tests (#9516)
Refactoring custom domain validation logic with fixes and adding new unit tests.
2022-03-29 11:09:49 -07:00
Nick Cooke a09083f9d0 [v9] Reorganize FirebaseCore* modules (#9482)
* [skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`

* Reorganize FirebaseCore libraries for SPM and CP

* [skip ci] Revert "[skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`"

This reverts commit 2a837e39708c21b0a324743ab226bd6c01047de7.

* Review and fix CI

* Remove `heartbeat_logging.yml` and add `core_internal.yml`

* Remove trailing whitespace

* Fix more whitespace 😞

* Fix `core_internal.yml` scheme name

* Update `check_imports.swift` and TODO

* Review

* Add FirebaseCoreInternal pod to Firestore example's Podfile

* [skip ci] Review - remove TODOs

* [skip ci] Remove duplicate `XCTest` import
2022-03-23 06:08:14 -07:00
Ryan Wilson e002709d2c Mark ObjC typedefs as unavailable in Swift. (#9387)
* Mark ObjC typedefs as unavailable in Swift.

This is part of the larger Swift API improvements effort. These reduce
visibility in autocomplete, and we've mostly migrated away from them
already. This hides the unused type from the API surface to avoid
cluttering the list of types avialable.

* Revert FDL Test

* Fix CombineSwift tests

* Fixed Firestore tests

* Revert unneeded changes for FDL internal headers.
2022-03-23 06:08:14 -07:00
Paul Beusterien 4f793064da Set up Core Internal for SPM (#9298) 2022-03-23 06:07:17 -07:00
Eldhose M Babu 276e35f17f Fixing the short url logic (#9005)
* Adding back the missed regex check for short links and correcting the test cases.
2021-11-29 12:44:29 -08:00
Eldhose M Babu cdb57e1142 Regex change to accept link query param anywhere in FDL after the FDL domain prefix (#8866) 2021-10-26 12:12:42 -07:00
Nick Cooke 97aff9edf5 [Dynamic Links] Reduce memory stress on WebKit API (#8847) 2021-10-21 14:10:38 -07:00
Eldhose M Babu 9b194b86fe Test handle universal link (#8793)
* Adding support for '-'  and '_' in regex validation

* Adding new unit test to check handleUniversalLink:url to return YES for valid DDL
2021-10-13 13:06:27 -07:00
Paul Beusterien a550e68ca8 Fix device-only build warning (#8696) 2021-09-23 07:46:11 -07:00
Eldhose M Babu 85864c689f [FDL] Refactoring and fixing url validation (#8672)
[FDL] Refactoring and fixing url validation

Refactored the existing code to use Regex to validate FDL URL formats.

Added checks to make sure the 'link' query param is having an http/https prefix input.
== This is going to be breaking the existing SDK's unintended behavior to support links with non http/https content. The existing SDK was constructing the Dynamic link even though the backend response to resolve the link is not successful.

Added support for URL(s) with Query string starting with '?' alone. Previously it was supporting '/?' formats only. This fixes 177469304: Firebase dynamic links with custom domain will only work if the custom domain has a trailing '/' #7087

Added more test cases to be in sync with FDL backend validation.

Removed invalid test inputs and corrected few test cases to make the input in proper format.
2021-09-22 14:21:39 -07:00
Eldhose M Babu af230bd4f1 Refactoring device heuristics collection to a helper class. (#8432)
* Refactoring device heuristics collection to a helper class.
2021-08-06 13:13:15 -07:00
Morgan Chen 98a3baf0d6 Move Dynamic Links to API_UNAVAILABLE (#8467)
* Move Dynamic Links to API_UNAVAILABLE

* Add changelog
2021-07-30 12:41:05 -07:00
Paul Beusterien c0df01d5f0 Fix Xcode 13 beta 3 build issues (#8405) 2021-07-19 07:18:36 -07:00
Paul Beusterien c5541b7803 Better analyze fix (#8287) 2021-06-23 11:30:00 -07:00
Paul Beusterien 7dcf7e7be9 Fixed analyze issue introduced in Xcode 12.5 (#8208) 2021-06-08 10:06:36 -04:00
Nick Cooke 8be7fa5996 DynamicLinks: Skip retrieving web locale when running targeting below iOS14 (only on simulator & Apple Silicon) (#7989)
* Conditionally make WebKit allocations

* Clean up approach

* Style

* Still call delegate method

* Make C function static

* Updated CHANGELOG
2021-04-27 20:55:37 -04:00
Eldhose M Babu 9efc2bebf5 Adding "utmParametersDictionary" api to FIRDynamicLink (#7505)
Adding "utmParametersDictionary" api to FIRDynamicLink.

This new property will enable 3p developers to fetch the Utm parameters associated with a Firebase Dynamic Link.

Related Issue: #6730

API Review Doc : https://docs.google.com/document/d/1NDBjiuCQEs3vnaPGfYKK2cdvJMIsJqukRtrZf8wsWCk (Approved)
2021-02-17 17:06:00 -08:00
Paul Beusterien 52ccf01f13 pb-dl-12.5 (#7434) 2021-02-02 18:25:43 -08:00
Paul Beusterien 54d28547d3 Remove GDT from repo (#7384) 2021-01-27 07:51:12 -08:00
Eldhose M Babu a3a68ea025 Rewording "whitelist" in comments and function names. (#7358) 2021-01-22 13:36:59 -08:00
Paul BeusterienandMaksym Malyhin 62735099d5 Callback should be on main thread (#7159)
Co-authored-by: Maksym Malyhin <mmaksym@google.com>
2020-12-14 16:25:25 -08:00
Alexander Perepelitsyn 5035a99113 Manually created dynamic links should be subject to allowed/blocked check (#5853)
* Fix implementation.

Fix unit tests.

Remove duplicate method.

Add comment.

Add unit tests.

Use deprecated annotation.

Fix the comment.

* Make changes additive.

* Address review comments.

* Review changes.

* Check data before serialization.

* Minor fix.

* Post rebase fix.

* Post rebase fix 2.

* Fix styling.

* Fix type.

* Post rebase fix.

* Remove kClientID.

* Code review comment addressed. Get rid of code duplication.
2020-12-07 09:26:52 -08:00
Maksym Malyhin 57123ae0d5 Update clang-format to 11 (#6905)
* Update clang-format to 11

* Upgrade clang format

* Install clang-format@11

* Update readme

* brew update
2020-11-05 12:58:48 -05:00
Eldhose M Babu 594be97236 Adding test to make sure pending dynamic link is getting passed to App delegate method. (#6819)
Adding unit test to make sure the pending dynamic link is getting delivered to specific method in App delegate.
2020-10-26 10:27:38 -07:00
Eldhose M Babu 881ba5d597 Fixed broken callback to AppDelegate (#6800)
Fixed broken callback to AppDelegate after retrieving a dynamic link during fresh app start.
The AppDelegate call was broken in PR : #6517

Reverting to the old implementation of dynamic link passing to App delegate with changes to remove iOS 9 checks.
Using new "openURL" method instead of the deprecated one.
Clean up in the sample app pod file.
2020-10-21 14:53:24 -07:00
Paul Beusterien 31f978eb95 Provide version for FDL 1P builds (#6679) 2020-10-08 07:24:18 -07:00
Paul Beusterien 672256e11e C API for Firebase Version (#6690) 2020-10-07 15:03:20 -07:00
Paul Beusterien 83e898ab5c One Firebase version (#6634) 2020-10-02 12:26:22 -07:00
Paul Beusterien eea957561c Merge remote-tracking branch 'origin/master' into pb-f7-msg-update 2020-09-22 15:46:23 -07:00
Paul Beusterien a39b515f3a Update podspecs to min iOS 10 (#6517) 2020-09-22 15:11:35 -07:00
Andrzej Hunt b89529ac1e Add IWYU pragma to FIRDynamicLinks+FirstParty/FIRDynamicLinks (#6508)
Most FirstParty users will still need to use methods from FIRDynamicLinks.h
(shouldHandleDynamicLinkFromCustomSchemeURL:/dynamicLinkFromCustomSchemeURL: etc.).
Arguably, including both headers looks odd, hence add the IWYU pragma so that it's sufficient
to only use the FirstParty header.
2020-09-21 07:52:51 -07:00