Commit Graph
29 Commits
Author SHA1 Message Date
Paul Beusterien f5309bf45b [v11] Remove unused FIRDependency class (#13053) 2024-06-04 06:56:50 -07:00
Takumi Muraishi ffedaed448 Fix typos (#12783) 2024-04-13 13:34:36 -07:00
Eldhose M Babu 171f0209b5 Refactoring method names. (#11680) 2023-08-18 10:33:58 -07:00
Cristian E. AvalosandCristian Avalos 84e862e5f9 Fdl/removes nsnull values (#10498)
* removes NSNull

* fixes clang-format errors

* updates on CHANGELOG

* fixes lint

Co-authored-by: Cristian Avalos <ceavalos@google.com>
2022-11-17 13:50:15 -08:00
Cristian E. AvalosandCristian Avalos 6dfadd235a Fdl/fixes issues parsing utm parameters from universal links (#10413)
* updates changelog

* updates code to fix missing utm parameters

* fixes missing utm_term and utm_content

* fixes unit tests

* fixes changelog

* fixes clang-format issues

* updates changelog

Co-authored-by: Cristian Avalos <ceavalos@google.com>
2022-11-01 20:08:35 -07:00
Cristian E. AvalosandCristian Avalos 952df9b3e6 removes confusing comment (#10300)
Co-authored-by: Cristian Avalos <ceavalos@google.com>
2022-10-04 16:39:36 -07:00
Andrew Heard 5d7d52c3b4 FDL: Mark FIRDynamicLink's init as NS_UNAVAILABLE (#10236)
DynamicLink's bare initializer was not intended to be publicly available. Marking it as NS_UNAVAILABLE hides it from both ObjC and Swift callers; resolves #10000.
2022-09-20 18:20:21 -04:00
Paul Beusterien 3ef42c1ac4 Address v9, resolved, and obsolete TODO's (#9659) 2022-04-15 08:14:44 -07:00
Eldhose M Babu c251012fdb Fdl async await crash fix (#9637)
* Crash Fix: Async/await violation for Dynamic Links (#9612)
2022-04-12 12:11:27 -07:00
Nick Cooke a09083f9d0 [v9] Reorganize FirebaseCore* modules (#9482)
* [skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`

* Reorganize FirebaseCore libraries for SPM and CP

* [skip ci] Revert "[skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`"

This reverts commit 2a837e39708c21b0a324743ab226bd6c01047de7.

* Review and fix CI

* Remove `heartbeat_logging.yml` and add `core_internal.yml`

* Remove trailing whitespace

* Fix more whitespace 😞

* Fix `core_internal.yml` scheme name

* Update `check_imports.swift` and TODO

* Review

* Add FirebaseCoreInternal pod to Firestore example's Podfile

* [skip ci] Review - remove TODOs

* [skip ci] Remove duplicate `XCTest` import
2022-03-23 06:08:14 -07:00
Paul Beusterien 4f793064da Set up Core Internal for SPM (#9298) 2022-03-23 06:07:17 -07:00
Eldhose M Babu a3a68ea025 Rewording "whitelist" in comments and function names. (#7358) 2021-01-22 13:36:59 -08:00
Paul BeusterienandMaksym Malyhin 62735099d5 Callback should be on main thread (#7159)
Co-authored-by: Maksym Malyhin <mmaksym@google.com>
2020-12-14 16:25:25 -08:00
Alexander Perepelitsyn 5035a99113 Manually created dynamic links should be subject to allowed/blocked check (#5853)
* Fix implementation.

Fix unit tests.

Remove duplicate method.

Add comment.

Add unit tests.

Use deprecated annotation.

Fix the comment.

* Make changes additive.

* Address review comments.

* Review changes.

* Check data before serialization.

* Minor fix.

* Post rebase fix.

* Post rebase fix 2.

* Fix styling.

* Fix type.

* Post rebase fix.

* Remove kClientID.

* Code review comment addressed. Get rid of code duplication.
2020-12-07 09:26:52 -08:00
Eldhose M Babu 594be97236 Adding test to make sure pending dynamic link is getting passed to App delegate method. (#6819)
Adding unit test to make sure the pending dynamic link is getting delivered to specific method in App delegate.
2020-10-26 10:27:38 -07:00
Eldhose M Babu 881ba5d597 Fixed broken callback to AppDelegate (#6800)
Fixed broken callback to AppDelegate after retrieving a dynamic link during fresh app start.
The AppDelegate call was broken in PR : #6517

Reverting to the old implementation of dynamic link passing to App delegate with changes to remove iOS 9 checks.
Using new "openURL" method instead of the deprecated one.
Clean up in the sample app pod file.
2020-10-21 14:53:24 -07:00
Paul Beusterien 31f978eb95 Provide version for FDL 1P builds (#6679) 2020-10-08 07:24:18 -07:00
Paul Beusterien 672256e11e C API for Firebase Version (#6690) 2020-10-07 15:03:20 -07:00
Paul Beusterien 83e898ab5c One Firebase version (#6634) 2020-10-02 12:26:22 -07:00
Paul Beusterien eea957561c Merge remote-tracking branch 'origin/master' into pb-f7-msg-update 2020-09-22 15:46:23 -07:00
Paul Beusterien a39b515f3a Update podspecs to min iOS 10 (#6517) 2020-09-22 15:11:35 -07:00
Paul Beusterien 0a87c3142e Remove unnecessary Core private headers (#6439) 2020-09-17 15:31:33 -07:00
Eldhose M Babu b40263ae8e Removing client id usage in api call and respective checks (#6396)
Removing client id usage in api call and respective checks

FDL SDK was using client id passed in FIROptions to make API calls. From backend side, we no longer needs client id to be sent. So removing the client id usage in FDL SDK along with parameter no null checks.

-Removed the usage of Client id from FIROptions.
-Removed non null parameter checks for client id.
-Deprecated 1p API method setUpWithLaunchOptions::apiKey:clientID:urlScheme:userDefaults: and added setUpWithLaunchOptions::apiKey:urlScheme:userDefaults:
-Removed Client id usage in Unit tests.
2020-09-09 11:54:20 -07:00
Paul Beusterien e05df895ac SPM - DynamicLinks (#6245) 2020-08-11 07:44:06 -07:00
Eldhose M Babu d5d795c118 Check for Pending Dynamic link guard check logic change (#5993)
Check for pending DL guard check logic change.
2020-08-04 11:31:50 -07:00
Paul Beusterien e15724a436 Migrate from interop pods to source_files header access (#5760) 2020-06-09 06:09:27 -07:00
Paul Beusterien d4621a636f Use preserve_paths instead of CocoaPods private (#5758) 2020-06-09 05:21:28 -07:00
Eldhose M Babu 68b0a239e7 Fixing unwanted pending dynamic links checks on subsequent app restarts (#5665)
* Fix for internal bug b/154589338

Most of the times, when the app is cold started, we are making api calls to:

https://firebasedynamiclinks-ipv4.googleapis.com/v1
https://firebasedynamiclinks-ipv6.googleapis.com/v1

Until we get a successful response. But sometimes, if the device doesn’t have support for v6 endpoint and if the v4 endpoint doesn’t retrieve a valid dynamic link, it will return error. This mostly happens when user directly goes to App Store and installs an app which has fdl sdk integrated.

For dynamic links, we want the app to retrieve the pending dynamic link on the very first start of the app after install so that 3p developers can deeplink to a particular page in the app. If the pending links retrieval failed during the first start, there is no point in retrying the retrieval during next restart since it could result in an un expected  deep link for the user when they opens up the app for subsequent restarts (if a valid dynamic link is returned).
2020-05-29 13:31:25 -07:00
dmandar f5062d861c FDL source, unit tests and app now live in FirebaseDynamicLinks folder. (#4767)
* Move FDL sources to new location.

* Add FDL unit tests.

* Move test app.

* Fix source path.

* Move unit tests path.

* Rename source to sources.

* Change relative path.

* Update podspec.

* Fix header search path.

* Fix relative path for scripts.

* Fix tests.
2020-01-30 11:44:31 -08:00