Commit Graph
66 Commits
Author SHA1 Message Date
Chen Liang c366a4bdf3 fix the typo error that cause bundle identifier checking failed for app extension (#3013) 2019-05-21 12:32:16 -07:00
Paul Beusterien b54bc7a2e9 Add FirebaseCore test_spec (#2943) 2019-05-06 13:54:34 -07:00
Paul Beusterien 79e9fcd5e7 Fix data collection switch unit tests (#2939) 2019-05-06 08:03:00 -07:00
Maksym Malyhin e04b6ba953 FIRApp - validate app name using NSCharacterSet (#2906) 2019-04-26 20:10:20 -04:00
Paul Beusterien 827566cc20 Fix minor typo (#2769) 2019-04-08 17:22:40 -07:00
Paul Beusterien fd6f93d89d Begin migrating FIRLoggerService declarations to clients (#2720) 2019-04-08 08:54:21 -07:00
Paul Beusterien 76a003f4c8 Clean up unused Core error codes (#2737)
* Core patches can only be 2 digits
2019-04-08 06:58:49 -07:00
Paul Beusterien 6f040b31ae Stop requiring multiple Core version updates (#2745) 2019-04-07 19:56:18 -07:00
Ryan Wilson 626bfb513c Remove FIRAnalyticsConfiguration from Public header. (#2728)
* Remove FIRAnalyticsConfiguration from Public header.

We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.

* Fixed incomplete comment.

* Remove self importing header.
2019-04-07 22:49:54 -04:00
Paul Beusterien 1a32a1f7d3 Delete references to deprecated Crash and Invites (#2668) 2019-04-01 19:06:05 -07:00
Maksym Malyhin 2ac4f6d4bc Avoid using NSRegularExpression in FIRApp (b/65122393) (#2529) 2019-03-15 11:38:48 -04:00
Paul Beusterien 9502e8dda1 Restore GoogleUtilities 5.3.7 - revert os_log changes (#2556) 2019-03-14 13:01:41 -07:00
Maksym Malyhin e53d552d5e Allow Bundle IDs that have a valid prefix - strict validation (#2515)
Allow Bundle IDs that have a valid prefix - strict validation
2019-03-11 21:33:07 -04:00
Benoit St-Pierre 6b026aac76 os_log Implementation of GULLogger (#2374)
* Step 1: Duplicate ASL Logger

This copies over the ASL logging system to a standalone Objective-C class.

* Step 2: Replace Logger with ObjC Implementation

This also moved the `forcedDebug` information to a property.

* Step 3: Remove unnecessary test methods

It does not seem necessary to drain the queue. If this is an issue on a platform I didn't test, we should implement the tests differently, such that surfacing the queue is not necessary.

* Style Fixes

* Test cleanup

* Removed FIRLoggerTest as they mostly actually test `GULASLLogger` functionality now.
* Renamed `GULLoggerInitializeASL` to `GULLoggerInitialize`.
* Use dot-notation for the defaultLogger class property.
* Removed unused debug only test methods.

* Rename FIRLoggerInitializeASL

* Style fixes

* ASL Logger cleanup and leaking

* Move ivar synthesis to the top of the implementation.
* Add dealloc logic to avoid leaking asl_obj memory.
* Add forced logic at the message level.

* GULLogger Testing

* Moved over old tests to correct ASLLogger location.
* Added new GULLogger tests
* Changed version `char *` to `NSString *`
* Tidied up some documentation

* Re-introduce ASL in the functions names

* os_log GULLogger Implementation

* Moved common logic from `GULASLLogger` to `GULLogger+Internal` class methods.
* Added `os_log` implementation of `GULLoggerSystem`
* Added `os_log` level information to `GULLoggerLevel`
* Removed unused test variable

TODO: Tests

* Remove iOS version check from ASLLogger

* Style Fixes

* Refer to ivar directly in property setter

* Refer to ivar directly in property setter

* Being os_log tests

* Setup dependency injection for os_log tests

* Rename C functions according to style and correctly test macOS version compatibility

* Further refinement of os_log testing

* Add Some OSLogger tests and update some ASLLogger ones

* Re-add getter for logLevel

* Fix up some warnings

* Remove private headers from local testing podspec

* More OSLogger tests & bug fixes

* Style Fixes

* Fix Travis build

* Update GULOSLoggerTest.m

* Do nt override method argument

* Fix test on tvOS

* Test Fixes

* Copybara test fixes

* PR Feedback
2019-02-22 16:32:57 -05:00
Paul Beusterien 7c53489e03 Travis to Xcode 10.1 and clang-format to 8.0.0 (tags/google/stable/2018-08-24) (#2222)
* Travis to Xcode 10.1
* Update to clang-format 8
* Update clang-format homebrew link
* Work around space in filename style.sh issue
2019-01-02 09:27:31 -08:00
Paul Beusterien 943141e0cd Use registerLibrary for pods in Firebase workspace (#2137)
* Add versioning to Functions and convert to FIRLibrary
* Convert Firestore to FIRLibrary
* Point travis to FirebaseCore pre-release for its deps
* Update user agent strings to match spec
2018-12-13 08:36:08 -08:00
Benoit St-Pierre bc0855048a Clean up FIRAuth bits from FIRApp (#2110)
* Clean up FIRAuth bits from FIRApp
2018-12-07 09:31:10 -05:00
Ryan Wilson 4c50de65d4 Reduce singleton usage in FIRApp tests. (#1995)
* Reduce singleton usage in FIRApp tests.

There have been some issues while creating new tests of conflicts with
mocks of classes and instances, this should alleviate some of those
conflicts in the future.

* Remove bad style changes.

* Use default app name flag instead of local variable.
2018-10-24 11:03:54 -04:00
Ryan Wilson ef5949d6a8 Remove unnecessary notification flag (#1993)
* Remove unnecessary notification flag.

This was added when the Google pod could configure Firebase but the
Google pod is deprecated and can only work with Firebase 3.X. These
flags and conditional checks can be safely removed.

* Resolve issues from commit split.

* Style fixes.
2018-10-24 07:17:12 -04:00
Ryan Wilson 8de5cb2834 Wrap diagnostics notification in collection flag check. (#1979)
* Wrap diagnostics notification in collection flag check.

Some of the diagnostics notifications were missed and not covered by
the data collection flag.

* Remove redundant notification call, move Core diagnostics API call.

* Removed configure with no options test.
2018-10-23 13:29:13 -04:00
Michael Lehenbauer b88f95c44f Reformat using 'clang-format version 7.0.0 (tags/google/stable/2018-04-24)' (#1681)
This is the version of clang-format that travis is currently using.
2018-08-13 14:18:02 -07:00
Paul Beusterien 9a2aa9fbcc Fix FIRLogger initialization after GULLogger (#1592)
* Migrate of kFIRPersistedDebugModeKey
2018-07-26 09:45:44 -07:00
Ryan Wilson 1d484d33a7 Rename global data collection switch. (#1560) 2018-07-23 10:34:16 -07:00
Paul Beusterien c586dc8747 Separate Xcode project and tests for GoogleUtilities (#1521) 2018-07-12 12:03:50 -07:00
Ryan Wilson 79f663d5ea Add Auth interoperability library. (#1501)
* Add Auth interoperability library.

This allows other SDKs to retrieve the user ID and fetch a new
Auth token in a type-safe way through the Core container.

* Remove unnecessary import.

* Add missing copyright.

* Resolve comments.

- Remove unnecessary umbrella header.
- Move to version 1.0.
- Add tvOS support for app lifecycle changes.

* Move public interop headers to private.

* Add public_header_files too.

* Moved headers back into public.

* Shorten Interoperability and Interoperable to Interop.

* Add AuthInterop to travis linting.

* Fixed tag format in AuthInterop.podspec.

* Add AuthInterop path to Firestore Podfile.
2018-07-11 17:40:25 -04:00
Paul Beusterien 98b6eef71e Split GoogleUtilities from FirebaseCore (#1370) 2018-07-06 09:37:23 -07:00
Ryan Wilson 2f6bf8d669 Add FirebaseCore component interoperability. (#1437)
* Add FirebaseCore component interoperability.

This puts in place the system that will allow SDKs to register with
Core and retrieve functionalities provided by other SDKs.

* Updated documentation.

* Add copywrite, fix log messages.

* Explicitly import headers from Private dir
2018-06-28 13:48:13 -04:00
Ryan Wilson 8d399c78bd Better mocking for Core Unit Tests (#1467)
* Better mocking for Core Unit Tests

This includes NSNotificationCenter and NSUserDefaults to prevent
flaky tests and unit tests interfering with each other.

* Share variable for intervals being set.
2018-06-27 06:42:09 -07:00
Ryan Wilson 5de20858e4 Remove unused static logging variable. (#1405)
* Remove unused static variable.

This was previously used in an iOS 7 comparison that was removed in
Firebase version 5.0.0.

* Remove unused test variable.
2018-06-13 07:56:28 -07:00
Ryan Wilson fe31c8a039 Add public FIRAnalyticsConfiguration tests. (#1361) 2018-05-30 22:25:57 -04:00
Ryan Wilson 503d2debdd Add conformance to data collection switch for Analytics. (#1296)
* Add conformance to data collection switch for Analytics.

* Fix method documentation per PR comments.
2018-05-21 21:49:57 -04:00
Paul Beusterien 959dd259c1 Test Core's build version matches FIROption version (#1279) 2018-05-15 06:39:48 -07:00
Ryan Wilson 08f447cd3f Add global data collection switch. (#1219)
* Addition of global data collection switch.
* Added Messaging conformance to data switch.
  Also formatted code.
* Move data collection flag internal until all SDKs conform to it.
* Formatting in response to code review.
2018-05-14 10:02:25 -07:00
Ryan Wilson af4bf66cfe Add MLKit to FIRLogger constants. (#1263) 2018-05-11 11:28:30 -07:00
Ryan Wilson 421cd3c248 Remove logging count for this release. (#1201) 2018-05-01 06:42:57 -07:00
Ryan Wilson 260557691f Add counter for errors and warnings logged. (#1168)
* Moved writes outside of dispatch_async block.
2018-04-25 06:45:36 -07:00
Benoit St-Pierre 9eea8d4fc4 Add unit tests for FirebaseCore (#751)
* Add unit tests for FIRMutableDictionary

Basic unit tests to increase overall code coverage.

* Add unit tests for FIRReachabilityChecker

Basic unit tests to increase overall test coverage.

* Add unit tests for FIRNetwork

Basic unit tests to increase overall test coverage.

This also includes a mock HTTP server to serve mock network responses
through the network stack.

* Remove +internal from imports

This was unnecessary.

* Move Example/Tests/Core/Utils files to Example/Tests/Core

This simplifies build files to include the correct dependencies

I had also missed some tvOS test fixes.

* PR Feedback

Fixed some style issues and updated GTMHTTPServer comments.

* Moved GTMHTTPServer.h into third_party directory

* Revert Firebase Xcode project for merging.

* Add tests to project file.
2018-04-19 15:56:11 -04:00
Ryan Wilson 7f0b04afa2 Fix version number reporting for minor versions. (#1124)
* Fix version number reporting for minor versions.

* run clang-format

* Updated the comment in systemVersion.
2018-04-17 11:08:30 -04:00
Ryan Wilson ad321bb279 Match previous systemVersion functionality (#1120)
* Match previous systemVersion functionality

* style.sh

* Add new test file to test targets
2018-04-16 19:29:53 -04:00
Ryan Wilson 23742e8159 Merge pull request #1050 from firebase/core-breaking-changes
Core Breaking API Changes
2018-04-10 13:34:13 -04:00
Paul Beusterien 10105d83c9 Enable Core Unit Tests to run in a Release config (#1064) 2018-04-10 09:00:38 -07:00
Ryan Wilson 7f8a5ef1e5 Actually fixed the tests this time. (#796) 2018-04-09 12:16:57 -04:00
Ryan Wilson 5bf3a6abdb Fixed Core test's missing constant. (#795) 2018-04-09 12:16:57 -04:00
Ryan Wilson b8fdf48833 Remove old FIROptions constructor. (#615) 2018-04-09 12:16:57 -04:00
Benoit St-Pierre e281a2135b Deflake tests 2018-02-26 14:40:00 -05:00
Benoit St-Pierre 6f5eebb77f PR feedback 2018-02-26 13:58:28 -05:00
Benoit St-Pierre 34dd1dbfd9 Add tests for useragent
Tests a variety of simple use cases.
2018-02-26 13:25:26 -05:00
Benoit St-Pierre ac33d9b3f1 Revert "Move -messageWasLogged to FIRTestCase"
This reverts commit dfda142503.
2018-02-26 13:21:08 -05:00
Benoit St-Pierre dfda142503 Move -messageWasLogged to FIRTestCase
This makes it accessible to other test classes.
2018-02-26 11:22:38 -05:00
Ryan Wilson e4be2548b5 Fixed capitalization of init in test function. (#797) 2018-02-14 12:46:50 -05:00