Commit Graph
6 Commits
Author SHA1 Message Date
Andrew Heard a83297908d [App Check] Implement FirebaseAppCheck as a shim of AppCheckCore (#12067) 2023-11-07 18:54:45 -05:00
Nick Cooke 3d4b0f429e [Heartbeat Logging] Migrate AppCheck from using FIRHeartbeatInfo to FIRHeartbeatLogger (#9530)
* Integrate AppCheck with FIRHeartbeatLogger

* Fix comment typo

* Fix CI

* [will revert] debug why HeartbeatLoggingTestUtils.podspec is linted?

* Revert "[will revert] debug why HeartbeatLoggingTestUtils.podspec is linted?"

This reverts commit 25a79874d8.

* Change visibility of shim class

* Fix CI

* [skip ci] Review
2022-03-30 16:18:41 -04:00
Nick Cooke a09083f9d0 [v9] Reorganize FirebaseCore* modules (#9482)
* [skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`

* Reorganize FirebaseCore libraries for SPM and CP

* [skip ci] Revert "[skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`"

This reverts commit 2a837e39708c21b0a324743ab226bd6c01047de7.

* Review and fix CI

* Remove `heartbeat_logging.yml` and add `core_internal.yml`

* Remove trailing whitespace

* Fix more whitespace 😞

* Fix `core_internal.yml` scheme name

* Update `check_imports.swift` and TODO

* Review

* Add FirebaseCoreInternal pod to Firestore example's Podfile

* [skip ci] Review - remove TODOs

* [skip ci] Remove duplicate `XCTest` import
2022-03-23 06:08:14 -07:00
Paul Beusterien 4f793064da Set up Core Internal for SPM (#9298) 2022-03-23 06:07:17 -07:00
Maksym MalyhinandNick Cooke 302f91e1ed App Check: App Attest provider (#8133)
* App Attest provider: attestation sequence (#7971)

* App Attest provider: attestation sequence (#761)

* App Attest draft WIP

* FIRAppAttestProvider initializers

* ./scripts/style.sh

* FIRAppAttestProvider implementation draft

* Basic FIRAppAttestProviderTests and fixes

* style

* testGetTokenWhenAppAttestIsNotSupported

* More FIRAppAttestProviderTests

* Cleanup

* Remove unused file

* Availability annotations on DCAppAttestService category.

* Guard FIRAppAttestProvider with #if TARGET_OS_IOS

* Formatting

* Fix SPM

* app_check.yaml: Add diagnostics SPM builds

* fix yaml

* Fix Firebase-Package scheme bad merge

* Fix typo

* FIRAppAttestProvider: hide default init

* FIRAppAttestKeyIDStorage: methods placeholders

* Comments

* Fix updated block definition

* Implement app attest key ID storage (#8014)

* Implement FIRAppAttestKeyIDStorage

* Add FIRAppAttestKeyIDStorageTests

* Review [Draft]

* Style

* Docs updates

* Docs updates 2

* Review [Draft] 2

* Improve tests

* Improve test readability

* Improve test readability 2

* App Check App Attest workflow updates: initial handshake (#8032)

* Handshake adjustments (WIP)

* Introduce FIRAppAttestProviderState

* WIP: calculate attestation state

* WIP: calculate attestation state 2

* formatting

* Comments and moving code around

* Fix init in tests

* Fix state calculation flow

* Cleanup state calculation and fix tests.

* Cleanup and fixes.

* Comments

* formatting

* Fix import

* Typo fixes and additional comments

* FIRAppAttestInitialHandshakeResponse API

* Cleanup state calculation using FBLPromiseAwait

* Cleanup

* style

* FIRAppAttestArtifactStorage implementation and tests (#8041)

* Update comments

* FIRAppAttestArtifactStorage implementation and tests

* Fix init

* API docs

* Clean up storage in tests

* Comments

* Disable Keychain dependent tests for SPM

* Implement App Attest `getRandomChallenge` (#8033)

* Initial implementation

* Parse response body for challenge and stub test cases

* Review [Draft]

* Avoid encoding challenge again

* Add tests

* Revert "Avoid encoding challenge again" and add TODO

This reverts commit 69eb00dfe2.

* Document tests; Add test

* Tests: Add URL validation check

* Review

* Define Exchange AppAttest Assertion for FAC token API (#8058)

* App Check App Attest: attestation request (#8059)

* App Attest provider API integration WIP

* update tests

* Draft attestation response parsing

* Attestation request draft

* style

* AppAttest Attestation API tests draft

* Error cases tests

* style

* Cleanup and API docs

* Merge fix

* Fix OCMock imports

* Fix nullability modifier

* Formatting

* comments

* App Check App Attest initial handshake adjustments (#8067)

* calculatre sha256 of random challenge for attestation

* Test app adjustments

* cleanup

* use trailing closures in the test app

* Implement API for ExchangeAppAttestAssertionRequest endpoint (#8065)

* Implement assertion exchange

* Tweak existing tests

* Add tests

* Rename JSON to better match gRPC  message

* Add HTTPBody helper

* Review

* Review 2

* Review 3

* App Check App Attest assertion flow (#8083)

* App Attest assertion workflow draft

* send request

* assertion flow tests

* style

* App Check: store App Attest artifact per key ID (#8097)

* Update artifact storage API and tests

* Artifact storage implementation update

* Save artifact for a key ID

* Style

* typos

* App Check: prevent concurrent token requests (#8117)

* App Attest multiple get token method invocation tests

* Ensure a single App Attest handshake sequence at the time

* FIRAppCheckTests: get token request merging tests

* FIRAppCheck: Ensure a single get token operation at the time

* formatting

* Test new request after merged requests

* Release finished operation promise

* Style

* Typos

* typo

* Request merging tests for error cases

* formatting

* Changelog

* App Check App Attest: handle attestation rejection (#8170)

* Remove/update outdated TODOs

* [WIP] Attestation rejection handling draft

* style

* retry tests draft

* reset key ID before retry

* Reset attestation

* test error and fixes

* style

* More details in the name

* Some debug logging

* style

* Use specific codes for log messages

* style

* Add FIRAppAttestProvider.h the umbrella header

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
2021-06-01 10:47:57 -04:00
47e0a982fb App check and storage, functions and RTDB support (#7928)
* AppAttestation initial public API

* Run ./scripts/style.sh

* Copyright

* Cleanup

* Cleanup

* Get token forcing refresh method

* Formatting

* Forcing refresh samples

* Interop introduced

* Code samples for Interop

* Run  ./scripts/style.sh

* Cleanup

* TODOs and Copirights

* Fix build

* Supported iOS versions

* Remove unnecessary bridging header

* Run  ./scripts/style.sh

* [WIP] DeviceCheckAttestationProvider as a subspec

* cleanup

* Add memory attributes to readonly properties

* Move FIRDeviceCheckAttestationProvider.h to private headers

* TODO for `FirebaseAppAttestation/Core` name

* Remove memory attributes from FIRAppAttestationToken properties

* FIRAppAttestationTests.testSetAttestationProviderFactory introduced

* FIRAppAttestationToken initializer

* Basic FIRLibrary implementation and FIRAppAttestationProviderFactory ingestion.

* Fix

* FIRAppAttestationToken+Interop.h

* TODOs

* Tests: reset FIRApps

* GHA for App Attestation

* Run ./scripts/style.sh

* Style fixes.

* Run ./scripts/style.sh

* TODO

* Nullable initializer and type annpotations

* TODOs

* TODOs

* TODO

* Fix spec and allow warnings

* AppAttestation initial public API

* Run ./scripts/style.sh

* Copyright

* Cleanup

* Cleanup

* Get token forcing refresh method

* Formatting

* Forcing refresh samples

* Interop introduced

* Code samples for Interop

* Run  ./scripts/style.sh

* Cleanup

* TODOs and Copirights

* Fix build

* Supported iOS versions

* Remove unnecessary bridging header

* Run  ./scripts/style.sh

* [WIP] DeviceCheckAttestationProvider as a subspec

* cleanup

* Add memory attributes to readonly properties

* Move FIRDeviceCheckAttestationProvider.h to private headers

* TODO for `FirebaseAppAttestation/Core` name

* Remove memory attributes from FIRAppAttestationToken properties

* FIRAppAttestationTests.testSetAttestationProviderFactory introduced

* FIRAppAttestationToken initializer

* Basic FIRLibrary implementation and FIRAppAttestationProviderFactory ingestion.

* Fix

* FIRAppAttestationToken+Interop.h

* TODOs

* Tests: reset FIRApps

* Run ./scripts/style.sh

* Style fixes.

* Run ./scripts/style.sh

* TODO

* Nullable initializer and type annpotations

* TODOs

* TODOs

* TODO

* Revert FirestoreDecoder.swift formatting.

* Basic implementation of FIRDeviceCheckAttestationProvider and tests (#626)

* DeviceCheck attestation provider sceleton

* DeviceCheck attestation provider sceleton

* Basic FIRDeviceCheckAttestationProviderTests

* Run ./scripts/style.sh

* FIRAppAttestStorage implementation and tests (#627)

* FIRDeviceCheckAttestationProvider designated init

* FIRAppAttestStorage API and basic tests.

* FIRAppAttestStoredToken: NSSecureCoding implementation

* WIP Storage

* Add `accessGroup` param to `FIRAppAttestStorage`

* FIRAppAttestStorage implementation

* Use constants

* FIRAppAttestStorage API doc

* Coding style and typos.

* Code formatting

* Attestation Token caching (#630)

* Storage instance and looging

* AppAttestation caching

* Tests and cleanup

* Cleanup

* Rename App Attestation -> App Check (#631)

* Rename App Attestation -> App Check

* Run ./scripts/style.sh

* Update GHA

* Default Custom Provider (#633)

* AppCheck: remove not unnecessary public API (#634)

* AppCheck: remove not unnecessary public API

* Run ./scripts/style.sh

* AppCheck: DeviceCheck token server API (#635)

* Generic HTTP request handling

* [draft] AppCheck: device check HTTP API and simple tests

* Parse response

* Cleanup

* AppCheck: API errors and tests (#636)

* AppCheck errors

* API service tests and fixes

* Cleanup

* Run ./scripts/style.sh

* Naming

* AppCheck: Register device check provider factory as a default (#637)

* AppCheck errors

* API service tests and fixes

* Cleanup

* Run ./scripts/style.sh

* AppCheck: register FIRDeviceCheckProvider as a component

* Naming

* Registre device check provider factory as a default

* FIRDeviceCheckProvider tests

* AppCheck: API communication common for all providers moved to FIRAppCheckAPIService (#640)

* FIRAppCheckAPIService introduced

* Move URL seession stub to FIRURLSessionOCMockStub

* Run ./scripts/style.sh

* Move approximate date comparing to FIRDateTestUtils

* compose request in FIRAppCheckAPIService

* FIRAppCheckAPIServiceTests

* Use FIRAppCheckAPIService in FIRDeviceCheckProvider

* Cleanup

* DeviceCheck mock server integration and tests (#686)

* DeviceCheck mock server integration and tests

* TODO

* Update FIROptions.h import

* Temporary add FirebaseAppCheck to skip import validation

* TestUtilities moved to SharedTestUtilities

* FirebaseAppCheck.podspec:  TestUtilities->SharedTestUtilities

* SwiftPM: add OCMock dependency to SharedTestUtilities

* FIRURLSessionOCMockStub: #import "OCMock.h"

* App Check: Firebase 7 fixes (#715)

* AppCheck Firebase 7

* FirebaseCore repo-relative imports

* Fix FIRAppCheckStorage.m compilation

* Repo relative imports

* linebreak

* AppCheck: debug FAC token provider (#716)

* AppCheck Firebase 7

* FirebaseCore repo-relative imports

* Fix FIRAppCheckStorage.m compilation

* Repo relative imports

* linebreak

* Remove FIRAppCheckDefaultCustomProvider

* FIRAppCheckDebugProvider introduced

* FIRAppCheckDebugProviderTests

* style

* Print locally generated debug token to console

* Fix imports

* mullability and line breaks

* typo

* Comments

* TODO

* AppCheck: merge into single spec (package) (#717)

* Standard package folder structure

* Move interop header into AppCheck sources folder

* Combine public headers in the standard dir

* Private headers to internal

* Podspec

* Headers import udpdate

* style

* Fix header imports

* Enable check_imports.swift and fix imports

* AppCheck: server request adjustments (#718)

* Wrap DeviceCheck token into JSON

* AppChek - remove static_framework requirement

* WIP

* Update default base URL

* Set content-type header

* Check for empty response data

* Fix tests

* Style and formatting

* Podspec - revert wrong change and remove static_framework

* Assign error to error pointer safely.

* AppCheck: primitive test app (#719)

* Remove static_framework requirement

* WIP: FIRAppCheckTestApp introduced

* Delete .plist

* Copyright

* Remove empty test targets

* pod deintegrate

* Remove test targets from Podfile

* formatting

* Storage: integration with AppCheck (#720)

* Storage: add AppCheck interop dependency

* Inject AppCheck into FIRStorageTokenAuthorizer

* initial AppCheck integration

* Introduce AppCheck fake

* AppCheck fake implementation

* FIRStorageTokenAuthorizer tests and fixes

* @"Authorization" header constant

* Log AppCheck error.

* Cleanup

* FIRStorageTokenAuthorizerTests: helpers

* TODO

* Cleanup

* AppCheck: separate 2P and 3P API (#724)

* FIRAppCheckInterop: remove a convenience method.

* Rename: FIRAppCheckTokenInterop->FIRAppCheckTokenResultInterop

* FIRAppCheckTokenResult introduced

* Update FIRAppCheckTokenHandlerInterop,  FIRAppCheckTokenResultInterop and tests

* style

* Update token result

* Update storage integration

* Adjust check_imports.swift for test files

* Don't use internal AppCheck classes in Storage tests

* style

* Rename token to tokenResult in 2P API

* Add private Core headers to app check sources

* Fix storage log message code format

* token clarification comments in API docs

* Rename token->tokenResult

* AppCheck cleanup (#737)

* Fix public headers import

* Cleanup imported test utils

* FirebaseAppCheck podspec: revert git URL

* AppCheck: Debug token to AppCheck token exchange API (#739)

* GUL: make NSURLSession promise extension public

* Use NSURLSession+GULPromises to send requests

* style

* Move FIRAppCheckToken+APIResponse to Core dir

* rename

* FIRAppCheckDebugProviderAPIService introduced

* Move async token parsing API to FIRAppCheckToken extension

* Move token exchange response handling to FIRAppCheckAPIService. Tests WIP.

* Move API response parsing tests to FIRAppCheckAPIServiceTests

* FIRAppCheckDebugProviderAPIServiceTests

* Cleanup

* style

* App Check debug provider: integrate with exchange API (#743)

* Move FIROption validation to FIRAppCheckValidator

* FIRAppCheckDebugProvider token exchange and tests

* Fix FIRAppCheckDebugProviderFactoryTests

* style

* App Check test app debug provider fix (#747)

* App Check: minor touchups (#750)

* Update dummy token value

* Print local debug token to logs

* Require GoogleUtilities v7.2 and above

* Print debug token on init

* Don't print debug token again

* App Check: use prod environment (#751)

* App Check: use prod backend by default.

* Update token expiration threshold

* App Check SwiftPM support (#753)

* AppCheck SwiftPM package definition

* Promise header import fix

* OCMock header fix

* Fix fixture dependent tests

* Exclude Keychain dependent tests

* License

* ./scripts/style.sh

* Cleanup

* Format with proper SwiftFormat version

* `.process` resources.

* Swift tests target

* Cleanup and code formatting

* App Check: token auto-refresh (#754)

* FIRAppCheckTokenRefresher API defined

* FIRAppCheckTokenRefresher implementation draft

* [WIP] Token refresher integration

* Token refresher integration

* FIRAppCheckTests: token refresher tests

* FIRAppCheckTests: additional tests cases

* FIRAppCheckTimer introduced

* FIRAppCheckTokenRefresher: use FIRAppCheckTimer instead of the dispatch timer.

* FIRFakeTimer

* FIRAppCheckTokenRefresherTests testInitialRefresh

* FIRAppCheckTokenRefresherTests: testNextRefreshOnRefreshSuccess

* ./scripts/style.sh

* Exponential backoff

* Style and comments

* Move token refresh files to a separate folder

* FIRAppCheckTimerTests

* FIRAppCheck: use expicit class in init

* FIRAppCheckDebugProviderFactory Swift name

* FIRAppCheckTokenRefresher: Increment/decrement directly

* App Check fixes (#755)

* Fix backoff: no backoff for the initial request

* Use eager initialization

* FIRAppCheckTokenRefresher: don't refresh until handler set

* FIRAppCheckIntegrationTests: disable token refresher

* Fix testInitialRefresh test

* style

* FIRAppCheckIntegrationTests fix

* Temporary exclude App Check from platfrom logging (#756)

* App Check: send app check SDK version only in the header (#757)

* App Check: store FAC token per app ID (#758)

* App Check: store FAC token per app ID

* update podspec

* API docs

* FIRAppCheck initWithApp tests

* AppCheckCustomProvideApp (#760)

* Functions: App Check integration (#762)

* Functions: app check API added to FUNContextProvider

* FUNContextProviderTests

* FUNContextProvider app check support

* ./scripts/style.sh

* FIRFunctions: pass FAC token as HTTP header

* Fix SPM

* Fix Firebase-Package scheme bad merge

* Cleanup

* RTDB: pass FAC token to web socket (#763)

* RTDB: pass FAC token to web socket

* FIRAppCheckFake default init

* Rename FAuthTokenProvider to FIRDatabaseConnectionContext; integrate with App Check

* Pass App Check token in the HTTP header

* Rename

* Fix existing tests

* TODO

* ./scripts/style.sh

* Context provider: assume separate FAC token change listener

* FIRDatabaseConnectionContextProviderTests

* Remove unused files

* Copy NSMutableURLRequest

* Cleanup

* ./scripts/style.sh

* FIRDatabaseConnectionContextProvider: sync callback when no auth or app check

* Cleanup

* Rename "authToken" leftovers to "context"

* Fix renaming

* Pass missing headers to NSURLSessionWebSocketTask

* Cleanup

* add a name to TODO

* App Check: token update notifications (#764)

* AppCheck: token did change API and tests

* notification implementation and fixes

* Run ./scripts/style.sh

* Update comments

* RTDB: send app check token updates to keep connection open (#765)

* Pass AppCheck instance as an object into the the FAC token update notification

* FIRDatabaseConnectionContext: add FAC token change listener API

* formatting

* Send FAC token updates to open connection

* More informative empty response message

* refreshAppCheckToken fixes

* Remove assertion

* Don't modify state

* forceTokensRefresh -> forceTokenRefreshes

* Call listeners on [FIRDatabaseQuery sharedQueue]

* App Check API cleanup and docs (#766)

* AppCheck public API and docs cleanup

* More API docs

* Fix compilation errors

* typos and wording

* Make summary different from description (pod lib lint warning)

* port app check workflow changes from another branch

* pod lib lint: remove --allow-warnings

* App Check cleanup (#767)

* Cleanup debug code and outdated TODOs

* Fix FIRDeviceCheckProvider availablility for SPM

* Fix availability in tests

* Fix availability in tests

* Make sure os requirements are consistent for tests specs

* Migrate v1alpha URLs to v1beta

* Migrate v1alpha URLs to v1beta

* Run ./scripts/style.sh

* Functions tests: fix Xcode 11 warnings (#7931)

* Functions tests: fix Xcode 11 warnings

* style

* App Check: token auto-refresh opt-out API (#769)

* FIRAppCheckSettings introduced (WIP)

* FIRAppCheckSettingsTests

* Style

* Make FIRAppCheckSettings instance per-app.

* FIRAppCheckTokenRefresher: use FIRAppCheckSettings.isTokenAutoRefreshEnabled (WIP)

* Tests

* Add public instance getters

* Fix analyzer warnings

* Fix testspec OS versions

* FIRAppCheckTokenRefresher expiration date update; tests

* FIRAppCheck.isTokenAutoRefreshEnabled implementation and tests

* style

* FIRAppCheck: Use specific types for variables in the default init

* More precise comments

* missing symbol

* FIRAppCheckSettings: remove defensive conditions from init.

Co-authored-by: Nick Cooke <nickcooke@google.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
2021-04-21 21:01:11 -04:00