Commit Graph
49 Commits
Author SHA1 Message Date
Nick Cooke e28a1a1a84 refactor(misc): remove obsolete OS availability checks (#16313) 2026-07-09 16:40:30 -04:00
Paul Beusterien 67834c366f Fix module build issues (#13797) 2024-10-04 11:46:35 -04:00
Paul Beusterien 8f44bbcbcf Fix FIROptions module organization (#13765) 2024-10-02 07:49:28 -07:00
Seyed Mojtaba Hosseini Zeidabadi afd6e0b16e Fix all FirebaseAppDistribution typos (#13750) 2024-10-01 07:46:45 -07:00
Paul Beusterien 7d7cbad7bd [v11] Update minimum platform versions for 11.0.0 (#13066) 2024-06-05 07:39:36 -07:00
Paul Beusterien f5309bf45b [v11] Remove unused FIRDependency class (#13053) 2024-06-04 06:56:50 -07:00
Yakov Manshin 7434377e3b Removed Unused Availability Checks (#13023) 2024-05-28 09:20:31 -07:00
Takumi Muraishi ffedaed448 Fix typos (#12783) 2024-04-13 13:34:36 -07:00
Lee Kellogg 02acacc81d Fix tester sign in URL (#10773)
This was errantly updated to the correct new path without updating the host from `appdistribution.firebase.dev`  to `appdistribution.firebase.google.com`.
2023-02-03 09:21:01 -05:00
Morgan Chen 25c29f5928 Make App Distribution compatible with swizzling-disabled implementations (#10418)
* Revert "Include subheaders in script output (#10212)"

This reverts commit 11313da887.

* make app distro swizzling compatible

* add changelog

* fix build
2022-10-31 12:56:46 -07:00
Kai Bolay 282d3628e5 Use new URL for registering installation ID. Avoids a redirect by SCS. (#10365) 2022-10-18 17:43:54 -04:00
Tejas DeshpandeandNick Cooke 018fd7ec73 Fix sign in alert shown inconsistently when triggered in viewDidAppear (#10288)
* Simple fix for #8096

* Update FirebaseAppDistribution/CHANGELOG.md

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
2022-09-29 17:02:11 -04:00
Ryan Wilson 2cbb180697 App Distro: fix async/await issue (#9634)
* App Distro: fix async/await issue

Right now we're calling a completion handler with `nil, nil` when
releases are fetched but none are marked as "latest". This shouldn't
happen, and is considered an error.

* Mark return type as optional

* Swfit tests

* Remove extra space

* Formatting

* Style again

* SwiftPM tests

* Revert version change

* [skip ci] Update CHANGELOG
2022-04-12 12:51:42 -04:00
Paul Beusterien 7b946765ec Remove slashes from log messages (#9391) 2022-04-06 14:19:47 -07:00
Ryan Wilson 2258c07ecb Swift Error Improvements (#9512)
* Firebase Messaging enum

* Add tests for App Check errors

* App Distribution Error

* Installations error improvements

* Remote Config errors

* Firestore error handling

* Formatting

* Silly import error

* Consistency for App Check tests.

* Typo fix
2022-04-04 10:36:38 -04:00
Ryan Wilson 49cc6aaaac Make AppDistro releaseNotes nullable. (#9552)
These were unintentionally marked as non-null, but should be nullable.

Fixes #8602
2022-03-31 16:58:07 -04:00
Nick Cooke a09083f9d0 [v9] Reorganize FirebaseCore* modules (#9482)
* [skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`

* Reorganize FirebaseCore libraries for SPM and CP

* [skip ci] Revert "[skip ci] [will revert] Add debug printing to `pod_lib_lint.rb`"

This reverts commit 2a837e39708c21b0a324743ab226bd6c01047de7.

* Review and fix CI

* Remove `heartbeat_logging.yml` and add `core_internal.yml`

* Remove trailing whitespace

* Fix more whitespace 😞

* Fix `core_internal.yml` scheme name

* Update `check_imports.swift` and TODO

* Review

* Add FirebaseCoreInternal pod to Firestore example's Podfile

* [skip ci] Review - remove TODOs

* [skip ci] Remove duplicate `XCTest` import
2022-03-23 06:08:14 -07:00
Paul Beusterien 4f793064da Set up Core Internal for SPM (#9298) 2022-03-23 06:07:17 -07:00
Paul Beusterien c7c0149351 Update to clang-format@13 (#8739) 2021-10-04 07:52:21 -07:00
Paul Beusterien c0df01d5f0 Fix Xcode 13 beta 3 build issues (#8405) 2021-07-19 07:18:36 -07:00
Paul Beusterien 0d90f2f12d Update to clang-format 12.0.1 (#8397) 2021-07-16 11:40:42 -07:00
rachaprince f59f7690c3 [App Distribution] Reset sign in flag on unauthorized error (#8270)
* [App Distribution] Reset sign in flag on unauthorized error

* Fix formatting and update CHANGELOG
2021-06-21 16:38:13 -04:00
Paul Beusterien c4e994c7c4 Update to clang-format 12 (#7909) 2021-04-16 09:17:41 -07:00
Paul Beusterien 2c26087481 Manage platform dependent tests in test targets (#7096) 2020-12-03 14:23:44 -08:00
Ryan Wilson f052459edb Fix AppDistro spm build for non-iOS platforms (#7091) 2020-12-03 12:24:19 -05:00
Ryan Wilson a60866383f Add AppDistribution to SwiftPM. (#7045)
* Add AppDistribution to SwiftPM.

Tests aren't ported yet due to an import OCMock issue.

* Embed public headers in correct directory

* Fix podspec

* Fixed new header imports.

* Add beta designation to SwiftPM name.

* Enable testing for AppDistro in SwiftPM

* Style

* Style

* Added changelog

* Add unit test scheme.
2020-12-02 11:51:29 -05:00
Jeremy Durham ad9e237e1b [App Distribution] Fix crash caused by response being nil (#7067)
* [App Distribution] Handle response being nil

When an error occurs, the response data will be nil. This causes a crash because we are trying to parse the response as JSON. Instead, return a generic error message if the response data is nil.
2020-12-01 23:10:45 -05:00
Maksym Malyhin 57285802ad FIS API docs: use term "installation auth token" consistently. (#6014)
* FIS API docs: use term "Installation auth token" consistently.

* Changelog

* Capitalize

* Use lowercase

* SHA1 usage explanation

* missed upper case

* a -> an
2020-10-13 16:59:05 -04:00
Paul Beusterien 83e898ab5c One Firebase version (#6634) 2020-10-02 12:26:22 -07:00
Cleo Schneider 6c846756c0 Add check for unauthenticated error and sign out in fetchNewLatestRelease (#6648)
* Add check for unauthenticated error and sign out in fetchNewRelase method

* Update CHANGELOG

* Add check for Tester sign in before calling fetch
2020-10-02 14:36:20 -04:00
Paul Beusterien f2bcd5d82b Make all GoogleUtilities APIs public (#6588) 2020-09-29 07:26:10 -07:00
Cleo Schneider 9bb809ca5a Update the API service to log the returned message from the API (#6458)
* Update the API service to log the raw message from the API

* Update CHANGELOG

* Run style script

* Update log formatting and changelog
2020-09-14 17:51:46 -04:00
Cleo Schneider ea8cfab025 App distribution add bundle header (#6346)
* Add x-ios-bundle-identifier to list releases for restricted api keys

* Update changelog

* Terminate changelog statements with periods
2020-08-27 10:32:14 -04:00
Morgan Chen 835bac1b08 Update doc comments for release (#6321)
* Update doc comments for release

* Remove not-parsed doc tag

* Add changelog entry
2020-08-24 10:30:26 -07:00
Jeremy Durham 85b705069d [App Distribution] Add isExpired to FIRAppDistributionRelease (#6282) 2020-08-17 13:03:16 -04:00
Jeremy Durham 130d76a665 [App Distribution] Remove typedefs (#6281)
Stop using typedefs for completion blocks in public APIs so that Xcode is more usable in Swift:
2020-08-17 10:46:29 -04:00
Jeremy Durham d686427cc0 [App Distribution] Show new build alert when version (or build) changes (#6255)
Show new build alert when version (or build) changes
2020-08-12 10:36:38 -04:00
Cleo Schneider e131a19810 Change the link from partnerdash.google.com to a appdistribution.firebase.dev (#6218) 2020-08-06 14:20:10 -04:00
Cleo Schneider a22ac08450 Add localized strings to the UIAlert (#6190)
* Add localized strings to the UIAlert

* Make the comment refer to the new build alert context
2020-08-03 13:18:54 -04:00
Cleo Schneider 9508dc4143 Update UIAlert copy. (#6182) 2020-07-31 16:16:51 -04:00
Jeremy Durham aba1fe0e96 Add fallback for iOS 13 when not using scenes (#6169) 2020-07-31 10:20:33 -04:00
Jeremy Durham 1b3605296b Unset window.rootViewController when resetting UI (#6157) 2020-07-30 10:42:03 -04:00
16e062c355 Switch App Distribution SDK from AppAuth to FirebaseInstallations (#6126)
* Adding error handling and returning correct error codes

* * Handling auth cancellation a few other error cases

* Adding some logging for EAP (Using NSLogs temporarily. DONOT MERGE)

* Add in a setter for clientID to allow overrides (#5514)

* Add in a setter for clientID to allow overrides

* Update styling

* Adding some result parsing logs

* Fixing code hash logging

* Add FirebaseAppDistribution to ZipBuilder

* * Making sure keychain is accesible after first unlock even if app is backgrounded (#5563)
* Fix auth persistence logging and invalid type casting (#5631)
* Logging app id requesting releases (#5655)

* AppDistribution keychain access fixes (#5683)

* Using the GULKeychainUtils instead of custom keychain utility. Also added better logging

* Updating keychain name and fixing tests

* Code review feedback updates

* Making serviceID unique per app

* Adding gmp app id to the keychain along with the bundle id

* Moving Keychain Utility functions in the AuthPersistence class and deleting the utility class

* Lazy initialize auth state (#5755)

* Lazy initialize auth state

* Making sure we dont log an error is auth state is not persisted in the keychain

* Switch from NSLog to FIRFADLogger (#5756)

* Add FIRLogger
* Switch from NSLog to FIRFADLogger

* * Use FIS Auth for authenticating the tester
* Remove AppAuth and start wiring up interceptor to do sign in

* Extracting registration flow UI in interceptor

* Adding support for iOS 9 and 10

* Create app distribution api service to handle tester api calls. (#6060)

* Pull out calls to the FAD API to make them reuseable

* Fix tests and run styl updates

* Uncomment FIRFADLog Statements

* Use [] accessor rather than . accessor

* Re-running style updates

* Trying to get these checks to pass the first time around

* App distribution signin persist (#6063)

* Pull out calls to the FAD API to make them reuseable

* Fix tests and run styl updates

* Add in UserDefaults storage after a tester has signed in

* Add testing for the main AppDistribution file

* Ran style.sh

* Remove FIRFADLocalStorage and call GULUserDefaults directly. Update tests to stop mocking on teardown.

* Add support for dynamic url schemes and fix two crashes (#6081)

* Add support for dynamic url schemes and fix two crashes

  * Add support for dynamic url schemes in the format appdistribution-<app id without colons>
  * Fix crash when launching an app directly via a URL scheme
  * Fix a crash on iOS 10 simulator caused by calling NSLogv twice
  * Remove uses of NSLog
  * Fix warnings

* Switch encodedAppId to be a class method

* Fix styles

* Create changelog and readme in preparation for release. (#6095)

Just changing markdown files so will not wait for gha checks.

* Change slices property from copy to strong (#6097)

Fix lint warning

* Change error handlers to return bool values instead of void (#6101)

* Mapping sign in flow errors to app distribution errors. Also renaming AppDelegateInterceptor to FIRAppDistributionUIService (#6099)

* Add github action for App Distribution (#6094)

* Updating app distribution deployment target to iOS 9 (#6118)

* Making sure we return granular errors during sign in persistence. Also fixing some naming and comment issues (#6117)

* Encoding colons to dashes in the app id (#6119)

* Move Internal headers to Sources (#6106)

* Move Internal headers to Sources/ folder

* PR feedback

* Remove appDistribution from zip builder

* Respond to code review feedback (#6138)

* Initializing UIWindow using initWithWindowScene for ios 13 and removing UI code from main FIRAppDistribution.m (#6144)

* Initializing UIWindow using initWithWindowScene for ios 13. Also making sure we only reset window in the App delegate if a registration flow is in progress.

* Remove UI code from main class, add unit tests, and clean up UIService

* stylish

* Remove defines in favor of solely 'if (@available(iOS 13.0, *))'

* Respond to code review feedback

Co-authored-by: Cleo Schneider <cleoschneider@google.com>

Co-authored-by: Pranav Rajgopal <pranavrajgopal@google.com>
Co-authored-by: Cleo Schneider <cleoschneider@google.com>
2020-07-28 16:39:29 -04:00
Paul Beusterien 3f556ddb9e Update GoogleUtilities' clients with repo-relative imports (#5824) 2020-06-16 09:05:29 -07:00
Paul Beusterien d4621a636f Use preserve_paths instead of CocoaPods private (#5758) 2020-06-09 05:21:28 -07:00
ec670ae0bb Persist auth information to the iOS keychain (#5460)
* Add initial code hash generation implementation

* Adding auth state to iOS keychain

* Cleanup logging and error handling for initial auth persistence implementation (#5413)

* Cleanup logging and error handling for initial auth persistence implementation

* Update Nullability of error fields and reformat

* Move the error domain and enum into the AuthPersistence file

* Format Mach files

* Externalize handling of nullable error and greedily return on error

* Add initial code hash generation implementation

* Adding auth state to iOS keychain

* Cleanup logging and error handling for initial auth persistence implementation (#5413)

* Cleanup logging and error handling for initial auth persistence implementation

* Update Nullability of error fields and reformat

* Move the error domain and enum into the AuthPersistence file

* Format Mach files

* Externalize handling of nullable error and greedily return on error

* Add unittests for AppDistribution auth persistence

* Split out the keychain calls from control flow and error handling

* Add mocking and tests for auth persistence tests

* Remove debug logging

* Update styling

* Re-add resources to podspec and break out block for readability

Co-authored-by: Jeremy Durham <jeremydurham@google.com>
Co-authored-by: Pranav Rajgopal <pranavrajgopal@google.com>
2020-04-30 14:29:33 -04:00
Pranav Rajgopal d3e040449d Cleaning up App Distribution UI window (#5510) 2020-04-30 11:49:43 -04:00
Jeremy Durham 7757c73670 App Distribution: Implement code hash generation and verification (#5432)
Add initial code hash generation implementation

Generate a code hash by getting the architecture and uuids for the app, sorting the list lexicographically by architecture, concatenating the uuids and generate a hash using SHA1 (for legacy purposes). We then use the code hash to verify against a hash returned from the server to determine whether the current running version is the latest version.
2020-04-23 13:09:50 -04:00
Pranav RajgopalandJeremy Durham 3fafd8d19a App distribution new build alerts sdk (#5204)
* Initial commit for Firebase App Distribution New Build Alerts SDK 
* Added public header and implemented the public methods
* Added App Delegate swizzling for the App Auth library


Co-authored-by: Jeremy Durham <jeremydurham@google.com>
2020-04-15 13:51:02 -04:00