Commit Graph
39 Commits
Author SHA1 Message Date
Paul Beusterien 0b977bd636 Revert "Remove #if SWIFT_PACKAGE checks for nanopb (#6163)" (#6164)
This reverts commit 303f8ca7bb.
2020-07-30 08:40:47 -07:00
Paul Beusterien 303f8ca7bb Remove #if SWIFT_PACKAGE checks for nanopb (#6163) 2020-07-30 06:49:46 -07:00
Paul Beusterien aacfe9ba74 one more internal ABT import fix (#6109) 2020-07-22 11:38:14 -07:00
Paul Beusterien d4a24bd5ec Some M76 changelog updates (#6080) 2020-07-20 16:22:59 -07:00
Paul Beusterien 2660d49c7d ABTesting - Repo-relative imports and SwiftPM (#6013) 2020-07-09 15:48:47 -07:00
Morgan Chen 757b51c269 Move doc domment fix to M76 (#6002) 2020-07-08 12:06:24 -07:00
Morgan Chen c5833b3298 Fix inaccurate doc comment (#5978)
* Fix inaccurate doc comment

* Add changelog

* amend changelog
2020-07-08 09:27:41 -07:00
christibbsandPaul Beusterien 9b484519f2 Remove Protobuf from the ABT SDK (#5890)
* Remove Protobuf dependency, add struct-ish class that mimics ABTExperimentPayload

* Remove a lot of the compiler errors, but not all of them. We need to figure out how RC serializes the NSData objects passed to FIRExperimentController in updateExperimentsWithServiceOrigin:

* Add ABTExperimentPayload class that replaces generated proto, refactor classes that depend on it

* Add unit testing class for ABTExperimentPayload

* Updates to ABTExperimentPayload API, tests for ABTConditionalUserPropertyTest, add tests for ABTExperimentPayload

* Update podspec to pull in testing resources

* Add utility class for parsing test files. Use it in ABTExperimentPayloadTests

* Fix FIRExperimentController tests

* Better documentation

* Run scripts/styles.sh

* Fix whitespace

* Remove protobuf imports

* Bump pod spec version for ABT SDK, depend on new ABT SDK in RC. Fix up RemoteConfigExperiment to use new ABTExperimentPayload object

* scripts/style.sh

* Update In-app messaging to use new ABTExperimentPayload class, which involves extending the ABTExperimentPayload initializer to accept different values for overflowPolicy and experimentStartTime

* Delete test payload

* Revert scripts/check_imports.swift

* Better initialization tags for ABTExperimentLite

* Update CHANGELOGs

* Remove private headers in podspec, use integerValue to parse integers

* Refactor ABTExperimentPayload header into Private headers. Fix integer types for millisecond metadata

* scripts/styles.sh

* Fix integer parsing

* Fix copyrights

* Fix CHANGELOG typo:

* Add private_header_files to public_header_files

* Try just using NSInteger for experimentStartTimeMillis

* Bump FIAM dependency on ABTesting

* Use long long for milli parameters (32-bit apps)

* Use longlong in test timestamps

* Don't cast to nsnumber in tests

* Use in64_t

* Fix Test Overflow

* Bump major version on ABT SDK

* Bump ABTesting version in Firebase.podspec

Co-authored-by: Paul Beusterien <paulbeusterien@google.com>
2020-07-06 13:06:39 -04:00
Paul Beusterien d653c9584c Update copyright presubmit and fix 2020 copyrights (#5944) 2020-06-29 13:16:19 -07:00
Paul Beusterien 87a1b7de5e M74 changelogs (#5921) 2020-06-25 16:34:03 -07:00
Paul Beusterien e03a8d91a0 Consolidate GDT and GDTCCT to a single pod (#5902) 2020-06-24 14:09:46 -07:00
Paul Beusterien c07c89ee75 Repo-relative imports for Installations (#5832) 2020-06-17 07:26:40 -07:00
Paul Beusterien 3f556ddb9e Update GoogleUtilities' clients with repo-relative imports (#5824) 2020-06-16 09:05:29 -07:00
Paul Beusterien e15724a436 Migrate from interop pods to source_files header access (#5760) 2020-06-09 06:09:27 -07:00
Paul Beusterien d4621a636f Use preserve_paths instead of CocoaPods private (#5758) 2020-06-09 05:21:28 -07:00
Kohki Miki e640d9cb22 Add assertion when in app message is in invalid state (#5753)
* Add assertion when in app message is in invalid state

* Update FirebaseInAppMessaging/Sources/Flows/FIRIAMDisplayExecutor.m
2020-06-05 16:13:52 -04:00
christibbs b4faa554c3 Change log message to reference FID instead of IID (#5680)
* Change log message to reference FID instead of IID

* Add CHANGELOG entry

* Slight changelog tweak
2020-05-27 11:26:35 -04:00
christibbs ca880b8061 Add FIAM release notes for M71 (#5580)
* Add release notes for M71

* Fix version number
2020-05-12 16:37:10 -04:00
christibbs a2d6fac79f Only log the URL follow event in messageClicked:withAction: if there's a URL to follow (#5564)
* Only log the URL follow event in messageClicked:withAction: if there's a URL to follow

* Add test case for empty action URL
2020-05-11 18:16:22 -04:00
Paul Beusterien 68513286e3 Update nanopb to 0.3.9.5 (CocoaPods 1.30905.0) (#4264) 2020-04-27 17:09:59 -07:00
Paul Beusterien 8e1be65b2f Verifies nanopb 0.3.9.5 update does not change generation (#5455) 2020-04-27 17:08:36 -07:00
rohandandavati d7e2f806cf add NSLocalizedString() (#5442) 2020-04-23 12:06:56 -04:00
Morgan Chen fe910eb669 Update FIAM changelog for M69 (#5419) 2020-04-21 12:39:34 -07:00
Paul Beusterien b90ddf1339 Limit Swift line lengths to 100 (#5315) 2020-04-08 10:48:24 -07:00
christibbs cf6fd9ef5d FIAM M68 changelog (#5236) 2020-03-31 16:02:01 -04:00
christibbs 2779d9ce36 Fix warnings in FIAM test projects (#5171)
* Migrate UI test project to Swift 5

* Fix warning in application:continueUserActivity: method signature

* Update to recommended settings in functional test apps

* Update to recommended settings in functional tests app

* Change organization name to Firebase, treat warnings as error
2020-03-25 12:03:27 -04:00
christibbs b8ed76d55c Release notes for M67 (#5127) 2020-03-17 14:55:27 -04:00
christibbs c7f8825679 In banner view, pin top elements to the bottom of the status bar (#5100)
* Add constraint to pin title label below status bar in banner FIAM

* Remove title label top pin from storyboard at build time

* Use conditional compilation for iOS 13 check
2020-03-17 13:27:53 -04:00
christibbs 72397a0c42 Use FIRInstallations SDK to fetch FID and FIS token, send those values in requests to FIAM backend (#5081)
* Depend on FIRInstallations instead of IID, load an installations object into FIRInAppMessagingPrivate.h

* Bootstrap FIRInAppMessaging.h with an instance of FIRInstallations

* Update FIRIAMClientInfoFetcher to use FIRInstallations method to grab FID and FIS Token

* Call new client info fetcher method

* Fix up tests

* Change nullability for FIRInstallations object, handle null case

* More verbose comments in FIRIAMClientInfoFetcher, call completion in case that FIS token is fetched, but FID fails

* Throw error and call completion if Firebase Installations object is not created

* Send FIS token with method fetch requests

* Add test class for FIRIAMClientInfoFetcher

* Refactor FIRIAMClientInfoFetcher to get a FIRInstallations object injected

* Add unit testing for fetchFirebaseInstallationDataWithProjectNumber: in FIRIAMClientInfoFetcher

* Streamline unit tests, add case for nil FirebaseInstallations, clean up comments that were left in
2020-03-13 17:25:48 -04:00
christibbs 31385e0f6f Remove cleanup of experiments that are no longer running (#5078)
* Remove cleanup of experiments that are no longer running (product decision)

* Revert podspec bump
2020-03-11 17:13:18 -04:00
christibbs f4d742f8fa M66 changelog for FIAM and ABT SDKs (#4920)
* M65 changelog for ABT SDK

* Improve CHANGELOG notes

* Fix CHANGELOG version

* M66 changelog for both FIAM & ABT

* Fix formatting

* Fix formatting pt2

* Put deprecated method in backticks
2020-03-06 13:21:58 -05:00
christibbs 4c776d1f74 Support AB testing of Firebase In-App Messages (#5005)
* Parse out experiment payload for experimental FIAMs and store it on FIRIAMMessageDefinition

* Fix bugs in parsing experimental payload

* Add nullable experiment payload to FIAM message definition. Add method in FIRExperimenmtController to validate running experiments and call this when new messages are fetched from FIAM backend

* Add and document new ABT methods, update FirebaseInAppMessaging.podspec to depend on ABT

* Clean up deprecated public message initializers, add experiment payload to private initializers

* Activate experiment for experimental messages upon impression

* Clean up activateExperiment API

* Add experimental payload to all message definition initializers

* Add unit test coverage for new ABT methods

* Add test coverage for parsing experimental messages

* Verify experiment payload gets passed to message superclass

* Scripts/style.sh

* Update Podfile for UI test app to include AB Testing SDK

* Add back deprecated initializers for now, these are needed for the test app

* Test for non-nil experiment payload

* Use mutable array directly, better memory usage

* Bump ABTesting podspec version, depend on new ABT in FIAM

* Remove mentions of FIREventOrigins.h

* Remove experiment payload from public API, hide it in private

* Scripts/style.sh

* Fix comment indentation, allow for FIAM to depend on minor version updates of ABTesting

* Move ABTExperimentPayload import to private header
2020-03-03 19:46:37 -05:00
rohandandavati ddaeaa2a46 M65 changelog for FIAM SDK (#4924)
* Update CHANGELOG.md

* change wording
2020-02-18 14:59:17 -08:00
rohandandavati ab818f8f8a Revert "Revert data bundles merge (#4820)" (#4922)
This reverts commit 630167b1b7.
2020-02-18 14:32:20 -08:00
rohandandavati 630167b1b7 Revert data bundles merge (#4820)
* Revert "added pragma statement to ignore initWithMessageID deprecation warning (#4754)"

This reverts commit e3854995a1.

* Revert "data bundles for consolidated sdk (#4739)"

This reverts commit 161ef56e09.
2020-02-04 15:53:45 -08:00
rohandandavati e3854995a1 added pragma statement to ignore initWithMessageID deprecation warning (#4754)
* added pragma statement to ignore initWithMessageID deprecation warning

* fix formatting, add push statement
2020-01-27 16:15:48 -08:00
rohandandavati 161ef56e09 data bundles for consolidated sdk (#4739)
* data bundles for consolidated sdk

* run scripts/style.sh

* copy to avoid giving NSMutableDictionary instance
2020-01-27 10:27:05 -08:00
Paul Beusterien dcf876d6a0 Delete duplicate function (#4744) 2020-01-24 11:01:29 -08:00
christibbs 48aa5ed5ee FIAM Consolidation (#4705)
* Move display SDK source and resources into FIAM SDK

* Change files prefixed with FID to be prefixed FIRIAM

* Restructure example apps in firebase-ios-sdk directory

* Fix directory structure for FIAM

* Move proto files into base directory

* Fix up proto files

* Move unit test files to Firebase/InAppMessaging/Tests

* Move FIRIAMSDKModeManagerTests and require app host in podspec

* Move sample apps to tests folder

* Add empty repo for FIAMDisplay that generates a warning

* Fix up functional tests app

* Fix up default UI test app

* Re-generate protos

* Add warning to remove display pod

* Remove display podspec from .travis.yml

* Remove trailing whitespace

* Fix import in test app

* Add changes to point to the default test app

* Wrap iOS version conditionals

* Add line in podspec about deprecation

* Delete whitespace in podspec

* Delete pods section in project file

* Update changelog with consolidation info

* Fix indentation in podspecs

* Fix some import issues

* Fix indent on FirebaseInAppMessaging.podspec

* Delete FirebaseInAppMessagingDisplay, update podfile for external test app

* Update podfiles, bump iOS min version to 9, remove iOS 9 checks in FIRIAMActionUrlFollowerTests

*  Add line in CHANGELOG referencing deletion of display sdk pod

* Remove unused podfile

* Update min version on Podfiles to iOS 9

* Add back FirebaseInAppMessagingDisplay.h

* Add iOS support message to CHANGELOG.md

* Wrap necessary deprecated iOS 9 call
2020-01-22 10:57:00 -05:00