Files
firebase-ios-sdk/GoogleDataTransport/GDTCORLibrary/GDTCOREvent.m
T
Michael Haney 27847eea38 Refactor event fileURLs to be derived (#5137)
* Refactor event fileURLs to be derived

Apparently, since iOS 8, it's possible for the app's bundle to change directories as often as every launch. This is a mechanism that's hopefully slightly more robust against that, as data is supposed to carry over, the UUID component of the app's absolute directory might just change.

* Convert a couple of tests, actually use a non-absolute URL in GDTCOREvent

* Make sure to use the event fileURL property as the source of truth.

Add some additional logs and improve the integration test

* Fix KVC not working for the removed property
2020-03-18 08:09:18 -07:00

216 lines
8.3 KiB
Objective-C

/*
* Copyright 2018 Google
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#import "GDTCORLibrary/Public/GDTCOREvent.h"
#import <GoogleDataTransport/GDTCORAssert.h>
#import <GoogleDataTransport/GDTCORClock.h>
#import <GoogleDataTransport/GDTCORConsoleLogger.h>
#import <GoogleDataTransport/GDTCORPlatform.h>
#import "GDTCORLibrary/Private/GDTCORDataFuture.h"
#import "GDTCORLibrary/Private/GDTCOREvent_Private.h"
@implementation GDTCOREvent
- (nullable instancetype)initWithMappingID:(NSString *)mappingID target:(NSInteger)target {
GDTCORAssert(mappingID.length > 0, @"Please give a valid mapping ID");
GDTCORAssert(target > 0, @"A target cannot be negative or 0");
if (mappingID == nil || mappingID.length == 0 || target <= 0) {
return nil;
}
self = [super init];
if (self) {
_mappingID = mappingID;
_target = target;
_qosTier = GDTCOREventQosDefault;
}
GDTCORLogDebug("Event %@ created. mappingID: %@ target:%ld", self, mappingID, (long)target);
return self;
}
- (instancetype)copy {
GDTCOREvent *copy = [[GDTCOREvent alloc] initWithMappingID:_mappingID target:_target];
copy.dataObject = _dataObject;
copy.qosTier = _qosTier;
copy.clockSnapshot = _clockSnapshot;
copy.customPrioritizationParams = _customPrioritizationParams;
copy->_GDTFilePath = _GDTFilePath;
GDTCORLogDebug("Copying event %@ to event %@", self, copy);
return copy;
}
- (NSUInteger)hash {
// This loses some precision, but it's probably fine.
NSUInteger mappingIDHash = [_mappingID hash];
NSUInteger timeHash = [_clockSnapshot hash];
NSInteger dataObjectHash = [_dataObject hash];
NSUInteger fileURL = [_GDTFilePath hash];
return mappingIDHash ^ _target ^ _qosTier ^ timeHash ^ dataObjectHash ^ fileURL;
}
- (BOOL)isEqual:(id)object {
return [self hash] == [object hash];
}
#pragma mark - Property overrides
- (void)setDataObject:(id<GDTCOREventDataObject>)dataObject {
// If you're looking here because of a performance issue in -transportBytes slowing the assignment
// of -dataObject, one way to address this is to add a queue to this class,
// dispatch_(barrier_ if concurrent)async here, and implement the getter with a dispatch_sync.
if (dataObject != _dataObject) {
_dataObject = dataObject;
}
}
- (NSURL *)fileURL {
if (!_GDTFilePath) {
_GDTFilePath = [NSString stringWithFormat:@"event-%lu", (unsigned long)self.hash];
}
return [GDTCORRootDirectory() URLByAppendingPathComponent:_GDTFilePath];
}
#pragma mark - Private methods
- (BOOL)writeToGDTPath:(NSString *)filePath error:(NSError **)error {
NSData *dataTransportBytes = [_dataObject transportBytes];
if (dataTransportBytes == nil) {
_GDTFilePath = nil;
_dataObject = nil;
return NO;
}
NSURL *fileURL = [GDTCORRootDirectory() URLByAppendingPathComponent:filePath];
BOOL writingSuccess = [dataTransportBytes writeToURL:fileURL
options:NSDataWritingAtomic
error:error];
if (!writingSuccess) {
GDTCORLogError(GDTCORMCEFileWriteError, @"An event file could not be written: %@", fileURL);
return NO;
}
_GDTFilePath = filePath;
_dataObject = nil;
return YES;
}
#pragma mark - NSSecureCoding and NSCoding Protocols
/** NSCoding key for mappingID property. */
static NSString *mappingIDKey = @"_mappingID";
/** NSCoding key for target property. */
static NSString *targetKey = @"_target";
/** NSCoding key for qosTier property. */
static NSString *qosTierKey = @"_qosTier";
/** NSCoding key for clockSnapshot property. */
static NSString *clockSnapshotKey = @"_clockSnapshot";
/** NSCoding key for fileURL property. */
static NSString *fileURLKey = @"_fileURL";
/** NSCoding key for GDTFilePath property. */
static NSString *kGDTFilePathKey = @"_GDTFilePath";
/** NSCoding key for customPrioritizationParams property. */
static NSString *customPrioritizationParams = @"_customPrioritizationParams";
/** NSCoding key for backwards compatibility of GDTCORStoredEvent mappingID property.*/
static NSString *kStoredEventMappingIDKey = @"GDTCORStoredEventMappingIDKey";
/** NSCoding key for backwards compatibility of GDTCORStoredEvent target property.*/
static NSString *kStoredEventTargetKey = @"GDTCORStoredEventTargetKey";
/** NSCoding key for backwards compatibility of GDTCORStoredEvent qosTier property.*/
static NSString *kStoredEventQosTierKey = @"GDTCORStoredEventQosTierKey";
/** NSCoding key for backwards compatibility of GDTCORStoredEvent clockSnapshot property.*/
static NSString *kStoredEventClockSnapshotKey = @"GDTCORStoredEventClockSnapshotKey";
/** NSCoding key for backwards compatibility of GDTCORStoredEvent dataFuture property.*/
static NSString *kStoredEventDataFutureKey = @"GDTCORStoredEventDataFutureKey";
/** NSCoding key for backwards compatibility of GDTCORStoredEvent customPrioritizationParams
* property.*/
static NSString *kStoredEventCustomPrioritizationParamsKey =
@"GDTCORStoredEventcustomPrioritizationParamsKey";
+ (BOOL)supportsSecureCoding {
return YES;
}
- (id)initWithCoder:(NSCoder *)aDecoder {
GDTCORDataFuture *dataFuture = [aDecoder decodeObjectOfClass:[GDTCORDataFuture class]
forKey:kStoredEventDataFutureKey];
if (dataFuture) {
return [self initWithCoderForStoredEventBackwardCompatibility:aDecoder
fileURL:dataFuture.fileURL];
}
NSString *mappingID = [aDecoder decodeObjectOfClass:[NSString class] forKey:mappingIDKey];
NSInteger target = [aDecoder decodeIntegerForKey:targetKey];
self = [self initWithMappingID:mappingID target:target];
if (self) {
_qosTier = [aDecoder decodeIntegerForKey:qosTierKey];
_clockSnapshot = [aDecoder decodeObjectOfClass:[GDTCORClock class] forKey:clockSnapshotKey];
NSURL *fileURL = [aDecoder decodeObjectOfClass:[NSURL class] forKey:fileURLKey];
if (fileURL) {
_GDTFilePath = [fileURL lastPathComponent];
} else {
_GDTFilePath = [aDecoder decodeObjectOfClass:[NSString class] forKey:kGDTFilePathKey];
}
_customPrioritizationParams = [aDecoder decodeObjectOfClass:[NSDictionary class]
forKey:customPrioritizationParams];
}
return self;
}
- (id)initWithCoderForStoredEventBackwardCompatibility:(NSCoder *)aDecoder
fileURL:(NSURL *)fileURL {
NSString *mappingID = [aDecoder decodeObjectOfClass:[NSString class]
forKey:kStoredEventMappingIDKey];
NSInteger target = [[aDecoder decodeObjectOfClass:[NSNumber class]
forKey:kStoredEventTargetKey] integerValue];
self = [self initWithMappingID:mappingID target:target];
if (self) {
_qosTier = [[aDecoder decodeObjectOfClass:[NSNumber class]
forKey:kStoredEventQosTierKey] integerValue];
_clockSnapshot = [aDecoder decodeObjectOfClass:[GDTCORClock class]
forKey:kStoredEventClockSnapshotKey];
if (fileURL) {
_GDTFilePath = [fileURL lastPathComponent];
} else {
_GDTFilePath = [aDecoder decodeObjectOfClass:[NSString class] forKey:kGDTFilePathKey];
}
_customPrioritizationParams =
[aDecoder decodeObjectOfClass:[NSDictionary class]
forKey:kStoredEventCustomPrioritizationParamsKey];
}
return self;
}
- (void)encodeWithCoder:(NSCoder *)aCoder {
[aCoder encodeObject:_mappingID forKey:mappingIDKey];
[aCoder encodeInteger:_target forKey:targetKey];
[aCoder encodeInteger:_qosTier forKey:qosTierKey];
[aCoder encodeObject:_clockSnapshot forKey:clockSnapshotKey];
[aCoder encodeObject:_GDTFilePath forKey:kGDTFilePathKey];
[aCoder encodeObject:_customPrioritizationParams forKey:customPrioritizationParams];
}
@end