firebase-ios-sdk

0 Fork 0

mirror of https://github.com/firebase/firebase-ios-sdk synced 2026-11-11 22:55:59 +05:45

Files

T

Michael Lehenbauer 4d7c973369 Fix b/72502745: OnlineState changes cause limbo document crash. (#470 ) (#714 )

[PORT OF https://github.com/firebase/firebase-js-sdk/pull/470]

Context: I made a previous change to raise isFromCache=true events when the
client goes offline. As part of this change I added an assert for
"OnlineState should not affect limbo documents", which it turns out was not
valid because:
* When we go offline, we set the view to non-current and call
	View.applyChanges().
* View.applyChanges() calls applyTargetChange() even though there's no target
	change and it recalculates limbo documents.
* When the view is not current, we consider no documents to be in limbo.
* Therefore all limbo documents are removed and so applyChanges() ends up
	returning unexpected LimboDocumentChanges.

Fix: I've modified the View logic so that we don't recalculate limbo documents
(and generate LimboDocumentChanges) when the View is not current, so now my
assert holds and there should be less spurious removal / re-adding of limbo
documents.

2018-01-27 15:03:05 -08:00

collection_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

existence_filter_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

limbo_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

limit_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

listen_spec_test.json

b/68276665: Raise isFromCache=true events when offline (#567 )

2017-12-15 14:56:03 -08:00

offline_spec_test.json

Fix b/72502745: OnlineState changes cause limbo document crash. (#470 ) (#714 )

2018-01-27 15:03:05 -08:00

orderby_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

persistence_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

README.md

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

remote_store_spec_test.json

Port of fix for b/67042460 (retry more often before considering client offline) (#403 )

2017-10-23 10:10:34 -07:00

resume_token_spec_test.json

Release 4.3.0 (#327 )

2017-10-03 08:55:22 -07:00

write_spec_test.json

Sending an empty write request before tearing down the stream (#438 )

2017-11-08 17:04:41 -08:00

README.md

These json files are generated from the web test sources.

TODO(mikelehen): Re-add instructions for generating these.