* Re-tier HTTP request timeouts around per-source memory
Replaces the single global "recent timeout" slot in `HTTPRequestTimeoutManager`
with a per-host map (`host -> lastTimeoutDate`, 10-minute per-entry expiry,
pruned on access) and re-tiers the request timeouts:
- Main-source, endpoint with no fallback-URL support: 15s base / 5s reduced
- Main-source, endpoint with fallback-URL support: 5s base / 2s reduced
- Fallback-host and proxied requests: flat 30s (never consult the memory)
A main-source request to host H uses the reduced tier iff H has a non-expired
timeout entry. Timeouts are now recorded for any non-fallback request (dropping
the previous fallback-support-only condition), keyed by attempt host; a
successful main-source response clears only that host's entry. Renames the
`timeoutOnMainBackendForFallbackSupportedEndpoint` result to `mainSourceTimedOut`.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Define flat timeout tier as a Timeout constant
Co-authored-by: Cursor <cursoragent@cursor.com>
* Add exhaustive multi-host tests for timeout manager
Co-authored-by: Cursor <cursoragent@cursor.com>
* Honor developer networkTimeout via internal NetworkTimeout enum
Introduce an internal NetworkTimeout enum (.default/.custom) threaded from
Configuration down to HTTPRequestTimeoutManager. When a developer sets
networkTimeout, it replaces the built-in base/flat tiers while the reduced
fail-fast tiers stay fixed.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Add NetworkTimeout.swift to RevenueCat.xcodeproj
The file was only picked up by the SPM/Tuist directory globs, so the
hand-maintained Xcode project build failed to resolve the type.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Gate re-tiered no-fallback timeouts behind usesRemoteConfigAPISources
The aggressive no-fallback fail-fast timeouts and their per-host timeout
recording now apply to main-API requests only when the usesRemoteConfigAPISources
dangerous setting is enabled. With it disabled (the default) the legacy network
timeout is preserved. The gating is a per-call timeout(...) parameter so
blob-source downloads can opt into the re-tiered timeouts independently.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Keep the legacy flat timeout when re-tiered timeouts are off, and share one manager
The fallback-host and proxied tiers returned the new 30s flat timeout regardless of
`usesRemoteConfigAPISources`, halving the legacy 60s (or custom) network timeout for
proxy users and every fallback-host request. They now honor `reTieredTimeoutsEnabled`
like the no-fallback tier does, so only the fallback-supported tiers behave the same
either way.
`Backend` also built one timeout manager per HTTPClient, so the main and remote-config
lanes kept independent per-host memories despite talking to the same hosts. They now
share one, and `HTTPClient` requires both the manager and the network timeout so this
wiring can't be dropped silently.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Clear a host's fail-fast memory as soon as it answers
The memory exists to remember how quickly a host responds, so a non-error
response is evidence the host recovered even when decoding or verifying it
fails afterwards. Deciding off the raw status code instead of the parsed result
keeps those failures from leaving a responsive host stuck on the reduced
timeout tier.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Name the requestTimeoutManager in the fail-fast comment
Co-authored-by: Cursor <cursoragent@cursor.com>
* Tighten comments on the Backend-shared failover and timeout manager
Name the instances the comments describe so it's clear what is shared.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Record API source timeouts before health checks
* Test shared timeout state across backend lanes
* Normalize URL timeout classification across platforms
* Remove unused RemoteConfigAPI test hook
* Skip HTTP stubs lane tests on watchOS
* Treat the remote config fallback path as a fallback host request
`FallbackPath` bakes the fallback host into its `serverHostURL`, but `fallbackUrlIndex` is
nil on those requests, so `isFallbackURLRequest` was false and they were classified as
main-source: with API sources enabled they drew the aggressive 15s/5s no-fallback tiers
instead of the flat fallback timeout, their timeouts armed the per-host fail-fast memory
for the fallback host, and their successes cleared the main source's entry.
Add `isFallbackHostPath` so a path can declare that it targets a fallback host on its own,
and use it alongside the index when picking the tier and updating the memory.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com>
* refactor: model ForceServerErrorStrategy interception as a single Action enum
The two closures (`fakeResponseWithoutPerformingRequest` and
`shouldForceServerError`) encoded an implicit precedence rule that only lived in
a doc comment. A single closure returning `Action` makes each request resolve to
exactly one outcome.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor: log the destination URL and faked status code when forcing errors
Both messages previously identified only the request, so a faked 404 and a faked
204 looked identical, and there was no way to tell whether a forced error routed
to the 502 endpoint or to an unreachable host.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(remote-config): force the config kill-switch via force_killswitch query param
The Maestro E2E app faked a local 404 for /v1/config, which never exercised the
backend's real kill-switch response. RevenueCat/khepri#23311 adds an opt-in
`force_killswitch=true` query param that serves the actual 400
CONFIG_ENDPOINT_DISABLED for that request only.
`serverErrorURL` cannot be reused here because it replaces the whole URLRequest,
dropping the method, auth headers and body the endpoint needs.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor: model ForceServerErrorStrategy interception as a single Action enum
The two closures (`fakeResponseWithoutPerformingRequest` and
`shouldForceServerError`) encoded an implicit precedence rule that only lived in
a doc comment. A single closure returning `Action` makes each request resolve to
exactly one outcome.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor: log the destination URL and faked status code when forcing errors
Both messages previously identified only the request, so a faked 404 and a faked
204 looked identical, and there was no way to tell whether a forced error routed
to the 502 endpoint or to an unreachable host.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(remote-config): health-check-gated API source failover in HTTPClient
Wires the API source failover into the request pipeline, still behind the
usesRemoteConfigAPISources dangerous setting (internal and defaulting to
false, so released behavior is unchanged):
- Requests resolve their API source once (in start) and carry the handle,
so a failure can report the exact source unhealthy and ETag/backoff
retries keep targeting the same host.
- On a failure that points at the host, the source is health-checked
before failing over: a healthy source surfaces the original error, an
unhealthy one is reported and the request transparently retries on the
next source (capped at 5 source attempts per request). The static
per-endpoint fallback hosts stay the last resort.
- Unlike Android, device-connectivity errors (reusing
NetworkError.isAllowedToRetryWithFallbackHost) skip the health check
entirely and surface the original error: switching hosts can't fix a
device that is offline.
- Both Backend HTTPClients share one APISourceFailover, so they walk one
source list and share one health-check cache.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(remote-config): end-to-end API source failover integration tests
Port of purchases-android's BackendAPISourceFailoverIntegrationTest: real
Backend.getCustomerInfo through the production wiring (real HTTPClients,
shared APISourceFailover, real SourceHealthChecker probing over the URL
loading system) and a real RemoteConfigSourceProvider fed by an in-memory
sources topic, with OHHTTPStubs standing in for the source hosts and
recording exact per-host request order. Adds the iOS-only
device-connectivity scenario and a dangerous-setting-off wiring check on
top of Android's seven scenarios.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor: model the request's API source as a single state enum
Replaces the three loosely coupled Request fields (apiSource,
apiSourceResolved, apiSourceAttemptCount) with one APISourceState enum
(unresolved / noSource / source(_, attemptCount:)), making inconsistent
combinations unrepresentable. No behavior change.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor: adopt the narrowed APISourceFailover initializer
Passes just the usesRemoteConfigAPISources flag at the two construction
sites, following the signature change in the base branch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs: clarify why static fallback still runs when the source is healthy
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(remote-config): raise the API failover restart interval to 2 hours
The api source list now returns to the primary source 2 hours after it
first failed over instead of 10 minutes. Timer tests derive their time
values from the constant so future changes are single-line.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* test(remote-config): cover shared failover and probe-in-flight ordering
Addresses review feedback:
- Both HTTPClient lanes share one APISourceFailover: a failover on the
main lane advances the source list the remote-config lane resolves.
- A request enqueued while a health check is in flight stays queued
until the probe resolves and runs after the front-queued failover
retry.
- Bind the source and attempt count in one pattern match at the
failover guard.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* refactor: drop the APISourceState.attemptCount accessor
Its only caller pattern-matches instead, surfacing the "must already
target a source" assumption at the one place it matters rather than
papering over impossible states with a 0 default.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(remote-config): wire manager behind feature flag
* fix(remote-config): only mark refresh fresh after cache write
* feat(remote-config): source API base host from remote-config sources
Resolve the API base host from the shared RemoteConfigSourceProvider (with
the embedded defaults as a floor) instead of the hardcoded apiBaseURL, so
requests can fail over across API hosts. proxyURL and an overridden
apiBaseURL still pin the host and bypass API sources, and per-endpoint
fallback URLs are unchanged.
The provider is created once in the composition root (gated on
remoteConfigEnabled) and injected explicitly into Backend/HTTPClient; nil
preserves the existing SystemInfo.apiBaseURL behavior.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): derive nullable API source provider and manager from remoteConfigEnabled
Create the RemoteConfigSourceProvider (and its shared on-disk cache) up front,
gated on remoteConfigEnabled, and build the RemoteConfigManager from the
provider's nullability after Backend exists so it can reuse backend.remoteConfigAPI.
Keeps a single shared source provider + disk cache across the networking layer
and the manager, and avoids touching the disk cache directory when remote config
is disabled.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): drop redundant remote-config wiring comment
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): drop redundant remote-config manager comment
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): simplify APISourceProviding doc comment
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): always wire API source provider, gate only disk cache
Create the RemoteConfigSourceProvider unconditionally and inject it into
Backend/HTTPClient so main-API host resolution runs even when remote config
is disabled (embedded default sources as the floor). Only the on-disk cache
and the real RemoteConfigManager stay gated on remoteConfigEnabled; the
provider's topic store is now optional (nil means defaults-only).
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): rename APISourceProviding to APISourceProviderType
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat(remote-config): resolve web billing host from API sources
The web billing paths are hosted on the same api.revenuecat.com host as the
main API, so they should resolve their base host from the API source provider
too (with failover) instead of the static serverHostURL.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): drop redundant web billing API-sources comments
The comments restated what the code and surrounding context already convey.
Co-authored-by: Cursor <cursoragent@cursor.com>
* test(remote-config): assert ETag retry stays on the API source host
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(remote-config): drop APISourceProviderType, use RemoteConfigSourceProviderType directly
The networking layer depended on the narrow APISourceProviderType protocol, an extra
abstraction over RemoteConfigSourceProviderType that added little. Fold currentAPISource()
into RemoteConfigSourceProviderType and have HTTPClient/Backend depend on it directly.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(remote-config): wire apiSourceProvider into dedicated remote-config lane
The main-into-branch merge left `HTTPClient.dedicatedRemoteConfig` (and its
call site) without the new `apiSourceProvider` argument, breaking compilation.
Thread the provider through so the dedicated `/config` lane also resolves its
base host from remote-config API sources, matching the main lane.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat: gate remote-config API sources behind usesRemoteConfigAPISources
Resolve main-API request hosts from the remote-config API sources only when
the `usesRemoteConfigAPISources` dangerous setting is enabled. When disabled
(the default), requests keep targeting the static `SystemInfo.apiBaseURL`.
Enable the setting in the API-source `HTTPClient` tests and add a test
asserting an injected provider is ignored while the setting is off.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(test): pass apiSourceProvider in BackendRemoteConfigLaneTests HTTPClient init
The lane test constructed HTTPClient without the now-required apiSourceProvider
argument, breaking compilation of the unit test target after merging main.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
* other(networking): don't switch hosts on device-connectivity errors
Add `NetworkError.isDeviceConnectivityError` (true only for device-side
URLError codes) and narrow the fallback-host retry gate to
`isTransient && !isDeviceConnectivityError`, so a device that is offline
no longer triggers pointless host switching. Host-side and ambiguous
failures stay switch-eligible.
Co-authored-by: Cursor <cursoragent@cursor.com>
* other(networking): make isDeviceConnectivityError doc less usage-specific
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(ads): move rewardverification to coresdk
* refactor(ads): move rewardverification to coresdk
* refactor(ads): move rewardverification to coresdk
* refactor(ads): remove unnecessary comment
* fix(ads): linter and behavior fixes
* fix(ads): gate reward-verification VC cache invalidation out of CustomEntitlementComputation
* refactor(ads): rename reward-verification transactionId → clientTransactionID
* fix(ads): remove duplicated SSV payload logic from AdMob adapter
* chore(ads): cover install via injectable
* chore(ads): fix linter
* refactor(ads): introduce RewardVerificationToken
* refactor(ads): add reward_verification_completed log
* Update AdapterSDKs/RevenueCatAdMob/Tests/RevenueCatAdMobTests/PresentRewardVerificationTests.swift
Co-authored-by: Antonio Pallares <ajpallares@users.noreply.github.com>
* fix(ads): linter
* fix(ads): key reward verification poll retries on HTTP status
Retry network/offline transport errors and any HTTP 5xx during reward
verification polling, keying on the HTTP status code rather than the
mapped ErrorCode. Empty/unparseable 5xx responses are now retried, and
4xx client errors fail fast as .backendError instead of being retried to
a misleading .timeout.
* refactor(ads): drop redundant comments on poll retry classifier
* refactor(ads): read poll HTTP status via typed NSError accessor
* refactor(ads): reuse SDK retry classification for poll errors
Classify reward-verification poll retries from the structured BackendError
instead of re-deriving the HTTP status from a flattened public NSError.
Adds a reusable NetworkError.isTransient (5xx and connection-level failures
are transient, 4xx are terminal) and forwards it from BackendError; the
HTTPClient fallback-host retry check now delegates to it. The poll path keeps
the structured BackendError via an internal fetchRewardVerificationStatus,
letting the poller reuse BackendError.isTransient and dropping the bespoke
NSError.httpStatusCode accessor.
Co-authored-by: Cursor <cursoragent@cursor.com>
* chore(ads): switch from experimental to internal
* docs(ads): reference BackendError in Poller doc comment
---------
Co-authored-by: Peter Porfy <peter.porfy@revenuecat.com>
Co-authored-by: Pol Miro <polmiro@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
* Add workflows network layer for multipage paywalls
- Add `getWorkflows` and `getWorkflow` endpoint paths
- Add `WorkflowsListResponse` and `PublishedWorkflow` response models
- Add `WorkflowDetailProcessor` to handle `inline`/`use_cdn` response actions
- Add `WorkflowCdnFetcher` protocol and `DirectWorkflowCdnFetcher` implementation
- Add `GetWorkflowsOperation` and `GetWorkflowOperation` cacheable network operations
- Add `WorkflowsAPI` facade and wire into `Backend`
- Add unit tests for all new components
iOS equivalent of https://github.com/RevenueCat/purchases-android/pull/3300
Made-with: Cursor
* fix xcodeproj
* reset Package.resolved
* Update WorkflowStep models to match actual backend response
- Add WorkflowTrigger struct (name, type, action_id, component_id)
- Add triggers, outputs, and metadata fields to WorkflowStep
- Add metadata field to PublishedWorkflow
- Remove value field from WorkflowTriggerAction (backend uses step_id only)
Made-with: Cursor
* Update WorkflowResponseTests to match updated models
- Replace value/resolvedTargetStepId assertions with stepId
- Remove testDecodeWorkflowTriggerActionValueTakesPrecedence (value field removed)
- Add testDecodeWorkflowTrigger for new WorkflowTrigger struct
- Add testDecodePublishedWorkflowWithMetadata
- Update testDecodeWorkflowStepDefaults to cover triggers, outputs, metadata
- Add testDecodeWorkflowStepMatchingActualBackendResponse with real backend payload
Made-with: Cursor
* Disable file_length lint rule in HTTPRequestPath.swift
Made-with: Cursor
* Fix GetWorkflowOperation to compute result once before distributing to callbacks
CDN fetch and JSON decoding were running once per deduplicated callback.
Compute the Result<WorkflowFetchResult, BackendError> once outside the
performOnAllItemsAndRemoveFromCache loop, matching the pattern used by
GetOfferingsOperation and other operations in the codebase.
Made-with: Cursor
* Fix CDN fetcher: use URLSession instead of Data(contentsOf:), classify errors correctly
- Replace Data(contentsOf:) with URLSession.shared.dataTask + DispatchSemaphore
in DirectWorkflowCdnFetcher; gets URLSession timeout, HTTP status validation,
and proper network stack semantics
- Add WorkflowDetailProcessingError.cdnFetchFailed typed error so CDN I/O
failures are distinguishable from envelope parsing failures
- Catch cdnFetchFailed in GetWorkflowOperation and map to NetworkError.networkError
instead of NetworkError.decoding, fixing misleading error classification
- Update WorkflowDetailProcessorTests to assert the typed error is thrown
Made-with: Cursor
* Replace semaphore CDN fetch with async/await using withCheckedThrowingContinuation
- Make WorkflowCdnFetcher.fetchCompiledWorkflowData async throws; use
withCheckedThrowingContinuation to bridge URLSession.dataTask into async,
avoiding any thread-blocking
- Make WorkflowDetailProcessor.process async throws to propagate async
- Bridge into async in GetWorkflowOperation via Task {}; completion() is
called inside the Task after CDN fetch and decoding complete
- Update WorkflowDetailProcessorTests to async throws with await
Made-with: Cursor
* Make CDN fetcher and processor completion-handler based for consistency
Avoids Task{} in GetWorkflowOperation and keeps all operations calling
completion() synchronously from within the HTTP callback, matching every
other operation in the codebase.
- WorkflowCdnFetcher.fetchCompiledWorkflowData now takes a completion handler;
DirectWorkflowCdnFetcher uses URLSession.dataTask (non-blocking, no semaphore)
- WorkflowDetailProcessor.process now takes a completion handler; inline action
completes synchronously, use_cdn fans out to the fetcher callback
- GetWorkflowOperation splits into getWorkflow/handleResponse/backendResult/
distribute helpers to stay within line-length limits
- WorkflowDetailProcessorTests updated to use waitUntilValue pattern
Made-with: Cursor
* Fix ambiguous cache key delimiter in GetWorkflowOperation
Space-separated appUserID+workflowId could collide (e.g. user 'a b' + workflow 'c'
== user 'a' + workflow 'b c'). Use newline as delimiter, matching the precedent
set by GetWebBillingProductsOperation.
Made-with: Cursor
* PR comments
* remove cdn fetcher
* fix response in BackendGetWorkflowsTests.swift
* fix WorkflowResponseTests
* fix error
* [skip ci] Generating new test snapshots (#6584)
* [skip ci] Generating new test snapshots (#6585)
* [skip ci] Generating new test snapshots (#6586)
* [skip ci] Generating new test snapshots (#6587)
* [skip ci] Generating new test snapshots (#6588)
* [skip ci] Generating new test snapshots (#6589)
* [skip ci] Generating new test snapshots (#6590)
* Test CDN mock is not re-assignable per test
* [skip ci] Generating new test snapshots (#6597)
* [skip ci] Generating new test snapshots (#6598)
* [skip ci] Generating new test snapshots (#6599)
* [skip ci] Generating new test snapshots (#6600)
* [skip ci] Generating new test snapshots (#6601)
* [skip ci] Generating new test snapshots (#6602)
* [skip ci] Generating new test snapshots (#6603)
* getWorkflow is signed
* add type parameter
* add response verification for CDN response
* remove workflows list
* add value to WorkflowTriggerAction
* step id
* hash and filerepo
* missingCdnHash
* linter and project
* fix project
* revert Package.resolved
* @unchecked Sendable
* use hash in generateOrGetCachedFileURL
* fix compilation
* skip responseVerificationMode in cdn
* change basePath of caches
* remove reserialization
* Use explicit type in GetWorkflowOperation.createFactory for greppability
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix swiftlint identifier_name violation in WorkflowDetailProcessorTests
Rename short variable `d` to `doubleValue` in two `if case .double(let d)`
patterns to satisfy the identifier_name rule requiring names >= 3 characters.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* remove default FileRepositoryType
* fix project
* fix test
* test preserves camel case
* Generating new test snapshots for `feat/workflows-network-layer` - ios-15 (#6654)
* Generating new test snapshots for `feat/workflows-network-layer` - ios-14 (#6656)
---------
Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
Co-authored-by: Facundo Menzella <facumenzella@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Facundo Menzella <facumenzella@users.noreply.github.com>
Adapter modules that import the SDK with `@_spi(Internal) import RevenueCat`
(e.g. `RevenueCatAdMob`) need to read the configured public API key when
constructing payloads such as the AdMob SSV `customRewardString`.
- Store the API key on `SystemInfo` and wire it through `Purchases` init.
- Add `@_spi(Internal) public var apiKey: String` on `Purchases`.
- Add a Swift API tester case so any future signature change is caught.
- Add a unit test verifying the accessor returns the configured key.
The key is already public plaintext in the app binary, so exposing it as SPI
does not introduce any new security risk.
* Send X-Installation-Method header in all API requests
Detect at compile time which package manager was used to integrate the
SDK (SPM, CocoaPods, or prebuilt XCFramework) and send it as a new
X-Installation-Method header on every HTTP request. This helps the
backend understand how customers integrate the SDK.
Made-with: Cursor
* Add installation method assertions to installation tests
Expose installationMethod via @_spi(Internal) on Purchases and verify
the correct value in each installation test project (SPM, CocoaPods,
Carthage, Xcode direct, and XCFramework).
Made-with: Cursor
* [skip ci] Generating new test snapshots (#6433)
* [skip ci] Generating new test snapshots (#6435)
* [skip ci] Generating new test snapshots (#6434)
* [skip ci] Generating new test snapshots (#6440)
* [skip ci] Generating new test snapshots (#6436)
* [skip ci] Generating new test snapshots (#6437)
* [skip ci] Generating new test snapshots (#6438)
* [skip ci] Generating new test snapshots (#6439)
* [skip ci] Generating new test snapshots (#6443)
* Fix missing COCOAPODS_INSTALLATION flag on CocoaPods test targets
The flag was only set on the app target, not on the test targets, so
the #if COCOAPODS_INSTALLATION branches in InstallationTests.swift
were never compiled for CocoaPods tests. Add OTHER_SWIFT_FLAGS with
-DCOCOAPODS_INSTALLATION to all four CocoaPods test target configs.
Made-with: Cursor
---------
Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
* Implemented initial HTTPRequestTimeoutManager + added first couple of tests
* Cleaned up the code and added a bunch more unit tests based on the Android test suite
* Updated doc format
* Add new files to workspace
* Added HTTPClient tests testing interaction with timeout manager
* Swiftlint fixes
* Updated comment
* Add missing file to workspace
* Fix after rebase
* Added extra HTTPClient <-> HTTPRequestTimeoutManager tests asserting on the recorded events
* Implemented PR feedback
* Fixed compile issue
* Fix compile issue
* Implemented PR feedback
* Removed deleted file reference from workspace
* Fixed test after changing reset timeout
* Make sure the default HTTPRequistTimeoutManager is using the default value from the HTTPClient
* Add a sophisticated test testing the full timeout flow against an unroutable IP for a real world scenario
* Updated timeout case name
* Fixed case where .timeoutOnMainBackendForFallbackSupportedEndpoint was also recorded for non timeouts and added tests to prevent regression
* Fixed only stubbing the HTTP response based on path, since that could be the same across hosts, resulting in flaky tests
* Implemented tracking ConnectionErrorReason using DiagnosticsTracker on HTTP errors
* Add new file to workspace
* Updated string value of ConnectionErrorReason cases to match Android implementation
* [skip ci] Generating new test snapshots (#5868)
* [skip ci] Generating new test snapshots (#5869)
* [skip ci] Generating new test snapshots (#5870)
* [skip ci] Generating new test snapshots (#5871)
* [skip ci] Generating new test snapshots (#5872)
* [skip ci] Generating new test snapshots (#5874)
* [skip ci] Generating new test snapshots (#5873)
* Updated the list of URLError.code's that we consider a network error
---------
Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
* Implemented initial HTTPRequestTimeoutManager + added first couple of tests
* Cleaned up the code and added a bunch more unit tests based on the Android test suite
* Updated doc format
* Add new files to workspace
* Added HTTPClient tests testing interaction with timeout manager
* Swiftlint fixes
* Updated comment
* Add missing file to workspace
* Fix after rebase
* Added extra HTTPClient <-> HTTPRequestTimeoutManager tests asserting on the recorded events
* Implemented PR feedback
* Fixed compile issue
* Fix compile issue
* Implemented PR feedback
* Removed deleted file reference from workspace
* Fixed test after changing reset timeout
* Make sure the default HTTPRequistTimeoutManager is using the default value from the HTTPClient
* Add a sophisticated test testing the full timeout flow against an unroutable IP for a real world scenario
* Updated timeout case name
* Fixed case where .timeoutOnMainBackendForFallbackSupportedEndpoint was also recorded for non timeouts and added tests to prevent regression
* Fixed only stubbing the HTTP response based on path, since that could be the same across hosts, resulting in flaky tests
* Use offerings cache on (most) network errors
* Add unit tests for `NetworkError`'s `shouldFallBackToCachedOfferings`
* Add unit tests for `shouldFallBackToCachedOfferings`
* Fix lint
* Add some more unit tests
* Add `isLoadShedderResponse` and `isFallbackURLResponse` properties to `VerifiedHTTPResponse`
Keeps the values also when returned by the ETagManager
* lint
* Add some tests for ETagManager
* Rename `isFallbackURLResponse` to `isFallbackUrlResponse` to prevent decoding issues
* Add tests for actual source of original cached response of ETagManager
* Add tests to HTTPClientTests regarding the new booleans
* lint
* Add `originalSource` to `CustomerInfo`
* Adds `isLoadedFromCache` boolean to CustomerInfo
* Add docs
* Unit tests for new customer info properties
* Make `OriginalSource.CustomerInfo` a `String` enum
* Add decoding tests for Customer Info with new original source field
* Add `.loadShedder` check for Customer Info obtained in Load Shedder integration tests
* Update fixture
* improve internal docs
* Add intermediate object `Offerings.Contents` to wrap `OfferingsResponse` + `OriginalSource` and `loadedFromCache`
* Adapt existing unit tests to changes in `Offerings` underlying objects
* Check Offerings original source in existing integration tests
* Fix StoreKit unit tests
* Fix RevenueCatUI tests
* More Offerings.Contents tests
* Fix test
* Add more tests
* Fix lint
* [skip ci] Generating new test snapshots (#5741)
* [skip ci] Generating new test snapshots (#5742)
* [skip ci] Generating new test snapshots (#5743)
* [skip ci] Generating new test snapshots (#5744)
* [skip ci] Generating new test snapshots (#5745)
* [skip ci] Generating new test snapshots (#5746)
* [skip ci] Generating new test snapshots (#5747)
* [skip ci] Generating new test snapshots (#5748)
* Use enum for `HTTPResponseSource`
* Update tests
* Adapt to changes in `VerifiedHTTPResponse`
* Lint
* Adapt to changes in `VerifiedHTTPResponse`
* update tests
* Add log when a request to the fallback URL was handled by load shedder (which should never happen)
* rename `HTTPResponseSource` to `HTTPResponseOriginalSource`
* Adapt to changes
* fix lint
* Adapt to changes
* Fix CustomerInfo's OriginalSource implementation + fix unit test
* Fix tests compilation
* Add Cached offerings integration test
* Fix RCUI compilation
* Move isFromCache boolean from `Offerings.Contents` to `Offerings`
* Expand `ForceServerErrorStrategy` functionality
* Improve log when faking error response
* Correct implementation of fake error response without making a request (ForceServerErrorStrategy)
* Update tests + more tests
* Fix compilation of `OfferingsManagerTests`
* Fix compilation of `DebugViewSwiftUITests`
* Improve tests
* Fix `OfflineWithNoMappingStoreKitIntegrationTests`
* FIx compilation
---------
Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
* Add `isLoadShedderResponse` and `isFallbackURLResponse` properties to `VerifiedHTTPResponse`
Keeps the values also when returned by the ETagManager
* lint
* Add some tests for ETagManager
* Rename `isFallbackURLResponse` to `isFallbackUrlResponse` to prevent decoding issues
* Add tests for actual source of original cached response of ETagManager
* Add tests to HTTPClientTests regarding the new booleans
* lint
* Use enum for `HTTPResponseSource`
* Update tests
* Add log when a request to the fallback URL was handled by load shedder (which should never happen)
* rename `HTTPResponseSource` to `HTTPResponseOriginalSource`
* fix lint
* Added an internal API for overriding the API base URL
* Updated and added tests for API baseURL configuration option
* Revert change that removed serverHostURL from HTTPRequestPath since it broke other types implementing this protocol
* swiftlint
* Removed the apiBaseURL property from Purchases since it's only used for internal testing anyways
* Remove unused @_spi(Internal)
* Updated comment on api base URL vs proxy URL
* Fixed linting issue
* change fallback URL logic to support a different path from the main server
* Adapt unit tests to changes in fallback urls logic
* lint
* Add unit test for fallback urls
* fix switched logic
* Add new public APIs to RevenueCatUI to set the preferred local for the UI components
* fix compliation of RevenueCatUI with new APIs
* add API tests
* implement preferred locale in paywalls
* complete implementation
* adapt unit tests
* adapt paywalls tester
* Add new tests to check preferred locale override
* fix lint
* discard all changes in RevenueCatUI (for separate PR)
* remove trailing comma
* fix tests
* Fix tests
* fix paywalls tester compilation
* remove spoiler from future PR
* Refactor `PreferredLocalesProvider` (#5299)
* refactor: reduce `PreferredLocalesProviderType` into `PreferredLocalesProvider` class
* make `preferredLocaleOverride` private in `PreferredLocalesProvider`
* make `SystemInfo`'s `preferredLocalesProvider` private
* rename `PreferredLocalesProvider`'s mock init parameters
* fix compilation issue
* feat: implement fallback host in all URL requests
* cleanup fallback host API implementation
* Adapt existing tests to changes in `HTTPRequestPath`
* fix implementation
* add unit tests for fallback API host
* add extra unit test
* fix tests
* fix lint
* implement new `host` parameter in `http_request_performed` diagnostics event
* add unit tests for new `host` diagnostics parameter
* change the logic from fallback hosts to fallback paths
* fix test
* fix fallback endpoint for get product entitlement mapping
* fix backend integration tests not building after changes
* rewrite fallback host functionality knowing that only some specific requests support a fallback host
For those requests that support a fallback host, the path, headers and response structure remain the same
* fix text name
* fix unit test
* remove extra comma
* fix unit test
* feat: implement fallback host in all URL requests
* cleanup fallback host API implementation
* Adapt existing tests to changes in `HTTPRequestPath`
* fix implementation
* add unit tests for fallback API host
* add extra unit test
* fix tests
* fix lint
* change the logic from fallback hosts to fallback paths
* fix test
* fix fallback endpoint for get product entitlement mapping
* fix backend integration tests not building after changes
* rewrite fallback host functionality knowing that only some specific requests support a fallback host
For those requests that support a fallback host, the path, headers and response structure remain the same
* fix text name
* Add X-Is-Backgrounded header
* Add unit test for presence of new header
* [skip ci] Generating new test snapshots (#4939)
* [skip ci] Generating new test snapshots (#4940)
* [skip ci] Generating new test snapshots (#4941)
* [skip ci] Generating new test snapshots (#4942)
* [skip ci] Generating new test snapshots (#4943)
* [skip ci] Generating new test snapshots (#4944)
* [skip ci] Generating new test snapshots (#4945)
* Lock isAppBackgrounded state to false during tests
* one more update
* Revert "Lock isAppBackgrounded state to false during tests"
This reverts commit 6a915a756a.
* Lock isAppBackgrounded state to false during tests
* Update tests
* Fix iOS 15 snapshot tests
* Remove unused isApplicationBackgrounded async method
---------
Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
* refactor: create `DiagnosticsEvent.Properties` struct with all possible fields in a diagnostics event
* chore: remove unnecessary `CodingKeys` and values as `JSONEncoder.KeyEncodingStrategy.convertToSnakeCase` is used in the diagnostics requests
* tests: WIP: adapt unit tests to new `DiagnosticsEvent.Properties`
* fix: have values in Diagnostics events be snake case
* tests: adapt unit tests to Diagnostics events changes
* fix: `name` parameter in DiagnosticsEvent
* tests: fix snapshot testing of JSON to use `.iso8601` date format
* tests: have `JSONEncoder` of snapshot tests be a copy of the encoder user in the SDK
* tests: update the dates in the `CustomerInfo` snapshots for decoding tests to have ISO 8601 format
* fix: remove duplicated import
* refactor: centralize some info transformations in `DiagnosticsEvent.Properties`' init
* tests: add snapshot tests for `DiagnosticsEvents` object
* feat: add `is_retry` parameter to Diagnostics `http_request_performed` event
* tests: consider new `isRetry` parameter in existing `DiagnosticsEvent` tests
* fix: make sure that the `http_request_performed` event is always called
The previous implementation would skip sending the event in the case of getting a `networkError`
<!-- Thank you for contributing to Purchases! Before pressing the
"Create Pull Request" button, please provide the following: -->
### Checklist
- [ ] If applicable, unit tests
- [ ] If applicable, create follow-up issues for `purchases-android` and
hybrids
### Motivation
<!-- Why is this change required? What problem does it solve? -->
<!-- Please link to issues following this format: Resolves#999999 -->
### Description
This adds the `backend_error_code` property to diagnostics
`http_request_performed` events.
### Motivation
Better implementation of
https://github.com/RevenueCat/purchases-ios/pull/3909 and what was just
commited to `5.0-dev`
### Description
- Only install `swiftlint` on Xcode 15.3 jobs
- Also moved Ruby 3.2.2 install into `install-bundle-dependencies` which
was also done in `5.0-dev`
### Description
This adds a new diagnostics event `http_request_performed` with some
useful information we would like to track about the http requests
performed to our servers.
### Motivation
Allow backend to determine Storefront of customer
### Description
- Adds `X-Storefront` as a default header
- Uses `StoreKit 1` implementation since its not `async`
- `StoreKit 2` implementation is `async` and would require a some
restructuring that we don't need right now
---------
Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Fixes#3343.
`SKPaymentTransaction.error` docs say:
> The error property is undefined except when `transactionState` is set
to `SKPaymentTransactionState.failed`. Your application can read the
error property to determine why the transaction failed. For a list of
error constants, see `SKErrorDomain` in StoreKit Constants.
Which is why [`PurchasesOrchestrator` only considered that
domain](https://github.com/RevenueCat/purchases-ios/blob/4.28.1/Sources/Purchasing/Purchases/PurchasesOrchestrator.swift#L792).
This expands this handling to consider any other network error,
therefore providing more precise errors.
Since offline connection error detection was only in `HTTPClient`, I
also moved that out and removed `NetworkError.offlineConnection`, so
that we detect this when converting `NetworkError.networkError` instead.
See https://github.com/RevenueCat/khepri/pull/6798.
This can help debug issues as it helps us cross-reference requests on
our end.
### Changes:
- Logging `X-Request-ID` and `X-Amzn-Trace-ID` headers if present (only
in verbose mode)
- Logging these even for failed requests
- Also logging `request_handled_by_load_shedder` for failed requests
- To accomplish that. `HTTPURLResponse` now conforms to our
`HTTPResponseType`, this allows us to extract headers in an uniform way
### Example:
```
[network] DEBUG: ℹ️ API request completed: GET '/v1/subscribers/$RCAnonymousID%3Ad9dc4f3b33054cf28c0f2ec9da0f48d5' (304)
Request-ID: 'be534c50-5231-403b-be2f-7c077861751d'; Amzn-Trace-ID: 'Root=1-6532c6ca-7ef80f961ec9c4145484df13'
```
We get a lot of flaky failures on `OfflineStoreKitIntegrationTests`
(example:
https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/14843/workflows/a3cffa7c-da25-4811-931d-fc241befee0f/jobs/118214/tests).
I managed to reproduce locally running some of these 100+ times on a
loop until they failed.
I traced the issue to this sequence:
- SK2 purchase
- `StoreKit.Transaction.unfinished` is empty
This is likely due to a race condition. In practice, when computing
offline `CustomerInfo`, we never check it right away, since we need to
wait for the server to return a 500.
I filed a Radar for this: `FB13133387`.
To make tests more realistic, I introduced a delay in `HTTPClient`
returning fake 5xx errors. I haven't been able to reproduce this issue
again, so this should make `OfflineStoreKitIntegrationTests` more
reliable.
I've also added a new debug log that could help debug similar issues,
because `Strings.offline.computed_offline_customer_info` was not very
complete.
This paves the way to add a second set of paths with a separate server
URL to be able to shed requests to offerings and product entitlement
mapping to a separate server.
### Changes:
- New `HTTPRequestPath` with the same properties as `HTTPRequest.Path` +
a new `serverHostURL`
- Moved proxy logic from `SystemInfo`/`HTTPClient` to `HTTPRequestPath`
- Simplified `HTTPRequest` implementation
### Changes:
- `HTTPClient` has a new `X-Post-Params-Hash` request header
- Replaced `HTTPRequest.Method.post`'s `Encodable` value with a more
specific `HTTPRequestBody` (like `HTTPResponseBody`)
- `HTTPRequestBody` allows overriding `contentForSignature` (it defaults
to `[]`) which then `Signing` uses for the hash
- Fixed `LogInOperation` not passing the `VerificationResult` to the
result `CustomerInfo`. This is captured in unit and integration tests
now.
- Add support for signing `POST` requests in `Path.logIn` and
`Path.postReceiptData`
Depends on https://github.com/RevenueCat/khepri/pull/6246
