Files
purchases-ios/Sources/FoundationExtensions/OperationQueue+Extensions.swift
T
NachoSoto 1234c4ea91 CacheableNetworkOperation: avoid unnecessarily creating operations for cache hits (#2135)
### Changes:
- Created `CacheableNetworkOperationFactory` to abstract operation and
cache key creation
- Instead of always creating an operation, we create a factory first,
which pre-computes the cache key
- This cache key is used to determine if it's a cache hit, as well as
for the subsequently created operation

I'm still investigating a leak (#2105), and I suspect it's coming from
us creating and storing completion blocks, and those staying in memory
beyond the lifetime of the operation.
This refactor and performance improvement helps us avoid get more things
in memory than we need to.

See #2138 for how this is tested.
2022-12-21 08:13:41 -08:00

32 lines
884 B
Swift

//
// Copyright RevenueCat Inc. All Rights Reserved.
//
// Licensed under the MIT License (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://opensource.org/licenses/MIT
//
// OperationQueue+Extensions.swift
//
// Created by Joshua Liebowitz on 1/20/22.
import Foundation
extension OperationQueue {
final func addCacheableOperation<T: CacheableNetworkOperation>(
with factory: CacheableNetworkOperationFactory<T>,
cacheStatus: CallbackCacheStatus
) {
switch cacheStatus {
case .firstCallbackAddedToList:
self.addOperation(factory.create())
case .addedToExistingInFlightList:
Logger.debug(Strings.network.reusing_existing_request_for_operation(T.self, factory.cacheKey))
return
}
}
}